From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Andy Gross <andy.gross@linaro.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
Evan Green <evgreen@chromium.org>,
MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] phy: qcom-qmp: Add msm8998 PCIe QMP PHY support
Date: Tue, 26 Mar 2019 13:31:24 +0530 [thread overview]
Message-ID: <CAFp+6iGyV7E-e6rSz8zci1LM7stZVyKjgAxfV3KkdLNPpxOm_A@mail.gmail.com> (raw)
In-Reply-To: <136857e7-0fe1-6fc6-729e-2cbf6ea72386@ti.com>
Hi Marc,
On Tue, Mar 26, 2019 at 1:18 PM Kishon Vijay Abraham I <kishon@ti.com> wrote:
>
> Hi,
>
> On 22/03/19 9:42 PM, Marc Gonzalez wrote:
> > Copy init sequence from downstream:
> > https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8998-v2.dtsi?h=LE.UM.1.3.r3.25#n372
>
> Can't we instead have reference to HW manual or datasheet?
> >
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> > ---
> > .../devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +
> > drivers/phy/qualcomm/phy-qcom-qmp.c | 110 ++++++++++++++++++
> > drivers/phy/qualcomm/phy-qcom-qmp.h | 12 ++
> > 3 files changed, 127 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> > index 5d181fc3cc18..6000ae34b12b 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> > +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> > @@ -11,6 +11,7 @@ Required properties:
> > "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996,
> > "qcom,msm8998-qmp-usb3-phy" for USB3 QMP V3 phy on msm8998,
> > "qcom,msm8998-qmp-ufs-phy" for UFS QMP phy on msm8998,
> > + "qcom,msm8998-qmp-pcie-phy" for PCIe QMP phy on msm8998,
> > "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845,
> > "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845,
> > "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845.
> > @@ -48,6 +49,8 @@ Required properties:
> > "aux", "cfg_ahb", "ref".
> > For "qcom,msm8998-qmp-ufs-phy" must contain:
> > "ref", "ref_aux".
> > + For "qcom,msm8998-qmp-pcie-phy" must contain:
> > + "aux", "cfg_ahb", "ref".
> > For "qcom,sdm845-qmp-usb3-phy" must contain:
> > "aux", "cfg_ahb", "ref", "com_aux".
> > For "qcom,sdm845-qmp-usb3-uni-phy" must contain:
> > @@ -70,6 +73,8 @@ Required properties:
> > For "qcom,msm8998-qmp-usb3-phy" must contain
> > "phy", "common".
> > For "qcom,msm8998-qmp-ufs-phy": no resets are listed.
> > + For "qcom,msm8998-qmp-pcie-phy" must contain:
> > + "phy", "common", "cfg".
> > For "qcom,sdm845-qmp-usb3-phy" must contain:
> > "phy", "common".
> > For "qcom,sdm845-qmp-usb3-uni-phy" must contain:
>
> Please send the dt binding in a separate patch.
>
> Thanks
> Kishon
Thanks for the patch. Besides above comments from Kishon it looks good.
Reviewed-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Best regards
Vivek
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-03-26 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 16:12 [PATCH v1] phy: qcom-qmp: Add msm8998 PCIe QMP PHY support Marc Gonzalez
2019-03-26 7:45 ` Kishon Vijay Abraham I
2019-03-26 8:01 ` Vivek Gautam [this message]
2019-03-26 11:53 ` Marc Gonzalez
2019-03-26 13:24 ` [PATCH v2 1/2] " Marc Gonzalez
2019-03-26 13:26 ` [PATCH v2 2/2] dt-bindings: phy-qcom-qmp: Add qcom,msm8998-qmp-pcie-phy Marc Gonzalez
2019-03-26 16:10 ` [PATCH v2 1/2] phy: qcom-qmp: Add msm8998 PCIe QMP PHY support Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFp+6iGyV7E-e6rSz8zci1LM7stZVyKjgAxfV3KkdLNPpxOm_A@mail.gmail.com \
--to=vivek.gautam@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=jhugo@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).