From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Roger Quadros <rogerq@ti.com>
Cc: "Jack Pham" <jackp@codeaurora.org>,
"Peter Chen" <peter.chen@nxp.com>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
broonie@kernel.org, sre@kernel.org, robh+dt <robh+dt@kernel.org>,
shawnguo@kernel.org, rjw@rjwysocki.net,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
p.zabel@pengutronix.de,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Linux USB Mailing List" <linux-usb@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
s.hauer@pengutronix.de, mail@maciej.szmigiero.name,
troy.kisky@boundarydevices.com,
"Fabio Estevam" <festevam@gmail.com>,
oscar@naiandei.net, "Stephen Boyd" <stephen.boyd@linaro.org>,
linux-pm@vger.kernel.org,
"Joshua Clayton" <stillcompiling@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
mka@chromium.org,
"Vaibhav Hiremath" <vaibhav.hiremath@linaro.org>,
"Gary Bisson" <gary.bisson@boundarydevices.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
krzk@kernel.org, "Sriram Dash" <sriram.dash@nxp.com>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>
Subject: Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration
Date: Thu, 9 Feb 2017 17:40:50 +0530 [thread overview]
Message-ID: <CAFp+6iHQb9hUow99+vJ9TWYfZBFLd+ZAeqeRqMN-U_y=g9sRGQ@mail.gmail.com> (raw)
In-Reply-To: <6f131f15-d2f0-c8ac-c6af-accd23afab62@ti.com>
On Thu, Feb 9, 2017 at 5:24 PM, Roger Quadros <rogerq@ti.com> wrote:
>
>
> On 09/02/17 13:53, Roger Quadros wrote:
>>
>>
>> On 08/02/17 22:43, Jack Pham wrote:
>>> Hi Peter, Sriram, Arnd,
>>>
>>> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote:
>>>> From: Arnd Bergmann <arnd@arndb.de>
>>>>
>>>> For xhci-hcd platform device, all the DMA parameters are not
>>>> configured properly, notably dma ops for dwc3 devices. So, set
>>>> the dma for xhci from sysdev. sysdev is pointing to device that
>>>> is known to the system firmware or hardware.
>>>>
>>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
>>>> Tested-by: Baolin Wang <baolin.wang@linaro.org>
>>>> Tested-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>>>> Tested-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>>>> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>>>> ---
>>>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
>>>> index 6d33b42..7a9c860 100644
>>>> --- a/drivers/usb/host/xhci-plat.c
>>>> +++ b/drivers/usb/host/xhci-plat.c
>>>
>>>> - hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev));
>>>> + hcd = __usb_create_hcd(driver, sysdev, &pdev->dev,
>>>> + dev_name(&pdev->dev), NULL);
>>>
>>> As mentioned already in [1], usb_create_shared_hcd() is called to create
>>> the second bus, however it also needs to be converted.
>>>
>>> Not exactly as Roger's suggestion but this worked for me:
>>>
>>> - xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev,
>>> + xhci->shared_hcd = __usb_create_hcd(driver, sysdev, &pdev->dev,
>>> dev_name(&pdev->dev), hcd);
>>
>> But we're creating a shared_hcd and there is an API for that so why not use it
>> instead of calling __usb_create_hcd()?
>>
>
> Just realized after I pressed send that there is no sysdev parameter
> for create_shared_hcd().
That's right. The create_shared_hcd() makes use of only pdev->dev,
and we need to configure dma for shared_hcd as well though sysdev.
Sorry my mail client didn't show this mail in time. Please ignore my
earlier comment.
>
>>> if (!xhci->shared_hcd) {
>>> ret = -ENOMEM;
>>>
>>> Without this, SuperSpeed devices fail to enumerate:
>>>
>>> usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd
>>> usb 2-1: device descriptor read/8, error -11
>>> usb 2-1: new SuperSpeed USB device number 2 using xhci-hcd
>>> usb 2-1: device descriptor read/8, error -11
>>> usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd
>>> usb 2-1: device descriptor read/8, error -11
>>> usb 2-1: new SuperSpeed USB device number 3 using xhci-hcd
>>> usb 2-1: device descriptor read/8, error -11
>>> <and continues...>
>>>
>>> Thanks,
>>> Jack
>>>
>>> [1] https://lkml.org/lkml/2016/12/9/240
>>>
>>
>
> --
> cheers,
> -roger
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-02-09 12:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 9:13 [PATCH v12 0/9] power: add power sequence library Peter Chen
2017-02-06 9:13 ` [PATCH v12 1/9] binding-doc: power: pwrseq-generic: add binding doc for generic " Peter Chen
2017-02-06 9:13 ` [PATCH v12 2/9] power: add " Peter Chen
2017-02-06 9:13 ` [PATCH v12 3/9] usb: separate out sysdev pointer from usb_bus Peter Chen
2017-02-09 6:20 ` Vivek Gautam
2017-02-06 9:13 ` [PATCH v12 4/9] usb: chipidea: use bus->sysdev for DMA configuration Peter Chen
2017-02-06 9:13 ` [PATCH v12 5/9] usb: ehci: fsl: " Peter Chen
2017-02-06 9:13 ` [PATCH v12 6/9] usb: xhci: " Peter Chen
2017-02-08 11:57 ` Vivek Gautam
2017-02-09 1:45 ` Peter Chen
2017-02-08 20:43 ` Jack Pham
2017-02-09 1:41 ` Peter Chen
2017-02-09 6:15 ` Vivek Gautam
2017-02-09 11:53 ` Roger Quadros
2017-02-09 11:54 ` Roger Quadros
2017-02-09 12:10 ` Vivek Gautam [this message]
2017-02-10 1:40 ` Peter Chen
2017-02-09 12:08 ` Vivek Gautam
2017-02-06 9:13 ` [PATCH v12 7/9] usb: ehci: " Peter Chen
2017-02-06 9:13 ` [PATCH v12 8/9] binding-doc: usb: usb-device: add optional properties for power sequence Peter Chen
2017-02-06 9:13 ` [PATCH v12 9/9] usb: core: add power sequence handling for USB devices Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFp+6iHQb9hUow99+vJ9TWYfZBFLd+ZAeqeRqMN-U_y=g9sRGQ@mail.gmail.com' \
--to=vivek.gautam@codeaurora.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gary.bisson@boundarydevices.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=jackp@codeaurora.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@linux.intel.com \
--cc=mka@chromium.org \
--cc=oscar@naiandei.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=peter.chen@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=sriram.dash@nxp.com \
--cc=stephen.boyd@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=stillcompiling@gmail.com \
--cc=troy.kisky@boundarydevices.com \
--cc=ulf.hansson@linaro.org \
--cc=vaibhav.hiremath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).