From: Odin Ugedal <odin@uged.al>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Odin Ugedal <odin@uged.al>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Benjamin Segall <bsegall@google.com>,
Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/pelt: check that *_avg are null when *_sum are
Date: Thu, 3 Jun 2021 16:32:50 +0200 [thread overview]
Message-ID: <CAFpoUr01WeUEaE=Md3WVtgWbZv+8Vuz23ad-ucqeSW5g7fKsRg@mail.gmail.com> (raw)
In-Reply-To: <CAKfTPtCDPGJW=J6JmZ+Gs5kcptfWUwAsFs=xyCcoJ_hF--EkAA@mail.gmail.com>
> TBH I wondered while preparing this patch if tg_load_avg_contrib
> should be checked as well but I came to the conclusion that we should
> keep this looking at PELT metrics only. If tg_load_avg_contrib != 0
> but load_avg ==0, it means that we failed to update
> tg_load_avg_contrib somewhere else
Ahh, that sounds good. Agree.
Thanks
Odin
next prev parent reply other threads:[~2021-06-03 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 15:53 [PATCH] sched/pelt: check that *_avg are null when *_sum are Vincent Guittot
2021-06-02 6:45 ` [sched/pelt] e906550aca: WARNING:at_kernel/sched/fair.c:#update_blocked_averages kernel test robot
2021-06-03 10:50 ` Dietmar Eggemann
2021-06-03 10:59 ` Vincent Guittot
2021-06-03 10:42 ` [PATCH] sched/pelt: check that *_avg are null when *_sum are Dietmar Eggemann
2021-06-03 11:06 ` Odin Ugedal
2021-06-03 12:47 ` Vincent Guittot
2021-06-03 14:32 ` Odin Ugedal [this message]
2021-06-18 8:46 ` [tip: sched/core] sched/pelt: Check " tip-bot2 for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFpoUr01WeUEaE=Md3WVtgWbZv+8Vuz23ad-ucqeSW5g7fKsRg@mail.gmail.com' \
--to=odin@uged.al \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).