linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Enric Balletbo Serra <eballetbo@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Alexandru Stan <amstan@chromium.org>,
	Guenter Roeck <groeck@google.com>,
	kieran.bingham@ideasonboard.com,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	kernel@collabora.com, Benson Leung <bleung@chromium.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] phy: rockchip-inno-usb2: fix misspelling and kernel-doc documentation.
Date: Tue, 8 Jan 2019 18:35:38 +0100	[thread overview]
Message-ID: <CAFqH_50tz1Toi6L1Ju5imyMRPzN1bDg7mxzcLrJWvdxOwknfdw@mail.gmail.com> (raw)
In-Reply-To: <2908229.jFki8unlfB@phil>

Hi Heiko and all,

Missatge de Heiko Stuebner <heiko@sntech.de> del dia dc., 15 d’ag.
2018 a les 12:31:
>
> Am Mittwoch, 15. August 2018, 11:59:31 CEST schrieb Enric Balletbo i Serra:
> > Fix the typo flase -> false and clean up the kernel-doc documentation in
> > phy-rockchip-inno.usb2.c and fix the following warnings when documentation
> > is built.
> >
> >   :58: warning: missing initial short description
> >   :69: warning: cannot understand function prototype: 'enum usb_chg_state '
> >   :97: warning: missing initial short description
> >   :136: warning: cannot understand function prototype: 'struct rockchip_usb2phy_port_cfg '
> >   :157: warning: cannot understand function prototype: 'struct rockchip_usb2phy_cfg '
> >   :163: warning: Function parameter or member 'port_cfgs' not described in 'rockchip_usb2phy_cfg'
> >   :187: warning: cannot understand function prototype: 'struct rockchip_usb2phy_port '
> >   :204: warning: Function parameter or member 'port_cfg' not described in 'rockchip_usb2phy_port'
> >   :207: warning: missing initial short description
> >   :234: warning: Function parameter or member 'dev' not described in 'rockchip_usb2phy'
> >   :234: warning: Function parameter or member 'clk480m_hw' not described in 'rockchip_usb2phy'
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>

I included this patch in these series because I found the errors when
I was working on this. But this patch doesn't really depend on the
other patches and probably I should have had to send independently. I
am planning to send a new version of these series excluding this
patch. I think that the patch can be already picked (still applies
cleanly and is fine to pick?) or do you prefer I resend?

Thanks,
 Enric

>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2019-01-08 17:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15  9:59 [PATCH 0/4] phy: rockchip-inno-usb2: document improvements and allow to force B-device valid session bit Enric Balletbo i Serra
2018-08-15  9:59 ` [PATCH 1/4] phy: rockchip-inno-usb2: fix misspelling and kernel-doc documentation Enric Balletbo i Serra
2018-08-15 10:31   ` Heiko Stuebner
2019-01-08 17:35     ` Enric Balletbo Serra [this message]
2019-01-08 17:38       ` Heiko Stübner
2018-08-15  9:59 ` [PATCH 2/4] dt-bindings: phy-rockchip-inno-usb2: add documentation for extcon and utmi-avalid properties Enric Balletbo i Serra
2018-08-15 10:29   ` Heiko Stuebner
2018-08-15 11:08     ` Enric Balletbo i Serra
2018-08-15 11:22       ` Heiko Stuebner
2018-08-15 22:21   ` Rob Herring
2018-08-16  8:38     ` Enric Balletbo i Serra
2018-08-15  9:59 ` [PATCH 3/4] phy: rockchip-inno-usb2: allow to force the B-Device Session Valid bit Enric Balletbo i Serra
2018-08-15 10:18   ` Heiko Stuebner
2018-08-15 10:34     ` Enric Balletbo i Serra
2018-08-15 10:36       ` Heiko Stuebner
2018-08-15  9:59 ` [PATCH 4/4] dt-bindings: phy-rockchip-inno-usb2: add new rockchip,force-bvalid property Enric Balletbo i Serra
2018-08-15 10:34   ` Heiko Stuebner
2018-08-15 22:26   ` Rob Herring
2019-01-10  9:06     ` Enric Balletbo Serra
2019-01-10 12:31       ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFqH_50tz1Toi6L1Ju5imyMRPzN1bDg7mxzcLrJWvdxOwknfdw@mail.gmail.com \
    --to=eballetbo@gmail.com \
    --cc=amstan@chromium.org \
    --cc=bleung@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@google.com \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).