From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753138AbeFAQkW (ORCPT ); Fri, 1 Jun 2018 12:40:22 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:43014 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752108AbeFAQkT (ORCPT ); Fri, 1 Jun 2018 12:40:19 -0400 X-Google-Smtp-Source: ADUXVKLYIQdGFqWJU/EML4GASFwNvTNFDKgNaqzoLDRSskjN2BskhlxtzMjTucBdHPiODsg9jckvRsqMRhK4Krgkhw0= MIME-Version: 1.0 In-Reply-To: <20180530031704.18597-2-fparent@baylibre.com> References: <20180530031704.18597-1-fparent@baylibre.com> <20180530031704.18597-2-fparent@baylibre.com> From: Enric Balletbo Serra Date: Fri, 1 Jun 2018 18:40:18 +0200 Message-ID: Subject: Re: [PATCH 1/3] mfd: cros: add charger port count command definition To: Fabien Parent Cc: Sebastian Reichel , Linux PM list , linux-kernel , gpain@baylibre.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-05-30 5:17 GMT+02:00 Fabien Parent : > A new more command has been added to the ChromeOS embedded controller > that allows to get the number of charger port count. Unlike > EC_CMD_USB_PD_PORTS, this new command also includes the dedicated > port if present. > > This command will be used to expose the dedicated charger port > in the ChromeOS charger driver. > > Signed-off-by: Fabien Parent > --- > include/linux/mfd/cros_ec_commands.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h > index 0d926492ac3a..e3187f8bdb7e 100644 > --- a/include/linux/mfd/cros_ec_commands.h > +++ b/include/linux/mfd/cros_ec_commands.h > @@ -3005,6 +3005,16 @@ struct ec_params_usb_pd_info_request { > uint8_t port; > } __packed; > > +/* > + * This command will return the number of USB PD charge port + the number > + * of dedicated port present. > + * EC_CMD_USB_PD_PORTS does NOT include the dedicated ports > + */ > +#define EC_CMD_CHARGE_PORT_COUNT 0x0105 > +struct ec_response_charge_port_count { > + uint8_t port_count; > +} __packed; > + > /* Read USB-PD Device discovery info */ > #define EC_CMD_USB_PD_DISCOVERY 0x0113 > struct ec_params_usb_pd_discovery_entry { > -- > 2.17.0 > The patch looks good to me, ideally, will be good if you can add the kernel-doc documentation for the struct, in any case Reviewed-by: Enric Balletbo i Serra Thanks, Enric