From: Enric Balletbo Serra <eballetbo@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
robert.jarzmik@free.fr,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Lee Jones" <lee.jones@linaro.org>,
kernel@collabora.com, "Heiko Stübner" <heiko@sntech.de>,
stable@vger.kernel.org, u.kleine-koenig@pengutronix.de,
"Linux PWM List" <linux-pwm@vger.kernel.org>,
linux-fbdev@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Jingoo Han" <jingoohan1@gmail.com>
Subject: Re: [PATCH v3] backlight: pwm_bl: Fix brightness levels for non-DT case.
Date: Fri, 30 Nov 2018 23:22:05 +0100 [thread overview]
Message-ID: <CAFqH_53NiYULqcc+2fCgbHETJoTc7tWD8BNxOFhPm6kFZ=e6_g@mail.gmail.com> (raw)
In-Reply-To: <20181107085507.26126-1-enric.balletbo@collabora.com>
Hi,
Missatge de Enric Balletbo i Serra <enric.balletbo@collabora.com> del
dia dc., 7 de nov. 2018 a les 9:56:
>
> Commit '88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED
> linearly to human eye")' allows the possibility to compute a default
> brightness table when there isn't the brightness-levels property in the
> DT. Unfortunately the changes made broke the pwm backlight for the
> non-DT boards.
>
> Usually, the non-DT boards don't pass the brightness levels via platform
> data, instead, it sets the max_brightness in their platform data and the
> driver calculates the level without a table. The offending patch assumed
> that when there is no brightness levels table we should create one, but this
> is clearly wrong for the non-DT case.
>
> After this patch the code handles the DT and the non-DT case taking in
> consideration also if max_brightness is set or not.
>
> Fixes: 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye")
> Cc: <stable@vger.kernel.org>
> Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
>
> Changes in v3:
> - Fixed some typos in commit message.
> - Removed ' in Fixes tag.
>
> Changes in v2:
> - Rebase on top of mainline
> - Add Tested-by and Acked-by tags.
>
> drivers/video/backlight/pwm_bl.c | 41 +++++++++++++++++++++++++++-----
> 1 file changed, 35 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> index 678b27063198..f9ef0673a083 100644
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -562,7 +562,30 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> goto err_alloc;
> }
>
> - if (!data->levels) {
> + if (data->levels) {
> + /*
> + * For the DT case, only when brightness levels is defined
> + * data->levels is filled. For the non-DT case, data->levels
> + * can come from platform data, however is not usual.
> + */
> + for (i = 0; i <= data->max_brightness; i++) {
> + if (data->levels[i] > pb->scale)
> + pb->scale = data->levels[i];
> +
> + pb->levels = data->levels;
> + }
> + } else if (!data->max_brightness) {
> + /*
> + * If no brightness levels are provided and max_brightness is
> + * not set, use the default brightness table. For the DT case,
> + * max_brightness is set to 0 when brightness levels is not
> + * specified. For the non-DT case, max_brightness is usually
> + * set to some value.
> + */
> +
> + /* Get the PWM period (in nanoseconds) */
> + pwm_get_state(pb->pwm, &state);
> +
> ret = pwm_backlight_brightness_default(&pdev->dev, data,
> state.period);
> if (ret < 0) {
> @@ -570,13 +593,19 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> "failed to setup default brightness table\n");
> goto err_alloc;
> }
> - }
>
> - for (i = 0; i <= data->max_brightness; i++) {
> - if (data->levels[i] > pb->scale)
> - pb->scale = data->levels[i];
> + for (i = 0; i <= data->max_brightness; i++) {
> + if (data->levels[i] > pb->scale)
> + pb->scale = data->levels[i];
>
> - pb->levels = data->levels;
> + pb->levels = data->levels;
> + }
> + } else {
> + /*
> + * That only happens for the non-DT case, where platform data
> + * sets the max_brightness value.
> + */
> + pb->scale = data->max_brightness;
> }
>
> pb->lth_brightness = data->lth_brightness * (state.period / pb->scale);
> --
> 2.19.1
>
A gentle ping on this patch.
Best regards,
Enric
next prev parent reply other threads:[~2018-11-30 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 8:55 [PATCH v3] backlight: pwm_bl: Fix brightness levels for non-DT case Enric Balletbo i Serra
2018-11-30 22:22 ` Enric Balletbo Serra [this message]
2018-12-03 7:07 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqH_53NiYULqcc+2fCgbHETJoTc7tWD8BNxOFhPm6kFZ=e6_g@mail.gmail.com' \
--to=eballetbo@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).