From: Souptick Joarder <jrdr.linux@gmail.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andrey Konovalov <andreyknvl@google.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com, Linux-MM <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Kostya Serebryany <kcc@google.com>,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] kasan: fix coccinelle warnings in kasan_p*_table
Date: Fri, 8 Mar 2019 08:33:31 +0530 [thread overview]
Message-ID: <CAFqt6zY387LVbo3sxBvDDvKMb+41KcLcmN-W+ncPJbrUm5STaw@mail.gmail.com> (raw)
In-Reply-To: <67536e1d-2819-553d-521c-bae21a51e0f7@virtuozzo.com>
On Tue, Mar 5, 2019 at 9:43 PM Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
>
>
>
> On 3/4/19 8:04 PM, Andrey Konovalov wrote:
> > kasan_p4d_table, kasan_pmd_table and kasan_pud_table are declared as
> > returning bool, but return 0 instead of false, which produces a coccinelle
> > warning. Fix it.
> >
> > Fixes: 0207df4fa1a8 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN")
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> > ---
>
> Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
>
>
> > mm/kasan/init.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> > index 45a1b5e38e1e..fcaa1ca03175 100644
> > --- a/mm/kasan/init.c
> > +++ b/mm/kasan/init.c
> > @@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd)
> > #else
> > static inline bool kasan_p4d_table(pgd_t pgd)
> > {
> > - return 0;
> > + return false;
> > }
> > #endif
> > #if CONFIG_PGTABLE_LEVELS > 3
> > @@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d)
> > #else
> > static inline bool kasan_pud_table(p4d_t p4d)
> > {
> > - return 0;
> > + return false;
> > }
> > #endif
> > #if CONFIG_PGTABLE_LEVELS > 2
> > @@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud)
> > #else
> > static inline bool kasan_pmd_table(pud_t pud)
> > {
> > - return 0;
> > + return false;
> > }
> > #endif
> > pte_t kasan_early_shadow_pte[PTRS_PER_PTE] __page_aligned_bss;
> >
>
Acked-by: Souptick Joarder <jrdr.linux@gmail.com>
prev parent reply other threads:[~2019-03-08 3:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 17:04 [PATCH] kasan: fix coccinelle warnings in kasan_p*_table Andrey Konovalov
2019-03-05 16:14 ` Andrey Ryabinin
2019-03-08 3:03 ` Souptick Joarder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqt6zY387LVbo3sxBvDDvKMb+41KcLcmN-W+ncPJbrUm5STaw@mail.gmail.com \
--to=jrdr.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).