* [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT @ 2019-02-11 15:26 Souptick Joarder 2019-02-11 15:40 ` Greg KH 0 siblings, 1 reply; 9+ messages in thread From: Souptick Joarder @ 2019-02-11 15:26 UTC (permalink / raw) To: arve, gregkh, tkjos, maco, christian; +Cc: devel, linux-kernel As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT ioctl. This functionality has been superseded by the futex and is there for legacy reasons. Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> --- drivers/staging/android/uapi/vsoc_shm.h | 7 ------- drivers/staging/android/vsoc.c | 5 ----- 2 files changed, 12 deletions(-) diff --git a/drivers/staging/android/uapi/vsoc_shm.h b/drivers/staging/android/uapi/vsoc_shm.h index 6291fb2..69090cc 100644 --- a/drivers/staging/android/uapi/vsoc_shm.h +++ b/drivers/staging/android/uapi/vsoc_shm.h @@ -232,13 +232,6 @@ struct vsoc_shm_layout_descriptor { #define VSOC_MAYBE_SEND_INTERRUPT_TO_HOST _IO(0xF5, 2) /* - * When this returns the guest will scan host_to_guest_signal_table to - * check for new futexes to wake. - */ -/* TODO(ghartman): Consider moving this to the bottom half */ -#define VSOC_WAIT_FOR_INCOMING_INTERRUPT _IO(0xF5, 3) - -/* * Guest HALs will use this to retrieve the region description after * opening their device node. */ diff --git a/drivers/staging/android/vsoc.c b/drivers/staging/android/vsoc.c index 22571ab..a842ff7 100644 --- a/drivers/staging/android/vsoc.c +++ b/drivers/staging/android/vsoc.c @@ -592,11 +592,6 @@ static long vsoc_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) case VSOC_SEND_INTERRUPT_TO_HOST: writel(reg_num, vsoc_dev.regs + DOORBELL); return 0; - case VSOC_WAIT_FOR_INCOMING_INTERRUPT: - wait_event_interruptible - (reg_data->interrupt_wait_queue, - (atomic_read(reg_data->incoming_signalled) != 0)); - break; case VSOC_DESCRIBE_REGION: return do_vsoc_describe_region -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT 2019-02-11 15:26 [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT Souptick Joarder @ 2019-02-11 15:40 ` Greg KH 2019-02-11 15:51 ` Souptick Joarder 0 siblings, 1 reply; 9+ messages in thread From: Greg KH @ 2019-02-11 15:40 UTC (permalink / raw) To: Souptick Joarder; +Cc: arve, tkjos, maco, christian, devel, linux-kernel On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > ioctl. This functionality has been superseded by the futex and is > there for legacy reasons. > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > drivers/staging/android/vsoc.c | 5 ----- > 2 files changed, 12 deletions(-) So userspace is all fixed up now and this ioctl can be dropped? Any pointers to the userspace commit that did this? thanks, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT 2019-02-11 15:40 ` Greg KH @ 2019-02-11 15:51 ` Souptick Joarder 2019-02-11 15:57 ` Greg KH 0 siblings, 1 reply; 9+ messages in thread From: Souptick Joarder @ 2019-02-11 15:51 UTC (permalink / raw) To: Greg KH; +Cc: arve, tkjos, maco, christian, devel, linux-kernel On Mon, Feb 11, 2019 at 9:10 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > ioctl. This functionality has been superseded by the futex and is > > there for legacy reasons. > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > --- > > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > > drivers/staging/android/vsoc.c | 5 ----- > > 2 files changed, 12 deletions(-) > > So userspace is all fixed up now and this ioctl can be dropped? Any > pointers to the userspace commit that did this? I am not sure about user space part. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT 2019-02-11 15:51 ` Souptick Joarder @ 2019-02-11 15:57 ` Greg KH 2019-02-11 16:45 ` Souptick Joarder 0 siblings, 1 reply; 9+ messages in thread From: Greg KH @ 2019-02-11 15:57 UTC (permalink / raw) To: Souptick Joarder; +Cc: devel, tkjos, linux-kernel, arve, maco, christian On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > On Mon, Feb 11, 2019 at 9:10 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > ioctl. This functionality has been superseded by the futex and is > > > there for legacy reasons. > > > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > > --- > > > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > > > drivers/staging/android/vsoc.c | 5 ----- > > > 2 files changed, 12 deletions(-) > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > pointers to the userspace commit that did this? > > I am not sure about user space part. Then we can not just delete the ioctl :) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT 2019-02-11 15:57 ` Greg KH @ 2019-02-11 16:45 ` Souptick Joarder 2019-02-11 17:11 ` Greg KH 0 siblings, 1 reply; 9+ messages in thread From: Souptick Joarder @ 2019-02-11 16:45 UTC (permalink / raw) To: Greg KH; +Cc: devel, tkjos, linux-kernel, arve, maco, christian On Mon, Feb 11, 2019 at 9:27 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > ioctl. This functionality has been superseded by the futex and is > > > > there for legacy reasons. > > > > > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > > > --- > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > > > > drivers/staging/android/vsoc.c | 5 ----- > > > > 2 files changed, 12 deletions(-) > > > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > > pointers to the userspace commit that did this? > > > > I am not sure about user space part. > > Then we can not just delete the ioctl :) Agree, but where to verify the user space commit ? Any pointer to the source code path ? ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT 2019-02-11 16:45 ` Souptick Joarder @ 2019-02-11 17:11 ` Greg KH 2019-02-11 17:22 ` Todd Kjos 0 siblings, 1 reply; 9+ messages in thread From: Greg KH @ 2019-02-11 17:11 UTC (permalink / raw) To: Souptick Joarder; +Cc: devel, tkjos, linux-kernel, arve, maco, christian On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote: > On Mon, Feb 11, 2019 at 9:27 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > > ioctl. This functionality has been superseded by the futex and is > > > > > there for legacy reasons. > > > > > > > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > > > > --- > > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > > > > > drivers/staging/android/vsoc.c | 5 ----- > > > > > 2 files changed, 12 deletions(-) > > > > > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > > > pointers to the userspace commit that did this? > > > > > > I am not sure about user space part. > > > > Then we can not just delete the ioctl :) > > Agree, but where to verify the user space commit ? > Any pointer to the source code path ? Please work with the android developers to solve this. It should be in AOSP "somewhere" :( good luck, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT 2019-02-11 17:11 ` Greg KH @ 2019-02-11 17:22 ` Todd Kjos 2019-02-11 18:57 ` Alistair Strachan 0 siblings, 1 reply; 9+ messages in thread From: Todd Kjos @ 2019-02-11 17:22 UTC (permalink / raw) To: Greg KH, Alistair Strachan Cc: Souptick Joarder, open list:ANDROID DRIVERS, Todd Kjos, LKML, Arve Hjønnevåg, Martijn Coenen, Christian Brauner +Alistair Strachan On Mon, Feb 11, 2019 at 9:11 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote: > > On Mon, Feb 11, 2019 at 9:27 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > > > ioctl. This functionality has been superseded by the futex and is > > > > > > there for legacy reasons. > > > > > > > > > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > > > > > --- > > > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > > > > > > drivers/staging/android/vsoc.c | 5 ----- > > > > > > 2 files changed, 12 deletions(-) > > > > > > > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > > > > pointers to the userspace commit that did this? > > > > > > > > I am not sure about user space part. > > > > > > Then we can not just delete the ioctl :) > > > > Agree, but where to verify the user space commit ? > > Any pointer to the source code path ? > > Please work with the android developers to solve this. It should be in > AOSP "somewhere" :( > > good luck, > > greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT 2019-02-11 17:22 ` Todd Kjos @ 2019-02-11 18:57 ` Alistair Strachan 2019-02-12 13:12 ` Souptick Joarder 0 siblings, 1 reply; 9+ messages in thread From: Alistair Strachan @ 2019-02-11 18:57 UTC (permalink / raw) To: Todd Kjos Cc: Greg KH, Souptick Joarder, open list:ANDROID DRIVERS, Todd Kjos, LKML, Arve Hjønnevåg, Martijn Coenen, Christian Brauner On Mon, Feb 11, 2019 at 9:22 AM Todd Kjos <tkjos@google.com> wrote: > > +Alistair Strachan > > On Mon, Feb 11, 2019 at 9:11 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote: > > > On Mon, Feb 11, 2019 at 9:27 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > > > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > > > > ioctl. This functionality has been superseded by the futex and is > > > > > > > there for legacy reasons. > > > > > > > > > > > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > > > > > > --- > > > > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > > > > > > > drivers/staging/android/vsoc.c | 5 ----- > > > > > > > 2 files changed, 12 deletions(-) > > > > > > > > > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > > > > > pointers to the userspace commit that did this? The ioctl is still being used and cannot be removed. > > > > > > > > > > I am not sure about user space part. > > > > > > > > Then we can not just delete the ioctl :) > > > > > > Agree, but where to verify the user space commit ? > > > Any pointer to the source code path ? The userspace code using the Linux 'vsoc' staging driver can be cloned from here: https://android.googlesource.com/device/google/cuttlefish_common > > > > Please work with the android developers to solve this. It should be in > > AOSP "somewhere" :( I'm working on documenting this better on source.android.com. Stay tuned. > > > > good luck, > > > > greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT 2019-02-11 18:57 ` Alistair Strachan @ 2019-02-12 13:12 ` Souptick Joarder 0 siblings, 0 replies; 9+ messages in thread From: Souptick Joarder @ 2019-02-12 13:12 UTC (permalink / raw) To: Alistair Strachan Cc: Todd Kjos, Greg KH, open list:ANDROID DRIVERS, Todd Kjos, LKML, Arve Hjønnevåg, Martijn Coenen, Christian Brauner On Tue, Feb 12, 2019 at 12:28 AM Alistair Strachan <astrachan@google.com> wrote: > > On Mon, Feb 11, 2019 at 9:22 AM Todd Kjos <tkjos@google.com> wrote: > > > > +Alistair Strachan > > > > On Mon, Feb 11, 2019 at 9:11 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > On Mon, Feb 11, 2019 at 10:15:18PM +0530, Souptick Joarder wrote: > > > > On Mon, Feb 11, 2019 at 9:27 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > On Mon, Feb 11, 2019 at 09:21:19PM +0530, Souptick Joarder wrote: > > > > > > On Mon, Feb 11, 2019 at 9:10 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > > > > > On Mon, Feb 11, 2019 at 08:56:02PM +0530, Souptick Joarder wrote: > > > > > > > > As mentioned in TODO list, Removed VSOC_WAIT_FOR_INCOMING_INTERRUPT > > > > > > > > ioctl. This functionality has been superseded by the futex and is > > > > > > > > there for legacy reasons. > > > > > > > > > > > > > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > > > > > > > --- > > > > > > > > drivers/staging/android/uapi/vsoc_shm.h | 7 ------- > > > > > > > > drivers/staging/android/vsoc.c | 5 ----- > > > > > > > > 2 files changed, 12 deletions(-) > > > > > > > > > > > > > > So userspace is all fixed up now and this ioctl can be dropped? Any > > > > > > > pointers to the userspace commit that did this? > > The ioctl is still being used and cannot be removed. I think, it's good to add this info in TODO file. I can edit it if you are ok. > > > > > > > > > > > > > I am not sure about user space part. > > > > > > > > > > Then we can not just delete the ioctl :) > > > > > > > > Agree, but where to verify the user space commit ? > > > > Any pointer to the source code path ? > > The userspace code using the Linux 'vsoc' staging driver can be cloned > from here: > > https://android.googlesource.com/device/google/cuttlefish_common Thanks. > > > > > > > Please work with the android developers to solve this. It should be in > > > AOSP "somewhere" :( > > I'm working on documenting this better on source.android.com. Stay tuned. > > > > > > > good luck, > > > > > > greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-02-12 13:13 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-02-11 15:26 [PATCH] staging: android: vsoc: Remove VSOC_WAIT_FOR_INCOMING_INTERRUPT Souptick Joarder 2019-02-11 15:40 ` Greg KH 2019-02-11 15:51 ` Souptick Joarder 2019-02-11 15:57 ` Greg KH 2019-02-11 16:45 ` Souptick Joarder 2019-02-11 17:11 ` Greg KH 2019-02-11 17:22 ` Todd Kjos 2019-02-11 18:57 ` Alistair Strachan 2019-02-12 13:12 ` Souptick Joarder
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).