From: Souptick Joarder <jrdr.linux@gmail.com>
To: aryabinin@virtuozzo.com
Cc: Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg KH <gregkh@linuxfoundation.org>,
tchibo@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/kcov: Replace vm_insert_page with vmf_insert_page
Date: Fri, 21 Sep 2018 18:55:47 +0530 [thread overview]
Message-ID: <CAFqt6za6VJ7vmWEqg4JGWqRiqbfc6GYDnpUeBQ+03xdY51-GQA@mail.gmail.com> (raw)
In-Reply-To: <68b8cbf3-1b5a-2311-ac09-a8676280e85e@virtuozzo.com>
On Fri, Sep 21, 2018 at 5:22 PM Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
>
>
>
> On 09/21/2018 01:03 PM, Souptick Joarder wrote:
> > On Fri, Sep 21, 2018 at 3:06 PM Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
> >>
> >> On 09/20/2018 10:12 PM, Souptick Joarder wrote:
> >>> There is a plan to replace vm_insert_page with new API
> >>> vmf_insert_page. As part of it, converting vm_insert_page
> >>> to use vmf_insert_page.
> >>>
> >>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> >>> ---
> >>> kernel/kcov.c | 5 +++--
> >>> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/kernel/kcov.c b/kernel/kcov.c
> >>> index 3ebd09e..8900d8e 100644
> >>> --- a/kernel/kcov.c
> >>> +++ b/kernel/kcov.c
> >>> @@ -293,8 +293,9 @@ static int kcov_mmap(struct file *filep, struct vm_area_struct *vma)
> >>> spin_unlock(&kcov->lock);
> >>> for (off = 0; off < size; off += PAGE_SIZE) {
> >>> page = vmalloc_to_page(kcov->area + off);
> >>> - if (vm_insert_page(vma, vma->vm_start + off, page))
> >>> - WARN_ONCE(1, "vm_insert_page() failed");
> >>> + if (vmf_insert_page(vma, vma->vm_start + off, page)
> >>> + != VM_FAULT_NOPAGE)
> >>> + WARN_ONCE(1, "vmf_insert_page() failed");
> >>
> >> Nack, don't see the reason for such change, it only makes code worse.
> >
> > Yes, it needed.
>
> No, it's not needed. vm_insert_page() works perfectly fine here.
>
> > Going forward vm_insert_page will be converted to
> > vmf_insert_page. As part of it, this code has to be converted to use
> > vmf_insert_page().
>
> This doesn't explain why such conversion would make sense for kcov_mmap().
vm_insert_page used to return errno which individual drivers have to
map to VM_FAULT_CODE.
There were also places where return value of vm_insert_page was
ignored and return a
TRUE value.
As part of vm_fault_t migration patches, we have identified and clean
up all these.
The plan was to introduce inline wrapper vmf_insert_page(), convert all
the page fault handlers to use it and then convert vm_insert_page to
vmf_insert_page. By now we have converted all the page fault handlers
to use this API.
Still their are few places where vm_insert_page is called outside fault handlers
context to map kernel page to user vma and kernel/kcov.c is one of them.
Now removing vm_insert_page from those few places one by one.
Going forward vm_insert_page will be removed from kernel permanently,
so that new drivers can't use this API and create new errno to VM_FAULT_CODE
mapping code.
>
> > please refer below commit on linus tree -
> > 1c8f422059ae5da07db74
>
> That the commit has nothing to deal with kcov, it doesn't explain why kcov_mmap()
> can't keep using vm_insert_page() and/or why we should prefer vmf_insert_page()
> over vm_insert_page() particularly in the case of kcov_mmap().
>
next prev parent reply other threads:[~2018-09-21 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 19:12 [PATCH] kernel/kcov: Replace vm_insert_page with vmf_insert_page Souptick Joarder
2018-09-21 9:37 ` Andrey Ryabinin
2018-09-21 10:03 ` Souptick Joarder
2018-09-21 11:53 ` Andrey Ryabinin
2018-09-21 13:25 ` Souptick Joarder [this message]
2018-09-21 14:45 ` Andrey Ryabinin
2018-09-21 16:20 ` Souptick Joarder
2018-09-22 14:22 ` Matthew Wilcox
2018-09-24 7:53 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqt6za6VJ7vmWEqg4JGWqRiqbfc6GYDnpUeBQ+03xdY51-GQA@mail.gmail.com \
--to=jrdr.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=tchibo@google.com \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).