linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Souptick Joarder <jrdr.linux@gmail.com>
To: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Cc: airlied@linux.ie, Gerd Hoffmann <kraxel@redhat.com>,
	dri-devel@lists.freedesktop.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org,
	Brajeswar Ghosh <brajeswar.linux@gmail.com>
Subject: Re: [PATCH] gpu/drm/virtio/virtgpu_vq.c: Use kmem_cache_zalloc
Date: Tue, 23 Oct 2018 09:36:55 +0530	[thread overview]
Message-ID: <CAFqt6zbdxjUF4tEh8WXRZT-eo58sfw0tKa3DyxTXCesjEJkqfA@mail.gmail.com> (raw)
In-Reply-To: <5bc9ff7e.1c69fb81.105c2.1fef@mx.google.com>

On Fri, Oct 19, 2018 at 9:30 PM Sabyasachi Gupta
<sabyasachi.linux@gmail.com> wrote:
>
> Replaced kmem_cache_alloc + memset with kmem_cache_zalloc

Put a new line gap in between these two lines and send v2.

> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index 020070d..e001b79 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -98,10 +98,9 @@ virtio_gpu_get_vbuf(struct virtio_gpu_device *vgdev,
>  {
>         struct virtio_gpu_vbuffer *vbuf;
>
> -       vbuf = kmem_cache_alloc(vgdev->vbufs, GFP_KERNEL);
> +       vbuf = kmem_cache_zalloc(vgdev->vbufs, GFP_KERNEL);
>         if (!vbuf)
>                 return ERR_PTR(-ENOMEM);
> -       memset(vbuf, 0, VBUFFER_SIZE);
>
>         BUG_ON(size > MAX_INLINE_CMD_SIZE);
>         vbuf->buf = (void *)vbuf + sizeof(*vbuf);
> --
> 2.7.4
>

  reply	other threads:[~2018-10-23  4:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 15:59 [PATCH] gpu/drm/virtio/virtgpu_vq.c: Use kmem_cache_zalloc Sabyasachi Gupta
2018-10-23  4:06 ` Souptick Joarder [this message]
2018-10-23  9:50   ` Jani Nikula
2018-10-30  5:36     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFqt6zbdxjUF4tEh8WXRZT-eo58sfw0tKa3DyxTXCesjEJkqfA@mail.gmail.com \
    --to=jrdr.linux@gmail.com \
    --cc=airlied@linux.ie \
    --cc=brajeswar.linux@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sabyasachi.linux@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).