From: Jean Pihet <jean.pihet@linaro.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Robert Richter <rric@kernel.org>
Subject: Re: [PATCH] tools:perf: move tools/perf/util to tools/lib/perf_util
Date: Thu, 12 Jun 2014 15:19:50 +0200 [thread overview]
Message-ID: <CAFrcx1kfUkFF9ROy2C0gcFe88aOHfv2qJBfO+uv+Z7ZW5HxQCw@mail.gmail.com> (raw)
In-Reply-To: <20140612124918.GC4857@pd.tnic>
On 12 June 2014 14:49, Borislav Petkov <bp@alien8.de> wrote:
> On Thu, Jun 12, 2014 at 09:34:32AM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Thu, Jun 12, 2014 at 10:26:42AM +0200, Jean Pihet escreveu:
>> > This is a first move of the perf code into a set of libraries, which
>> > allow the implementation of other external tools.
>> >
>> > The first users of the perf libraries would be:
>> > - perf itself,
>> > - the RAS daemon.
>> >
>> > The commit includes:
>> > - the move of the code from util to lib/perf_util,
>> > - creation of Makefile in perf_util,
>> > - update of Makefile.perf to build a library for perf_util,
>> > - fix of the include paths, eg. "../perf.h" to <perf.h>, "util/hist.h" to
>> > <hist.h>
>>
>> Can't you just go moving what you actually use? Or do you really plan to
>> use all that?
>
> You asked me that same question when I was doing that. :-)
The idea is to move the re-usable code in libraries, so that other
tools than perf can use it as well.
>
> And I told Jean repeatedly that this needs to be splitted slowly, in
> smaller libraries like we've been discussing it numerous times.
Hrrr. I see it as a first move, later the rest of the code can be
moved the same way.
Now it seems that moving all from util/ at once is too much. How do
you see it happening?
Note: moving some code in the perf source is hairy enough (cf. the
simplicity of the Makefiles ;-) and so I do not want to re-do it all
over again too many times.
Thx for looking!
Jean
>
> :-\
>
> --
> Regards/Gruss,
> Boris.
>
> Sent from a fat crate under my desk. Formatting is fine.
> --
next prev parent reply other threads:[~2014-06-12 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 8:26 [PATCH] tools:perf: move tools/perf/util to tools/lib/perf_util Jean Pihet
2014-06-12 12:34 ` Arnaldo Carvalho de Melo
2014-06-12 12:49 ` Borislav Petkov
2014-06-12 13:19 ` Jean Pihet [this message]
2014-06-12 14:01 ` Borislav Petkov
2014-06-13 14:03 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFrcx1kfUkFF9ROy2C0gcFe88aOHfv2qJBfO+uv+Z7ZW5HxQCw@mail.gmail.com \
--to=jean.pihet@linaro.org \
--cc=acme@kernel.org \
--cc=bp@alien8.de \
--cc=jolsa@redhat.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).