From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E5AC43457 for ; Tue, 13 Oct 2020 03:47:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74FFD20872 for ; Tue, 13 Oct 2020 03:47:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TUy1/e/8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730886AbgJMDrJ (ORCPT ); Mon, 12 Oct 2020 23:47:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727831AbgJMDrI (ORCPT ); Mon, 12 Oct 2020 23:47:08 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B231C0613D1 for ; Mon, 12 Oct 2020 20:47:08 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id t9so22158539wrq.11 for ; Mon, 12 Oct 2020 20:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ndqNqzRXOPPB0ogWDEyLlyUsAwARJUaefBSahD5nDa4=; b=TUy1/e/8zdrtz/TDD9ZlkK4/DfeGPgRUa3QeDaYfeh4G1LHFulpMmCsbTwbGSEyBQK lAu8jh7FoG6cHbwFJSQeIx9iXkCE/ueGwcI2MrlJUnM/ojvgJ0zqYcQCHh3lZGIzQahy ZyzDEyzFbz4onJYf00FLDHv5UWWR6DCw8+OeA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ndqNqzRXOPPB0ogWDEyLlyUsAwARJUaefBSahD5nDa4=; b=gAMcirBnp5WIW6622P4a91bi6i2H/s2eCqSV8TjVtV38B87HHy4RpVwWx7vWsk6dff /ici07QQmbApWhJwO208MYa9/XzmU8f4bVaL/mxCt4Giu9W7DMobCbHcUhTHcgD9vBRi JigIx2VW79qLI9lzJ2k6NPZWn6VikojMZrIPISq6/ntkjG8qFNixmmuX2w96p+huI5lP 1IbNMQ6iZOf6UGw2fE7nmbOqAnCvuBwCVDW9un19hB1tn3eEckpeq8Wb2Z2Gu3klXvqW VE8mWb9fYFpm9ufTOM4MdSa4KoSlHwznI5yyFJIgL4W2VPBeWg8whhjfjFgVAYl5FXVp 3nSg== X-Gm-Message-State: AOAM531txi6IC8bUmd8POhZ8YYDBbxCkNtg8kXaaOPsjj94hH4nALzdn cF2foI6Q3GSpQXkZ10vRPzDv+5cODwhzBxVaXA4lpQ== X-Google-Smtp-Source: ABdhPJxLXiwL7qf220DKfHJQfoYxQlufVps95HZ1MB4kZujN6DOUdk3utBGFAuRuLvV4U9gUnbWpUWxLmoiRUK7RRoY= X-Received: by 2002:a5d:6a43:: with SMTP id t3mr34196747wrw.426.1602560826699; Mon, 12 Oct 2020 20:47:06 -0700 (PDT) MIME-Version: 1.0 References: <20200914080619.4178587-1-cychiang@chromium.org> <20200914080619.4178587-3-cychiang@chromium.org> <20200914174812.GA4125843@bogus> In-Reply-To: From: Cheng-yi Chiang Date: Tue, 13 Oct 2020 11:46:40 +0800 Message-ID: Subject: Re: [PATCH v11 2/3] ASoC: qcom: dt-bindings: Add sc7180 machine bindings To: Rob Herring Cc: linux-kernel , Dylan Reid , Bjorn Andersson , Takashi Iwai , "open list:ARM/Rockchip SoC..." , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Patrick Lai , Tzung-Bi Shih , Linux ARM , Mark Brown , Srinivasa Rao , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Heiko Stuebner , linux-arm-msm , Matthias Brugger , Stephan Gerhold , Doug Anderson , Banajit Goswami , Liam Girdwood , Rohit kumar , Andy Gross , "moderated list:ARM/Mediatek SoC support" , Taniya Das , Srini Kandagatla Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 8:44 PM Cheng-yi Chiang wrote: > > On Tue, Sep 15, 2020 at 1:48 AM Rob Herring wrote: > > > > On Mon, 14 Sep 2020 16:06:18 +0800, Cheng-Yi Chiang wrote: > > > Add devicetree bindings documentation file for sc7180 sound card. > > > > > > Signed-off-by: Cheng-Yi Chiang > > > --- > > > .../bindings/sound/qcom,sc7180.yaml | 130 ++++++++++++++++++ > > > 1 file changed, 130 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml > > > > > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > > there's no need to repost patches *only* to add the tags. The upstream > > maintainer will do that for acks received on the version they apply. > > > > If a tag was not added on purpose, please state why and what changed. > > > > Hi Rob, > There was a change between v9 and v10 on compatible string so I did > not add your Reviewed-by. > Now it is "qcom,sc7180-sndcard-rt5682-m98357-1mic" following Stephan's > comment in > > https://patchwork.kernel.org/comment/23608881/ > > to make compatible string more specific to board configuration. > I only add the note to the cover letter. Sorry the cover letter became > too long to follow. > I will add the note in patch mail itself for future changes. > Thanks for taking a look again. Hi Rob, Could you please kindly review this patch ? v11 contains the compatible string "qcom,sc7180-sndcard-rt5682-m98357-1mic" following Stephan's suggestion in "[v9,3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration" ( https://patchwork.kernel.org/patch/11770201/#23608881 ) to specify the combination of components. Please let me know if this looks good to you. Thanks!