linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Justin Forbes <jmforbes@linuxtx.org>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Mircea Pop <mircea.pop@nxp.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc: fix distclean with Makefile.postlink
Date: Mon, 8 May 2017 16:35:45 -0500	[thread overview]
Message-ID: <CAFxkdAqCdY6g2Gb7rC_A+tgqSZj1ey9rPV9UrXMBq92BR_eSYg@mail.gmail.com> (raw)
In-Reply-To: <VI1PR0401MB259158901716F82DEFE1C42198EE0@VI1PR0401MB2591.eurprd04.prod.outlook.com>

On Mon, May 8, 2017 at 8:50 AM, Horia Geantă <horia.geanta@nxp.com> wrote:
> On 5/8/2017 2:57 PM, Michael Ellerman wrote:
>> Horia Geantă <horia.geanta@nxp.com> writes:
>>
>>> Makefile.postlink always includes include/config/auto.conf, however
>>> this file is not present in a clean kernel tree, causing make to fail:
>>>
>>> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
>>> make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
>>> make: *** [vmlinuxclean] Error 2
>>>
>>> Change the inclusion such that file not being found does not trigger
>>> an error.
>>>
>>> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
>>
>> I can't reproduce this. What exact steps are you doing? And what version
>> of Make?
>>
> Start with a clean kernel tree and then
> make distclean
> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such
> file or directory
> make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
> make: *** [vmlinuxclean] Error 2
>
> make --version
> GNU Make 3.82
> Built for x86_64-redhat-linux-gnu
> Copyright (C) 2010  Free Software Foundation, Inc.
> [...]
>
> The fix is basically the same as:
> 6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink
>

Noticed it on the Fedora builds as well today.  This patch fixes it.

Tested-by: Justin M. Forbes <jforbes@fedoraproject.org>

  reply	other threads:[~2017-05-08 21:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08  8:50 [PATCH] powerpc: fix distclean with Makefile.postlink Horia Geantă
2017-05-08 11:57 ` Michael Ellerman
2017-05-08 13:50   ` Horia Geantă
2017-05-08 21:35     ` Justin Forbes [this message]
2017-05-15  5:06 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFxkdAqCdY6g2Gb7rC_A+tgqSZj1ey9rPV9UrXMBq92BR_eSYg@mail.gmail.com \
    --to=jmforbes@linuxtx.org \
    --cc=benh@kernel.crashing.org \
    --cc=horia.geanta@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mircea.pop@nxp.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).