From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E1CC6377E for ; Mon, 19 Jul 2021 16:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1134561437 for ; Mon, 19 Jul 2021 16:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349591AbhGSQC1 (ORCPT ); Mon, 19 Jul 2021 12:02:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345864AbhGSPFE (ORCPT ); Mon, 19 Jul 2021 11:05:04 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 289DEC08EBB4 for ; Mon, 19 Jul 2021 08:00:32 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id t2so24134110edd.13 for ; Mon, 19 Jul 2021 08:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxtx.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SFohRrC/J6yvJekNzc8d5a/rCXsepe2YSJfKC79IXAc=; b=EGWPO34lxZS/UR7cBQkRiPuptCLTxX4xTeh/NVtC5Cxjcy+Klfi83m4iS1j46P8n5q GwnV27ibn8k6pIReRaX6tvQzUZ7XKvPDuzgS5P5i8yTvXTMvkl/BW/UzKWQI+/tiAtIq PUG6SfjmAOu9Fttb60JW3fmvDY/mYtiY6xn9o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SFohRrC/J6yvJekNzc8d5a/rCXsepe2YSJfKC79IXAc=; b=E+jahO3kcBmkXazVjrN37xIgNM4Vkh9aDMcbUWr0W1ecuyC57QwgNeHpO04/fO31yJ KmvjtK4NnumaHRKsKyMGkmZTOXlipQ6XQL6Y584NutitoyrsEzTjQPDHELJ76oibh3Tm Gbj6ngWGrMXwe8eqX539WHuVg5b4ofZhHOlyXmVYiOF4if6q1Zv+Y3TDNpNc7t+t7IQD TAwh1EhSiO0kOLOxEE5kZSqC+vYJa6+5DttYGeZ4eIDhszZCvlQHluahokuIFaL7TRw+ 7lbRuxM/6rsg1+1MYPorT8zParLtc0qHkfGbX7ZQgw9dmLbEEtFknbv85ubK0HEBID4A +Xdg== X-Gm-Message-State: AOAM530BO83Nkowp0Bi39TSbgGHok7cTSkgD3ph2PuM8BvYU3dndzQgc A3Co+/oVyE6w9L9ej+m57Yj2CxUATk2cjmhqMAxS6Q== X-Google-Smtp-Source: ABdhPJzFxSo/D4kyepQRqCtyMUtqcVwoO2Cj10WkZ1Hg9vbFtTWR5fcQDRuQ6zqRqtBTD2CrJEYx/HZEMQtnmXc72jE= X-Received: by 2002:a50:9b06:: with SMTP id o6mr35753968edi.284.1626708549000; Mon, 19 Jul 2021 08:29:09 -0700 (PDT) MIME-Version: 1.0 References: <20210712060912.995381202@linuxfoundation.org> <20210712060916.499546891@linuxfoundation.org> In-Reply-To: From: Justin Forbes Date: Mon, 19 Jul 2021 10:28:57 -0500 Message-ID: Subject: Re: [PATCH 5.13 024/800] usb: renesas-xhci: Fix handling of unknown ROM state To: Moritz Fischer Cc: Greg Kroah-Hartman , LKML , Stable , Mathias Nyman , Vinod Koul Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 17, 2021 at 2:48 PM Moritz Fischer wrote: > > On Sat, Jul 17, 2021 at 07:34:51PM +0200, Greg Kroah-Hartman wrote: > > On Sat, Jul 17, 2021 at 08:39:19AM -0500, Justin Forbes wrote: > > > On Mon, Jul 12, 2021 at 2:31 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > From: Moritz Fischer > > > > > > > > commit d143825baf15f204dac60acdf95e428182aa3374 upstream. > > > > > > > > The ROM load sometimes seems to return an unknown status > > > > (RENESAS_ROM_STATUS_NO_RESULT) instead of success / fail. > > > > > > > > If the ROM load indeed failed this leads to failures when trying to > > > > communicate with the controller later on. > > > > > > > > Attempt to load firmware using RAM load in those cases. > > > > > > > > Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201") > > > > Cc: stable@vger.kernel.org > > > > Cc: Mathias Nyman > > > > Cc: Greg Kroah-Hartman > > > > Cc: Vinod Koul > > > > Tested-by: Vinod Koul > > > > Reviewed-by: Vinod Koul > > > > Signed-off-by: Moritz Fischer > > > > Link: https://lore.kernel.org/r/20210615153758.253572-1-mdf@kernel.org > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > > > > > After sending out 5.12.17 for testing, we had a user complain that all > > > of their USB devices disappeared with the error: > > > > > > Jul 15 23:18:53 kernel: xhci_hcd 0000:04:00.0: Direct firmware load > > > for renesas_usb_fw.mem failed with error -2 > > > Jul 15 23:18:53 kernel: xhci_hcd 0000:04:00.0: request_firmware failed: -2 > > > Jul 15 23:18:53 kernel: xhci_hcd: probe of 0000:04:00.0 failed with error -2 > > > > > > After first assuming that something was missing in the backport to > > > 5.12, I had the user try 5.13.2, and then 5.14-rc1. Both of those > > > failed in the same way, so it is not working in the current Linus tree > > > either. Reverting this patch fixed the issue. > > > > Can you send a revert for this so I can get that into Linus's tree and > > then all stable releases as well? > > > > thanks, > > > > greg k-h > > Me or Justin? I can do it. This is annoying my system doesn't work > without this :-( > > Back to the drawing board I guess ... > > Justin, any idea if your customer had the eeprom populated and > programmed or not, just as additional datapoint. I am not sure, but I did have another user chime in on the bug saying the test kernel with the revert fixed their system as well. It was a T14s AMD Generation_1. The original reporter had a ASUS System Product Name/PRIME H370M-PLUS, BIOS 2801 04/13/2021. Justin > - Moritz