From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3001C38A02 for ; Sat, 29 Oct 2022 04:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbiJ2ELt (ORCPT ); Sat, 29 Oct 2022 00:11:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbiJ2ELn (ORCPT ); Sat, 29 Oct 2022 00:11:43 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07E8F85A88 for ; Fri, 28 Oct 2022 21:11:43 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id p141so6132187iod.6 for ; Fri, 28 Oct 2022 21:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a05XFZRuF/egEfrk+8goUQtIMz5cRuT5WlopnCpocEA=; b=kovLSyB8MPVeIrLXWhsv4ebR53tgy1CbZfJhjTODbTdNXDFJYhSS58l3eIrBPQloXb X1pjzYRmxulUgTVO9lYnvjrDngx55x8ukqNGRn6r8jA1R2skNKQcbkyQvIXoP2mPTljg sS1maOrMjVjwYgXlW9qK6HUrsLu+iIKpJOxKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a05XFZRuF/egEfrk+8goUQtIMz5cRuT5WlopnCpocEA=; b=7nXljMCaMIt32kWTiX82OvWSyb7n/eb/Uxs10aHg3dqdh/B5eSAYfRaWWmxScdSJWU UObzbYfgaSRLGqMgx5vx/k/8NbNhbs261gNMQTHT1a/C6SppKYYzLeNpsdLQznFXBiTe eG02Ht1JojBNN34jyktiMzgC5l8rYE595g6nktLLpxGcWelMmRHHysStZOkbjqYxoZE2 EPnFy4ehLcKbd4Ql6EISBNUrKzZfNDo2Y4zy+HPotVvOzTmZIt9dpw8UskGQau5fIfvI wZ+XUd0d2lN8RJANHPR8V2blR0+zMN2svJhBW88D1CNbQ61ZdN10mJQI0rTSAuoswyYi n/cw== X-Gm-Message-State: ACrzQf2fZ7CIj/HqxcTnmQl+8xAlBel5ab8FVsL750TNtHCleLTEi0Hp hr35LOgFm9JVtWfH1p8KG2yj5kU4LV7X20TpCPXuuw== X-Google-Smtp-Source: AMsMyM4Y55scCBOsz86/H1I8gLjPFFzF+wX16Ll/6KNE81tm9k6eqk5HNMIvLNKpxTO1zj9SQrri/vM5tOasSmUIFeY= X-Received: by 2002:a6b:4a01:0:b0:6bc:d4ae:321c with SMTP id w1-20020a6b4a01000000b006bcd4ae321cmr1385305iob.59.1667016702459; Fri, 28 Oct 2022 21:11:42 -0700 (PDT) MIME-Version: 1.0 References: <20221027151908.v1.1.I295e65357f06f162b46ea6fc6c03be37e3978bdc@changeid> <4b7304c0-8dd5-9add-7c84-4e9f0aa9396b@redhat.com> In-Reply-To: From: Sven van Ashbrook Date: Sat, 29 Oct 2022 00:11:32 -0400 Message-ID: Subject: Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN() To: Rajneesh Bhardwaj , Hans de Goede Cc: "Limonciello, Mario" , LKML , "S-k, Shyam-sundar" , "rrangel@chromium.org" , "platform-driver-x86@vger.kernel.org" , Rajneesh Bhardwaj , Rafael J Wysocki , Rajat Jain , David E Box , Mark Gross Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 27, 2022 at 12:02 PM Rajneesh Bhardwaj wrote: > I'd advise against this promotion based on my experience with S0ix entry failures. On Thu, Oct 27, 2022 at 11:40 AM Hans de Goede wrote: > I'm not a fan of the change you are suggesting here. Thanks everyone for the feedback. Looks like there is consensus that it's not advisable to promote the warning. We will move forward with changes to our monitoring infrastructure instead.