From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB657C43457 for ; Tue, 20 Oct 2020 08:52:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75A192245B for ; Tue, 20 Oct 2020 08:52:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aTeZpAxI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392151AbgJTIw6 (ORCPT ); Tue, 20 Oct 2020 04:52:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389705AbgJTIw5 (ORCPT ); Tue, 20 Oct 2020 04:52:57 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 404CAC0613CE for ; Tue, 20 Oct 2020 01:52:56 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id b6so615339pju.1 for ; Tue, 20 Oct 2020 01:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D/Gf2EPIdX5qA2A6HlcDWWaVkQkKjG0YsM21d64zQ1U=; b=aTeZpAxII2U/rVVZft7oEyyt1XqC7jMP/kkvxEpio0hlobUSyEfH9hY47HwLpIjs8h krQXBk3X6kkPJsazPFAMiINeVsoDMYuDJr1s+EOXKEe+k0ewVjXhaFUoELuosxtMVIcl w/OrH33T0CmTc5+SkMUXFyud9fgaDN82nYiXOEoLnuk73mguRhm7tSlx6q6Kyo2/kRJD 1ghEBc+qTxSDi85MU87EHAx8UDgUz6X5knW+7hDhR4ebHk4e+1qamzBjRgGBYj6kzm5B BHvYrusFfdVnbO6lzubiRsy891swODyqSQvmnnxl8PRr83KDiSxYzFFvvntB3kbA+EB8 twWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D/Gf2EPIdX5qA2A6HlcDWWaVkQkKjG0YsM21d64zQ1U=; b=CMT5/w08Z8bNI8WjBx6Hq6aFA2uxHpT4bFYDi68GhmHmvHQuJ2noCBthipmBCLmtVT TJNGJSJ7vyBSTfQdrFMJuSEMKWWsTC1Jy0nC4sVU7INmHgngxENZDZ++bJk4J+jCy6e9 2eJbgTWiCoH5YoHwgvvNeYMs6Es7c4YhqIrrqLTx2ejVqUAqroPpawerH8up5ce95IMm vURRSf5qkQrgwXniaiYcQZk2/RGMQn1815c51lffJZabk4bQ4CqugVnJz7sHowv5j5yF XNLwCp//pggFg5SpXE78+EwkYe1ipj9xQt0jnJpOGtxCo52TIMKNLRKKYrVvbdVQB/Ci 8AVw== X-Gm-Message-State: AOAM532TQwj7E7+dxxfyq3SODzGc8Wdk0o0DZjGYABwCHA6h7+0XroUr dEyyIUGE/6HCuoesdvy5f+Aa4J4KzH4z/FujispDqw== X-Google-Smtp-Source: ABdhPJzn235Ieb/yA26fp/gsyes8m4Z1IMTMaB5DacVIupjjGmBYpO2cm8jk4usXtX0nqpoze5E6oCDMq43tVzwbLLc= X-Received: by 2002:a17:90a:160f:: with SMTP id n15mr1877221pja.75.1603183975701; Tue, 20 Oct 2020 01:52:55 -0700 (PDT) MIME-Version: 1.0 References: <20201018125237.16717-1-kholk11@gmail.com> <20201018125237.16717-2-kholk11@gmail.com> In-Reply-To: <20201018125237.16717-2-kholk11@gmail.com> From: Robert Foss Date: Tue, 20 Oct 2020 10:52:44 +0200 Message-ID: Subject: Re: [PATCH 1/6] media: camss: csiphy-3ph: Add support for SDM630/660 To: kholk11@gmail.com Cc: Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Rob Herring , marijns95@gmail.com, konradybcio@gmail.com, martin.botka1@gmail.com, linux-arm-msm@vger.kernel.org, linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Angelo, On Sun, 18 Oct 2020 at 14:52, wrote: > > From: AngeloGioacchino Del Regno > > The CSIPHY on SDM630/660 needs a slightly longer T_HS_CLK_MISS > configuration on lanes CFG4. > > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > index 2e65caf1ecae..97cb9de85031 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > @@ -8,6 +8,7 @@ > * Copyright (C) 2016-2018 Linaro Ltd. > */ > > +#include "camss.h" > #include "camss-csiphy.h" > > #include > @@ -21,6 +22,7 @@ > #define CSIPHY_3PH_LNn_CFG3(n) (0x008 + 0x100 * (n)) > #define CSIPHY_3PH_LNn_CFG4(n) (0x00c + 0x100 * (n)) > #define CSIPHY_3PH_LNn_CFG4_T_HS_CLK_MISS 0xa4 > +#define CSIPHY_3PH_LNn_CFG4_T_HS_CLK_MISS_660 0xa5 > #define CSIPHY_3PH_LNn_CFG5(n) (0x010 + 0x100 * (n)) > #define CSIPHY_3PH_LNn_CFG5_T_HS_DTERM 0x02 > #define CSIPHY_3PH_LNn_CFG5_HS_REC_EQ_FQ_INT 0x50 > @@ -198,7 +200,10 @@ static void csiphy_lanes_enable(struct csiphy_device *csiphy, > val = CSIPHY_3PH_LNn_CFG1_SWI_REC_DLY_PRG; > writel_relaxed(val, csiphy->base + CSIPHY_3PH_LNn_CFG1(l)); > > - val = CSIPHY_3PH_LNn_CFG4_T_HS_CLK_MISS; > + if (csiphy->camss->version == CAMSS_660) The CAMSS_660 enum is not defined until patch #4, so building fails here. I expect to see this issue in a few other places, but I'll refrain from pointing them all out. > + val = CSIPHY_3PH_LNn_CFG4_T_HS_CLK_MISS_660; > + else > + val = CSIPHY_3PH_LNn_CFG4_T_HS_CLK_MISS; > writel_relaxed(val, csiphy->base + CSIPHY_3PH_LNn_CFG4(l)); > > val = CSIPHY_3PH_LNn_MISC1_IS_CLKLANE; > -- > 2.28.0 >