From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9319C433F5 for ; Mon, 11 Oct 2021 10:08:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A186660F22 for ; Mon, 11 Oct 2021 10:08:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235809AbhJKKKK (ORCPT ); Mon, 11 Oct 2021 06:10:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235792AbhJKKKH (ORCPT ); Mon, 11 Oct 2021 06:10:07 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B840C061745 for ; Mon, 11 Oct 2021 03:08:08 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id 21so4777849plo.13 for ; Mon, 11 Oct 2021 03:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u66x+DvFzcvxDL4R401DA3OxtOZOzKWRxFNlQpUAwk4=; b=bhIfWYIIsEpxeC2fqXuWaiwromauVoxgfuX1ZjnFfvYMuku409+s0YOxThZsFfvtbG DxXcwxPkufZJu3igkA0k8zj7ZmILEUtmERd/15rsRPXodJgriQf/EjfSZhz4R2FUG+u3 L/lNgosrQpVUM2VxcQ98jGq2Mz4PFKJMV4P5F5liLsAKc+/h3esK+lo9XAr6HeXQA1VW K7AvDBvqNIeE/LSnRCL9lUzEUyRmcUgb9fYKHZI1ps9YdIA8TBoyHgQWLNeIdxReDnub A8Udfs+tXulfA1d92hQpLXRLOQiDBPE+MNjTFmqOWhAV0gNakLCSbBwtFwaLbqY4VUU8 LMEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u66x+DvFzcvxDL4R401DA3OxtOZOzKWRxFNlQpUAwk4=; b=SfhWFRwfWUh+55uZ0KMCRVLquW2+nwtNA8Pr27DJ2EamN4NOHjjloEjmMXxjC3F+UL QQ6SwoCtNlnnRS/JldtixRtyx8/d6idpF5EsGotRtbdzTPeV7+xQhjv0y17YjHzuqr3x P/eOXSBgYtk5bovBBjBPc1mVs/erPGQM/nbo4uALXEBO8aOFJCnJMkEmn0W2zRtxi4uD ZIZiZHHdXMGi6xsYlpjqqlsNgkyMN7B6u6b42K9zRh8kZ5SpVTyoGRLhxyjQhUMOQqCY pUMKzAhIAGyLyBGjMIBrD9yklz4W2BLQHYke/iRZw/ofq44m/H1dQmtLXIWSfDwZXAYH iIZQ== X-Gm-Message-State: AOAM531uSQ8y5kGtupZ540d+3SmT23n9hdZUveZgdICGznXztCwvRwR6 TItSRUMSwM9Xw5lkJ5eCuOBoFNJaWiQeEkMfEITU/Q== X-Google-Smtp-Source: ABdhPJw32gI1+wJBKZuA3dhXVX7I7x2jha8F2ADZUukokqUNwu8HWhMiXDfHvVNzI720oozgZqJbHscFj9IXZst17DI= X-Received: by 2002:a17:90a:190:: with SMTP id 16mr29679685pjc.152.1633946887083; Mon, 11 Oct 2021 03:08:07 -0700 (PDT) MIME-Version: 1.0 References: <20210924152607.28580-1-tim.gardner@canonical.com> In-Reply-To: <20210924152607.28580-1-tim.gardner@canonical.com> From: Robert Foss Date: Mon, 11 Oct 2021 12:07:55 +0200 Message-ID: Subject: Re: [PATCH] drm/bridge: parade-ps8640: check return values in ps8640_aux_transfer() To: Tim Gardner Cc: dri-devel , William Breathitt Gray , Syed Nayyar Waris , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , linux-iio@vger.kernel.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Tim, Thanks for submitting this. I'm seeing some checkpatch --strict warnings. Could you fix them and resubmit the series? On Fri, 24 Sept 2021 at 17:26, Tim Gardner wrote: > > Coverity complains of an unused return code: > > CID 120459 (#1 of 1): Unchecked return value (CHECKED_RETURN) > 7. check_return: Calling regmap_bulk_write without checking return value (as is Checkpatch is unhappy about the length of this line. > done elsewhere 199 out of 291 times). > 204 regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, > 205 ARRAY_SIZE(addr_len)); > > While I was at it I noticed 2 other places where return codes were not being > used, or used incorrectly (which is a real bug). > > Fix these errors by correctly using the returned error codes. > > Cc: William Breathitt Gray > Cc: Syed Nayyar Waris > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: David Airlie > Cc: Daniel Vetter > Cc: linux-iio@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Tim Gardner > --- > drivers/gpu/drm/bridge/parade-ps8640.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c > index 3aaa90913bf8..591da962970a 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8640.c > +++ b/drivers/gpu/drm/bridge/parade-ps8640.c > @@ -201,8 +201,12 @@ static ssize_t ps8640_aux_transfer(struct drm_dp_aux *aux, > addr_len[PAGE0_SWAUX_LENGTH - base] = (len == 0) ? SWAUX_NO_PAYLOAD : > ((len - 1) & SWAUX_LENGTH_MASK); > > - regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, > + ret = regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, > ARRAY_SIZE(addr_len)); Align to open parenthesis. > + if (ret) { > + DRM_DEV_ERROR(dev, "failed to bulk write ADDR_7_0: %d\n", ret); > + return ret; > + } > > if (len && (request == DP_AUX_NATIVE_WRITE || > request == DP_AUX_I2C_WRITE)) { > @@ -218,13 +222,17 @@ static ssize_t ps8640_aux_transfer(struct drm_dp_aux *aux, > } > } > > - regmap_write(map, PAGE0_SWAUX_CTRL, SWAUX_SEND); > + ret = regmap_write(map, PAGE0_SWAUX_CTRL, SWAUX_SEND); > + if (ret) { > + DRM_DEV_ERROR(dev, "failed to write SEND: %d\n", ret); > + return ret; > + } > > /* Zero delay loop because i2c transactions are slow already */ > regmap_read_poll_timeout(map, PAGE0_SWAUX_CTRL, data, > !(data & SWAUX_SEND), 0, 50 * 1000); > > - regmap_read(map, PAGE0_SWAUX_STATUS, &data); > + ret = regmap_read(map, PAGE0_SWAUX_STATUS, &data); > if (ret) { > DRM_DEV_ERROR(dev, "failed to read PAGE0_SWAUX_STATUS: %d\n", > ret); > -- > 2.33.0 >