From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEA4C47082 for ; Mon, 31 May 2021 11:13:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C7446128A for ; Mon, 31 May 2021 11:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231397AbhEaLPE (ORCPT ); Mon, 31 May 2021 07:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230521AbhEaLPD (ORCPT ); Mon, 31 May 2021 07:15:03 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09415C061574 for ; Mon, 31 May 2021 04:13:24 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id c13so132923plz.0 for ; Mon, 31 May 2021 04:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M7rtmjYl1G3JP0LENPx/2+MKo1rvZR64UzRNYVYPL7k=; b=w+UhEQrG+R7Z/4whk2QWB0GpaE2LdfTk8YPS8MmFSqs7j4IGlKZx/sufJPT0FZqI73 PDDtWTlqsXctWMrnCGMSjw28USLt+rhW9HVMmKsmihVusO0gr/TiC4+Ei9OoqJrMm369 6rtEByCdptgX+sMNeB1dXJ77B+lGLI79Svd85ZS/JoR2p5joREW4usOsjticuuf7mXVo Khxxnp/mXO+EACO2cefAn0RQ97+oPl9WGSbtaT4t/zxdj2xJvTCcLmD9F0yyUF26pVXz mFH/67zohktL0ZKp9nnsQMcKeMEjo81pGpbFccVVnGZ5ZYb7q0a8BVrvg0DywCaFo8aS qhjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M7rtmjYl1G3JP0LENPx/2+MKo1rvZR64UzRNYVYPL7k=; b=dGpS6FxW3j2TDHXVIdKRjdg9VDw2JXnskp1ISiiy4NPBCoqaC4KLHijfj//2W2p7He jUVnvFJZKW3jw2Bj4zhK+M1mMaroLeelP+ClQQlfo9EwagfVi+wwW1/raVCXE7fkeu+x X+M766Zoo9HX61DmlfN1s32J3C7thhGI3nQBp4R6xa278ipmdYc/L4Y+RXnETgvch78N Ff5b/qXIbqMd2CPogceYEuRzqB4ZlDoW6wCuFLey/bMJa3Wwfv/wXEhjT7oR4/59EFCM j0/TG408u0kfCpvRcrvW/Ww1i4OXFh1P4775Dbire8NrpdBKxj+mEEkqrEl61kODh5Gl 8VSg== X-Gm-Message-State: AOAM530mV3pd4NQm3iZ26/ugPkW0mN3uPLXsArZvGiqFn+pC7fGHuiCo PLeP6SdYC51KjqhIeNE+FCp6PM8HJbZlb6lq8sf/dA== X-Google-Smtp-Source: ABdhPJzHo45kjOG5SmoDhd2D6ubaSlNGrUiJnR6xQnJqE+ZlExbxX8BmsLLaheQLQdhoyH8nLuCC0xiGMxT335qc7uk= X-Received: by 2002:a17:902:b713:b029:fd:8738:63cb with SMTP id d19-20020a170902b713b02900fd873863cbmr19905123pls.28.1622459603605; Mon, 31 May 2021 04:13:23 -0700 (PDT) MIME-Version: 1.0 References: <20210511180728.23781-1-jonathan@marek.ca> <20210511180728.23781-14-jonathan@marek.ca> In-Reply-To: <20210511180728.23781-14-jonathan@marek.ca> From: Robert Foss Date: Mon, 31 May 2021 13:13:12 +0200 Message-ID: Subject: Re: [PATCH 13/17] media: camss: vfe-170: fix "VFE halt timeout" error To: Jonathan Marek Cc: MSM , Andrey Konovalov , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Hans Verkuil , "open list:QUALCOMM CAMERA SUBSYSTEM DRIVER" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 May 2021 at 20:08, Jonathan Marek wrote: > > This function waits for halt_complete but doesn't do anything to cause > it to complete, and always hits the "VFE halt timeout" error. Just delete > this code for now. > > Fixes: 7319cdf189bb ("media: camss: Add support for VFE hardware version Titan 170") > Signed-off-by: Jonathan Marek > --- > drivers/media/platform/qcom/camss/camss-vfe-170.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe-170.c b/drivers/media/platform/qcom/camss/camss-vfe-170.c > index 076ca082e107..080eef767d3b 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe-170.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe-170.c > @@ -363,17 +363,7 @@ static irqreturn_t vfe_isr(int irq, void *dev) > */ > static int vfe_halt(struct vfe_device *vfe) > { > - unsigned long time; > - > - reinit_completion(&vfe->halt_complete); > - > - time = wait_for_completion_timeout(&vfe->halt_complete, > - msecs_to_jiffies(VFE_HALT_TIMEOUT_MS)); > - if (!time) { > - dev_err(vfe->camss->dev, "VFE halt timeout\n"); > - return -EIO; > - } > - > + /* rely on vfe_disable_output() to stop the VFE */ > return 0; > } Reviewed-by: Robert Foss