From: Robert Foss <robert.foss@linaro.org>
To: Xin Ji <xji@analogixsemi.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
bliang@analogixsemi.com, qwen@analogixsemi.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
Date: Fri, 22 Apr 2022 16:01:47 +0200 [thread overview]
Message-ID: <CAG3jFytWGSUM9mevHewdmEe-hq3JgB74s7_f0fsEQqkXr9VUHg@mail.gmail.com> (raw)
In-Reply-To: <20220422084720.959271-4-xji@analogixsemi.com>
On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
>
> As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 376da01243a3..71df977e8f53 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
>
> anx7625_get_swing_setting(dev, pdata);
>
> - pdata->is_dpi = 1; /* default dpi mode */
> + pdata->is_dpi = 0; /* default dsi mode */
> pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> if (!pdata->mipi_host_node) {
> DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> return -ENODEV;
> }
>
> - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> + bus_type = 0;
> mipi_lanes = MAX_LANES_SUPPORT;
> ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> if (ep0) {
> @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> }
>
> - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> - pdata->is_dpi = 0;
> + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> + pdata->is_dpi = 1;
>
> pdata->mipi_lanes = mipi_lanes;
> if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
Reviewed-by: Robert Foss <robert.foss@linaro.org>
next prev parent reply other threads:[~2022-04-22 14:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 8:47 [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji
2022-04-22 8:47 ` [PATCH v2 2/4] dt-bindings: media: video-interfaces: Add new bus-type Xin Ji
2022-04-22 14:03 ` Robert Foss
2022-04-22 8:47 ` [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property Xin Ji
2022-04-22 14:03 ` Robert Foss
2022-04-22 14:10 ` Robert Foss
2022-05-02 21:07 ` Rob Herring
2022-04-22 8:47 ` [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type Xin Ji
2022-04-22 14:01 ` Robert Foss [this message]
2022-04-22 14:13 ` Robert Foss
2022-04-25 8:24 ` Chen-Yu Tsai
2022-04-25 8:29 ` Chen-Yu Tsai
2022-04-25 9:14 ` Xin Ji
2022-05-17 16:09 ` Robert Foss
2022-05-21 16:07 ` Daniel Vetter
2022-05-21 16:28 ` Daniel Vetter
2022-05-23 3:13 ` Xin Ji
2022-05-23 7:17 ` Chen-Yu Tsai
2022-05-23 8:37 ` Robert Foss
2022-05-23 8:47 ` Robert Foss
2022-06-17 10:32 ` Chen-Yu Tsai
2022-06-20 19:13 ` Robert Foss
2022-04-22 14:10 ` [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG3jFytWGSUM9mevHewdmEe-hq3JgB74s7_f0fsEQqkXr9VUHg@mail.gmail.com \
--to=robert.foss@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=bliang@analogixsemi.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=qwen@analogixsemi.com \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).