From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F5E8C433ED for ; Thu, 20 May 2021 12:19:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EED9D611AD for ; Thu, 20 May 2021 12:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231861AbhETMUp (ORCPT ); Thu, 20 May 2021 08:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231997AbhETMUe (ORCPT ); Thu, 20 May 2021 08:20:34 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 229D4C081429 for ; Thu, 20 May 2021 04:10:57 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so5090668pjv.1 for ; Thu, 20 May 2021 04:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+SQgtRFMTp/VNytQ8r2NMcxoq1dwxAECxDdDjfqIL4s=; b=P3b/Duz8M4+Hge7/LfFHO6OMmXFcXb6YJWngVCFP30Cqt2TUl7tTfjonWXL6xcV0q6 YHjHgB9FKTVS8VZxA8in9hltL44LI1jo5rOL2qSDOAmK5kxlFm7PIJ7C5WtMB2M8VSXl PYgXweW80DrRT+vmN3DfYebgYYfgJU0yKCoxUS82cNpRQKTsG+sM32LktXd4PxRhN33y JFXXWSraFn+EGPocj1LYIAS7ZuZQqDksLJr7CA9r94zw+ijR+paOLSoTVe2j/eZyFYD6 QfytsDf6AcM9xzqVplhtpNaHeyxiWf00T78zZW61CThPH7kkrUxuosIW7vW7ITmObmOj 1+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+SQgtRFMTp/VNytQ8r2NMcxoq1dwxAECxDdDjfqIL4s=; b=cNomsGaCCHlrgEK0oYQ3lJc05y85J09SAmdb7afpsb6SMg2SXrOSBebhZY+2ppfMZj jAGuUcww3DVtCC8Vzd1HedpYkITixdxCe/JZn03tKgX/xcbTR8pqhc4/1GdLhDIgCSnu Xj4dL+JODlvhkq36/aogTu5OYlIFocwuVGmt1xy9jQ36Fez761RrsiuPWLIy9S+f0FUy 14ZCzHLSdkAAvnOPSkI0xcbdME3E+PeyqugEVNTYQe5O9oSQnmw4cbQzNVXOGcbQI3S7 a8XR4REAPaywdk+l/jxK5amV7nUyd/omgJupM8AZiH6G5X+X48LU78h+roVyEwqLuXXz WK8g== X-Gm-Message-State: AOAM531R2bLpnNWtRVJt8PVH5HiSM1xXLDZ43lgojMIb3QCmJI428u6S ahQYqu00GZWpvek6qQJxAkvY7ixCqKnlc6GW5JaMbg== X-Google-Smtp-Source: ABdhPJxDatCkyaJySsM7YbGJJF1h+SyvbWfKKUQgB5JZyAvMmGF4EU5+OXQG1W4UyBPcNUeSO9L3ZjFa6fX//+V5nOs= X-Received: by 2002:a17:902:8693:b029:f3:b47e:6a08 with SMTP id g19-20020a1709028693b02900f3b47e6a08mr5169048plo.69.1621509056670; Thu, 20 May 2021 04:10:56 -0700 (PDT) MIME-Version: 1.0 References: <20210511180728.23781-1-jonathan@marek.ca> <20210511180728.23781-9-jonathan@marek.ca> In-Reply-To: <20210511180728.23781-9-jonathan@marek.ca> From: Robert Foss Date: Thu, 20 May 2021 13:10:45 +0200 Message-ID: Subject: Re: [PATCH 08/17] media: camss: csid-170: set the right HALF_CMD when disabled To: Jonathan Marek Cc: MSM , Andrey Konovalov , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Hans Verkuil , "open list:QUALCOMM CAMERA SUBSYSTEM DRIVER" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Jonathan, On Tue, 11 May 2021 at 20:08, Jonathan Marek wrote: > > Use the "HALT_CMD_RESUME_AT_FRAME_BOUNDARY" define instead of a "1" which > is otherwise confusing, and add a "HALT_CMD_HALT_AT_FRAME_BOUNDARY" which > is set when disabling. > > Fixes: eebe6d00e9bf ("media: camss: Add support for CSID hardware version Titan 170") > Signed-off-by: Jonathan Marek > --- > drivers/media/platform/qcom/camss/camss-csid-170.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-170.c b/drivers/media/platform/qcom/camss/camss-csid-170.c > index af134ded241d..9f6334fd68fc 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-170.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-170.c > @@ -105,7 +105,8 @@ > #define CSID_RDI_CTRL(rdi) ((IS_LITE ? 0x208 : 0x308)\ > + 0x100 * (rdi)) > #define RDI_CTRL_HALT_CMD 0 > -#define ALT_CMD_RESUME_AT_FRAME_BOUNDARY 1 > +#define HALT_CMD_HALT_AT_FRAME_BOUNDARY 0 > +#define HALT_CMD_RESUME_AT_FRAME_BOUNDARY 1 > #define RDI_CTRL_HALT_MODE 2 > > #define CSID_RDI_FRM_DROP_PATTERN(rdi) ((IS_LITE ? 0x20C : 0x30C)\ > @@ -443,7 +444,10 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable) > val |= 1 << CSI2_RX_CFG1_MISR_EN; > writel_relaxed(val, csid->base + CSID_CSI2_RX_CFG1); > > - val = 1 << RDI_CTRL_HALT_CMD; > + if (enable) > + val = HALT_CMD_RESUME_AT_FRAME_BOUNDARY << RDI_CTRL_HALT_CMD; > + else > + val = HALT_CMD_HALT_AT_FRAME_BOUNDARY << RDI_CTRL_HALT_CMD; > writel_relaxed(val, csid->base + CSID_RDI_CTRL(0)); Reviewed-by: Robert Foss