From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1376C10F1E for ; Thu, 15 Dec 2022 11:20:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229841AbiLOLUq (ORCPT ); Thu, 15 Dec 2022 06:20:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbiLOLUk (ORCPT ); Thu, 15 Dec 2022 06:20:40 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B47AC54 for ; Thu, 15 Dec 2022 03:20:39 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id m204so5002934oib.6 for ; Thu, 15 Dec 2022 03:20:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cmk0PdpBMK0sped7JhGYOwBdXV8EVeBAiY0Lb6X/myc=; b=Wka0wIlExft4VpGS8jLFeSOPzzT8wmggrLJis4x7Mzie5Z9AOositkhMfK3TP+uYp5 GoDJf5iXgh5+zRRcH/yoaJIKf324F84RXMUJdNtpEnsHw8N2n5+/JD8VUy71QlKUxqox RCJe4e99/CdKLeDsymFfMT+sIqdgtB0pbc48X4x+/rob6dpe4zYBN2NH0814BQTTf4/r gUOPPDYNFRqNX3qzI2rYHlwnUin2LYQQfQbMgjL/R8fUzxAiirfK/qNbOe2DJNVNKnAX 9NK6rA9Zv5lWo2VBZd1Q73gRRiOZsjRRXSU4HCpTIniKnP9tJnTMcYjingezIYH2wRa0 d4MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cmk0PdpBMK0sped7JhGYOwBdXV8EVeBAiY0Lb6X/myc=; b=Od+hB7vTPilJitL4bVWVqfk3YqszYCXMDPeXbPs6dvbeyHds1QdhbAEExRrHFIJvRm xSOPsp6NVXBjhIt6ZRlVer407KyVLbBDShjM57uTDnDItol/M2sTo/qDZqei9KjC3zu+ uLKFsT/xBq9AbBGE57eN37sojSqlejn1d1xwUFEHYpWCghCHe1kwctcr+GV9Rv89YSJM DUPXgAbRy/zpd/Drf1V9Z4mpA5lbbhd99bkBOGgkkaj2L0P87OxXuGXClkXH9WgWPIrr vpvAzKVlix9pwynxNJf8O5wRlGQAa2gWbylm+6/xj2HY2uZiL/rIfGqA8hyUDKSUJmEO mwgw== X-Gm-Message-State: ANoB5plqfhh7mY30gaQcjKJc1XSoIvFKB8JHI60mYOFiFaxfD6JBRtlL abzi8lSgU5AN/JzJGYvfMk4ZuHS6WNc3W3xODShA0w== X-Google-Smtp-Source: AA0mqf6ul9+QZU4hm6yqMhWx9ryWax/rv5tjNs1P8UrwxuqP7LLLD/URmkKdihtN7/JQhAlX2g6zMdxTJ2U46P3YUvo= X-Received: by 2002:aca:1c07:0:b0:359:ef86:2f4f with SMTP id c7-20020aca1c07000000b00359ef862f4fmr308690oic.14.1671103238656; Thu, 15 Dec 2022 03:20:38 -0800 (PST) MIME-Version: 1.0 References: <20221214125821.12489-1-paul@crapouillou.net> <20221214125821.12489-8-paul@crapouillou.net> In-Reply-To: <20221214125821.12489-8-paul@crapouillou.net> From: Robert Foss Date: Thu, 15 Dec 2022 12:20:27 +0100 Message-ID: Subject: Re: [PATCH 07/10] drm: bridge: it66121: Don't clear DDC FIFO twice To: Paul Cercueil Cc: Phong LE , Neil Armstrong , Andrzej Hajda , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , list@opendingux.net, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Dec 2022 at 13:59, Paul Cercueil wrote: > > The DDC FIFO was cleared before the loop in it66121_get_edid_block(), > and at the beginning of each iteration; which means that it did not have > to be cleared before the loop. > > Signed-off-by: Paul Cercueil > --- > drivers/gpu/drm/bridge/ite-it66121.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c > index 06fa59ae5ffc..5335d4abd7c5 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -456,18 +456,6 @@ static inline int it66121_wait_ddc_ready(struct it66121_ctx *ctx) > return 0; > } > > -static int it66121_clear_ddc_fifo(struct it66121_ctx *ctx) > -{ > - int ret; > - > - ret = it66121_preamble_ddc(ctx); > - if (ret) > - return ret; > - > - return regmap_write(ctx->regmap, IT66121_DDC_COMMAND_REG, > - IT66121_DDC_COMMAND_FIFO_CLR); > -} > - > static int it66121_abort_ddc_ops(struct it66121_ctx *ctx) > { > int ret; > @@ -515,10 +503,6 @@ static int it66121_get_edid_block(void *context, u8 *buf, > offset = (block % 2) * len; > block = block / 2; > > - ret = it66121_clear_ddc_fifo(ctx); > - if (ret) > - return ret; > - > while (remain > 0) { > cnt = (remain > IT66121_EDID_FIFO_SIZE) ? > IT66121_EDID_FIFO_SIZE : remain; > -- > 2.35.1 > Reviewed-by: Robert Foss