From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F0BC47089 for ; Thu, 27 May 2021 12:11:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CF8C613BC for ; Thu, 27 May 2021 12:11:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235143AbhE0MMg (ORCPT ); Thu, 27 May 2021 08:12:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235031AbhE0MMe (ORCPT ); Thu, 27 May 2021 08:12:34 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AD87C061574 for ; Thu, 27 May 2021 05:11:00 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id 6so3544215pgk.5 for ; Thu, 27 May 2021 05:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oRhOKDNCOPh50Z/aFWDPzmEZC3yRRNIu9ormTXELjPU=; b=FAtHvEHXffBJBOCgQsvJa5akS5Nglw9bWWCOVrq4tcCcg56lvMMxOowZje89pRhld5 /c8grAu+6J5TfmjOPe7da67YYS7LaYbFWgkYRIPqX9O+tqYiFqfZbfMzcM6UxJUOt+zO FmIUWqnkMURbc5YamnxktnGwtz/QS0O07i8B3J7PyXQTbNMD9/t23e3UEt/wJ3m7RxWe IEoMJmbe/P+BxFd1Ce6vvW3vAQ6OqG2sb9YGAjKykheU6Q+0Q7jSuxQDLzOWCPj+QPeT EZpfZF/T5brTa2jKcbHX5vc96olSdqvgBBaHH6X97bStJ84eojoH9IPstHB9lxYkPjqU zP6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oRhOKDNCOPh50Z/aFWDPzmEZC3yRRNIu9ormTXELjPU=; b=hHHGWHWcBINhvGi9nrYaR35KtzraC5vVu5TX1Yqv7QxRkHCwEHMhfY/6lRAFj/rU+R soBTEG0W1FKNormFIUFORPZ8oJ1KWfep+w5pby5k7f0wkYTeEmJhUyBQo09Umu7L6aaI eqYHKFv2AFTVBbVfWK63jh00iT5wQXHl4eJSGPDJ3+DQJ5mLZVPkh6aDETEactpP4UKL Bn7kfsWX7Gep45mPKQNUyHLZMLASvW0msJTiNz0uZyJcx4pf3XmZkB+8EEiPZ17lo90n XlLlwW7xGV2P8yU36JpXOfs7ca+ntAifPTT83MGO1C/1zEIFaRhedy477f9D4MtNd5bX Rm2g== X-Gm-Message-State: AOAM531bIF/mzclhwH69Eo0YgQQLFIjuvHjFjsYzEDMRQsIX66lRczDV Dwy0/UShPgARO0lKB5627zJz0pHqtWfHMgkMLZz2eg== X-Google-Smtp-Source: ABdhPJwyrVAU5VpztJZBZHZ+lAWPAAKCkinkA93Nd0vesd87KBbFlG9BIMaHP3lTMMMgQZJDGsQJmZeEH33Mvf9+32w= X-Received: by 2002:a63:4e01:: with SMTP id c1mr3455280pgb.265.1622117459824; Thu, 27 May 2021 05:10:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Robert Foss Date: Thu, 27 May 2021 14:10:48 +0200 Message-ID: Subject: Re: [PATCH] drm/bridge: DRM_CROS_EC_ANX7688 should depend on I2C_CROS_EC_TUNNEL To: Enric Balletbo i Serra Cc: Geert Uytterhoeven , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Hsin-Yi Wang , Nicolas Boichat , dri-devel , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pushed to drm-misc-next. On Thu, 27 May 2021 at 13:07, Enric Balletbo i Serra wrote: > > Hi Geert, > > Thank you for your patch. > > On 26/5/21 9:50, Geert Uytterhoeven wrote: > > The ChromeOS EC ANX7688 bridge is connected to a ChromeOS Embedded > > Controller, and is accessed using I2C tunneling through the Embedded > > Controller. Hence add a dependency on I2C_CROS_EC_TUNNEL, to prevent > > asking the user about this driver when configuring a kernel without > > support for the ChromeOS EC tunnel I2C bus. > > > > Fixes: 44602b10d7f2a5f7 ("drm/bridge: Add ChromeOS EC ANX7688 bridge driver support") > > Signed-off-by: Geert Uytterhoeven > > Reviewed-by: Enric Balletbo i Serra > > > --- > > drivers/gpu/drm/bridge/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > > index 7e7f28eb954661e2..c96e4b38d1d34ee6 100644 > > --- a/drivers/gpu/drm/bridge/Kconfig > > +++ b/drivers/gpu/drm/bridge/Kconfig > > @@ -53,6 +53,7 @@ config DRM_CHRONTEL_CH7033 > > config DRM_CROS_EC_ANX7688 > > tristate "ChromeOS EC ANX7688 bridge" > > depends on OF > > + depends on I2C_CROS_EC_TUNNEL || COMPILE_TEST > > select DRM_KMS_HELPER > > select REGMAP_I2C > > help > >