From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97ED4C433ED for ; Tue, 18 May 2021 12:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7017B61042 for ; Tue, 18 May 2021 12:41:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349355AbhERMnJ (ORCPT ); Tue, 18 May 2021 08:43:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349333AbhERMnH (ORCPT ); Tue, 18 May 2021 08:43:07 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F51FC061573 for ; Tue, 18 May 2021 05:41:49 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id y32so6903471pga.11 for ; Tue, 18 May 2021 05:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zPV3K26dvdjDa+ECWwQHCEA6qNfiJm2G6Q+0tfcH888=; b=Tt+B6a2rdcAX4dIBAi4uk2CUSsO2+nNbX68xBKA/UwZ/MJWld7KBHa4qubivIbumT7 7KyEpxYTSDxfUEfxljz1Plbi3NG+6Yd+hcCi3fMuJxMThhHqbPDpIsk/h5YFd798KNNK coFJS6+qRap0isyl969mzL4PAuf6a0wF01wQfRLe2cI/DL2r6gREon5VvLO5XebqFXi7 O7hgogVqkEKxzGI1eGEgoqgqKWBonlS7eypSqh1HpzJwwTnbi+FhhWb9/LSrEYU75dvh W/O+ghJVjlZqH32eZtFeh2fYNxKFaJVKLZGSEKJX1FSM42bfAwAyidMQEGNwMRkWmjp0 p0mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zPV3K26dvdjDa+ECWwQHCEA6qNfiJm2G6Q+0tfcH888=; b=PeO84kBflhnGBNgsoTt2sKkGvVZn+y5ZmnZAygRrW+S82tzzxW0grUDSWomC/aJ2ut p2cqOdZy/kXBuoNXMbQt+8IaBz4MNgVmFlsEReKRgTcxg8MxNQH+YTfK5OC0ZjmFpX6Z HmTKrqEud1EIgaxOYer9nWGt7Q1rhLJ9D0uoHrfcfgoMEPBlb/WEjEIxsddvLc/r6eeH mlSA0ZsLlXd4zsI4PdDsWWgj/QAOx0oPLV2y+YCy4VLYJC631FNcUzCggak5jxAMdX4d GJ8QeOf0b4yS26Jm2KVyJjdumih51jkUhv3J7OSWIQCkzbWXVf6CNYRzNPgnr22Q9nXy 6y6A== X-Gm-Message-State: AOAM531c0S5peQRCW6le+do1JsHnDgMv2Q1pwGlLpltW+O3MooK8vorG oWgx3emykXHevleuKIoapiKiPARB7iT5tA85S5Mq6Q== X-Google-Smtp-Source: ABdhPJxW4B3qGcX6cEKCQ8WUmerHMrOS7cH3Pbc8td72A61NZ0Ff/irZw3kjZJK3b/Y2W7YuGFdpv0vOztLdp0Wo+/A= X-Received: by 2002:a62:6544:0:b029:261:14cc:b11d with SMTP id z65-20020a6265440000b029026114ccb11dmr5120874pfb.12.1621341708972; Tue, 18 May 2021 05:41:48 -0700 (PDT) MIME-Version: 1.0 References: <20210513175258.5842-1-jonathan@marek.ca> <20210513175258.5842-4-jonathan@marek.ca> In-Reply-To: From: Robert Foss Date: Tue, 18 May 2021 14:41:37 +0200 Message-ID: Subject: Re: [PATCH 3/3] clk: qcom: Add camera clock controller driver for SM8250 To: Jonathan Marek Cc: MSM , Andrey Konovalov , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , open list , "open list:COMMON CLK FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > >> +} > >> + > >> +static struct platform_driver cam_cc_sm8250_driver = { > >> + .probe = cam_cc_sm8250_probe, > >> + .driver = { > >> + .name = "cam_cc-sm8250", > > > > Maybe conforming with the naming scheme of "sdm845-camcc" is the > > better way to go. > > > > On the other hand there is cam_cc-sc7180. But it doesn't matter either > way, I will change it. > Ah, I only looked at sdm845 for prior art. Either is fine then. With this fixed & Vinods feedback, feel free to add my r-b. Reviewed-by: Robert Foss