From: Robert Foss <robert.foss@linaro.org>
To: Sia Jee Heng <jee.heng.sia@intel.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Jonas Karlman <jonas@kwiboo.se>,
Andrzej Hajda <a.hajda@samsung.com>,
pierre-louis.bossart@linux.intel.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: bridge: adv7511: Support I2S IEC958 encoded PCM format
Date: Fri, 19 Mar 2021 16:53:32 +0100 [thread overview]
Message-ID: <CAG3jFyuvTadeP-CLZ77k32vQvYVjrEakcXXr5U22Zgom=H34kg@mail.gmail.com> (raw)
In-Reply-To: <20210312085203.13556-1-jee.heng.sia@intel.com>
Hey Sia,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
On Fri, 12 Mar 2021 at 10:09, Sia Jee Heng <jee.heng.sia@intel.com> wrote:
>
> Support IEC958 encoded PCM format for ADV7511 so that ADV7511 HDMI
> audio driver can accept the IEC958 data from the I2S input.
>
> Signed-off-by: Sia Jee Heng <jee.heng.sia@intel.com>
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 +
> drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 6 ++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
> index a9bb734366ae..05e3abb5a0c9 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
> @@ -191,6 +191,7 @@
> #define ADV7511_I2S_FORMAT_I2S 0
> #define ADV7511_I2S_FORMAT_RIGHT_J 1
> #define ADV7511_I2S_FORMAT_LEFT_J 2
> +#define ADV7511_I2S_IEC958_DIRECT 3
>
> #define ADV7511_PACKET(p, x) ((p) * 0x20 + (x))
> #define ADV7511_PACKET_SDP(x) ADV7511_PACKET(0, x)
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> index 45838bd08d37..61f4a38e7d2b 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> @@ -101,6 +101,10 @@ static int adv7511_hdmi_hw_params(struct device *dev, void *data,
> case 20:
> len = ADV7511_I2S_SAMPLE_LEN_20;
> break;
> + case 32:
> + if (fmt->bit_fmt != SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE)
> + return -EINVAL;
> + fallthrough;
> case 24:
> len = ADV7511_I2S_SAMPLE_LEN_24;
> break;
> @@ -112,6 +116,8 @@ static int adv7511_hdmi_hw_params(struct device *dev, void *data,
> case HDMI_I2S:
> audio_source = ADV7511_AUDIO_SOURCE_I2S;
> i2s_format = ADV7511_I2S_FORMAT_I2S;
> + if (fmt->bit_fmt == SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE)
> + i2s_format = ADV7511_I2S_IEC958_DIRECT;
> break;
> case HDMI_RIGHT_J:
> audio_source = ADV7511_AUDIO_SOURCE_I2S;
>
> base-commit: de066e116306baf3a6a62691ac63cfc0b1dabddb
> --
> 2.18.0
>
prev parent reply other threads:[~2021-03-19 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 8:52 [PATCH] drm: bridge: adv7511: Support I2S IEC958 encoded PCM format Sia Jee Heng
2021-03-19 15:53 ` Robert Foss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG3jFyuvTadeP-CLZ77k32vQvYVjrEakcXXr5U22Zgom=H34kg@mail.gmail.com' \
--to=robert.foss@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jee.heng.sia@intel.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).