From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09547C433E6 for ; Wed, 13 Jan 2021 10:05:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B237B23437 for ; Wed, 13 Jan 2021 10:05:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727102AbhAMKFR (ORCPT ); Wed, 13 Jan 2021 05:05:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726989AbhAMKFP (ORCPT ); Wed, 13 Jan 2021 05:05:15 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0BD8C061786 for ; Wed, 13 Jan 2021 02:04:35 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id m6so935462pfk.1 for ; Wed, 13 Jan 2021 02:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wquRWJ+XSdWEkC1CKLlpx83RnASpvB9JfJs+0o8pqSw=; b=my4TThoY1QY04zJXin/7iCneXOx2awY7h5fcxmkmNVUKjCWvA6MfexjBCtKp16/Ub/ T3YGu1Yw78e2PmJKbPxJ0vc7mSZhq/IelGudOEcncdBpeDAkBSZEZ53KqDwAgxaHMhFa LCgdNbiaFQPt55lNXCZ6LBZZkT6Q+ZqYgR3aSkdp+VYLlyx1hR7m9Fa6BPeZQzMm1t/f D9eFAVELVgg66Z6DsRdmZajRpQihlEWm1aOGjg5dFXE7dZAU27DXfj4ak8XBtGE0zz8H aHWlcNh8jZkq6Q6Uxiq0cqciZnF1A8yaQDJtkHIOk9z4MXrmORuNE9lNLVYiT3I/haay DxqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wquRWJ+XSdWEkC1CKLlpx83RnASpvB9JfJs+0o8pqSw=; b=MoTgpU9147zFxQvem+YTHSUtT21wxbqD7HFDu1NRszwFtB8J2bcp6okBZF/kJ3Kq6D 8thX7Yz99ONdn4JYeiJ/gYF35qBABp7SScBatlkpm2NSfKn2YavDaW1YGqJ1HOpIQbUu w0uZwQEpkDdvZMTxEt1XwkD98eetbezU+cFhLAv3/fxcRdXDp1hanQni9GXEjPc12FhT uzmvBE8lnfhE1e3kbtXR7zhmdUnj/oVyxX08c6xXn0onT62LVUUpEvn/NO7hZKXiDere 3ZAhp6FnfnVcOdkWsnhhuRqKk0BUHwmQIXPoqGK5Fahd4Ep2jJmjRc3gmt1+cgsz0evJ bOcw== X-Gm-Message-State: AOAM530MRccvJ0Hm0SZ/pbYiNj5XqFsgX/dRRC0WJRUI6WlBBioOAq0T OjjQRAOAEWL4U1kXCmWzkUtlJnM0XMMXnrZWa8SOlw== X-Google-Smtp-Source: ABdhPJy4A6h7Yl1bmD5zFijMJFck5yvrhVoaKXZKAFR8qf0yCrO11pB7cjnmhRIPdpNASxw+lEjoEg5de41q+buNfTA= X-Received: by 2002:a63:e151:: with SMTP id h17mr1383808pgk.120.1610532275264; Wed, 13 Jan 2021 02:04:35 -0800 (PST) MIME-Version: 1.0 References: <20210108120429.895046-1-robert.foss@linaro.org> <20210108120429.895046-2-robert.foss@linaro.org> In-Reply-To: From: Robert Foss Date: Wed, 13 Jan 2021 11:04:24 +0100 Message-ID: Subject: Re: [PATCH v1 01/17] media: camss: Fix comment using wrong function name To: Bjorn Andersson Cc: Andy Gross , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, leoyang.li@nxp.com, geert+renesas@glider.be, arnd@arndb.de, Anson.Huang@nxp.com, michael@walle.cc, agx@sigxcpu.org, max.oss.09@gmail.com, linux-arm-msm@vger.kernel.org, linux-media , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , AngeloGioacchino Del Regno , Andrey Konovalov , Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Bj=C3=B6rn! On Fri, 8 Jan 2021 at 19:51, Bjorn Andersson w= rote: > > On Fri 08 Jan 06:04 CST 2021, Robert Foss wrote: > > > Function name is comment is wrong, and was changed to be > > the same as the actual function name. > > > > Signed-off-by: Robert Foss > > --- > > drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/me= dia/platform/qcom/camss/camss-vfe.c > > index fae2b513b2f9..478be4f0cab5 100644 > > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > > @@ -1077,7 +1077,7 @@ static void vfe_isr_wm_done(struct vfe_device *vf= e, u8 wm) > > } > > > > /* > > - * vfe_isr_wm_done - Process composite image done interrupt > > + * vfe_isr_comp_done - Process composite image done interrupt > > It's a function, so it should be "vfe_isr_comp_done()", but unless the > comment is denoted kerneldoc by starting with '/' followed by two '*' it > "doesn't matter". > > As a matter of fact, none of the kerneldoc in this file has the proper > '/**' start, so this file is "undocumented". > > So please add another '*' and some () throughout the file. Ack > > Regards, > Bjorn > > > * @vfe: VFE Device > > * @comp: Composite image id > > */ > > -- > > 2.27.0 > >