From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF537C433FE for ; Mon, 16 May 2022 14:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244463AbiEPOnw (ORCPT ); Mon, 16 May 2022 10:43:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239432AbiEPOnu (ORCPT ); Mon, 16 May 2022 10:43:50 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2F172DD4C for ; Mon, 16 May 2022 07:43:49 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id l7-20020a17090aaa8700b001dd1a5b9965so14592524pjq.2 for ; Mon, 16 May 2022 07:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4xPd51zy939NVBEotrgpcfDeP3YTrS+eiImf3uuWQYk=; b=URqpWG+tQCo0B0z+EiUx8eEm3LkP8jqdiCzJJcGqEyaaKqLZ6e9trHZgWE2mmdjirs +VXwK5XZcro7CBTFKTWEC6zNiU1BTFjOExDHzdZbLSaa0TyNnJEFYtSr9QOaJHCM+MrP h58HRtiLsFVtFuQiqScl44bLQ84bvYYaaQxZUut4P92muAa+1XeO7pKMeXSfhOTR8roX 4ZaI4G4xGiJqoH0SHf3OVf4bJbyPe5SJxUnwKCEs/PEu9DWq7s2aYtLyXWrldI8Zl+j0 Ov7NYS9s96FkukaTngcb5vLjzl7iPwCDXqK80r2Loho4mvlSCBTdzgOfnELR5tESFM8e AO4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4xPd51zy939NVBEotrgpcfDeP3YTrS+eiImf3uuWQYk=; b=DYlWGfMdUY8T7M9KOD5lXJ1YqNsgVVQfrfWOwlalaXTpffXbKAIy4646ILzg+6Zosx Wm+2Ny9Yo5eV9oa39u887oPqjU6fAwTcooIO/ZLKHeWwptr6DdIHn+xtwb7U4odM3WgV tuZHKg8SzIBg8wGxXms6ID2nb6lJC7kCWwvz4RYoVUeEBfGYJY3FIJEz8oCLihQnJpHC jUqrKYtsHSwjq6U2zUlk7Sy4TjtBV/NEW98gnc6GQmqDogAIZCeUj9QGhwgL0vrMZ8xA Em/g6UXpWgiHt2EvYGGHlW7c0jEGNiNGMwr0wErncNVeW4YLhkxeZG9EKD+rApLJG3oD VItw== X-Gm-Message-State: AOAM532BRvpHUDM7LWFgp1cngLCuyPelE5ReYxY2EFrxufH/GtdqlouU l+kBAhSoJvqAflyORAix8L1waKhHyvJMFp8Kx5qAQg== X-Google-Smtp-Source: ABdhPJyaT5uDQ4TotygR2N3udnaNMAmiSHsJCAkRMxVPOX+fzafhOA2wZgYN0W5QErhsEzGFMgAZujKPdTzdNUcQtHE= X-Received: by 2002:a17:90b:1e4e:b0:1dc:583c:398 with SMTP id pi14-20020a17090b1e4e00b001dc583c0398mr19832864pjb.232.1652712229263; Mon, 16 May 2022 07:43:49 -0700 (PDT) MIME-Version: 1.0 References: <20220509140439.1361352-1-yangyingliang@huawei.com> In-Reply-To: <20220509140439.1361352-1-yangyingliang@huawei.com> From: Robert Foss Date: Mon, 16 May 2022 16:43:38 +0200 Message-ID: Subject: Re: [PATCH] media: camss: csid: fix wrong size passed to devm_kmalloc_array() To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, bryan.odonoghue@linaro.org, vladimir.zapolskiy@linaro.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 May 2022 at 15:53, Yang Yingliang wrote: > > 'supplies' is a pointer, the real size of struct regulator_bulk_data > should be pass to devm_kmalloc_array(). > > Fixes: 0d8140179715 ("media: camss: Add regulator_bulk support") > Signed-off-by: Yang Yingliang > --- > drivers/media/platform/qcom/camss/camss-csid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c > index f993f349b66b..80628801cf09 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid.c > +++ b/drivers/media/platform/qcom/camss/camss-csid.c > @@ -666,7 +666,7 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid, > if (csid->num_supplies) { > csid->supplies = devm_kmalloc_array(camss->dev, > csid->num_supplies, > - sizeof(csid->supplies), > + sizeof(*csid->supplies), > GFP_KERNEL); > if (!csid->supplies) > return -ENOMEM; > -- > 2.25.1 > Reviewed-by: Robert Foss