LKML Archive on
 help / color / Atom feed
From: Jann Horn <>
To: Mauro Carvalho Chehab <>,
	Sakari Ailus <>
Cc: Linux Media Mailing List <>,
	kernel list <>,
	Linux-MM <>
Subject: mmap locking in atomisp staging driver looks bogus
Date: Wed, 23 Sep 2020 00:03:32 +0200
Message-ID: <> (raw)

I noticed this code in alloc_user_pages() in

 * Convert user space virtual address into pages list
static int alloc_user_pages(struct hmm_buffer_object *bo,
                            const void __user *userptr, bool cached)
        int page_nr;
        int i;
        struct vm_area_struct *vma;
        struct page **pages;

        pages = [...]
        vma = find_vma(current->mm, (unsigned long)userptr);
        if (!vma) {
                return -EFAULT;
         * Handle frame buffer allocated in other kerenl space driver
         * and map to user space
        if (vma->vm_flags & (VM_IO | VM_PFNMAP)) {
                page_nr = pin_user_pages((unsigned long)userptr, bo->pgnr,
                                         FOLL_LONGTERM | FOLL_WRITE,
                                         pages, NULL);
                bo->mem_type = HMM_BO_MEM_TYPE_PFN;
        } else {
                /*Handle frame buffer allocated in user space*/
                page_nr = get_user_pages_fast((unsigned long)userptr,
                                              (int)(bo->pgnr), 1, pages);

This code looks extremely dodgy to me. After
mmap_read_unlock(current->mm), the vma can be freed, and the following
access to vma->vm_flags can be a use-after-free. Also,
pin_user_pages() must be called with the mmap lock held, and you're
calling it without holding that lock.

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git
	git clone --mirror lkml/git/8.git
	git clone --mirror lkml/git/9.git
	git clone --mirror lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone