From: "dbasehore ." <dbasehore@chromium.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
jingoohan1@gmail.com, Lee Jones <lee.jones@linaro.org>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm_bl: Fix overflow condition
Date: Tue, 29 Aug 2017 11:45:43 -0700 [thread overview]
Message-ID: <CAGAzgsqp+ycY0Oj4OrfT=jq2OG82Efj2oQTuZhnzsZd-ApH8RQ@mail.gmail.com> (raw)
In-Reply-To: <20170829140534.GA18114@ulmo>
On Tue, Aug 29, 2017 at 7:05 AM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> On Mon, Aug 28, 2017 at 01:00:33PM -0700, Derek Basehore wrote:
>> This fixes and overflow condition that happens with a high value of
>> brightness-levels-scale by using a 64-bit variable. The issue would
>> prevent a range of higher brightness levels from being set.
>>
>> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
>> ---
>> drivers/video/backlight/pwm_bl.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
>> index 76311ec5e400..e7ffd2108acf 100644
>> --- a/drivers/video/backlight/pwm_bl.c
>> +++ b/drivers/video/backlight/pwm_bl.c
>> @@ -88,14 +88,17 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb)
>> static int compute_duty_cycle(struct pwm_bl_data *pb, int brightness)
>> {
>> unsigned int lth = pb->lth_brightness;
>> - int duty_cycle;
>> + s64 duty_cycle;
>>
>> if (pb->levels)
>> duty_cycle = pb->levels[brightness];
>> else
>> duty_cycle = brightness;
>>
>> - return (duty_cycle * (pb->period - lth) / pb->scale) + lth;
>> + duty_cycle *= pb->period - lth;
>> + do_div(duty_cycle, pb->scale);
>> +
>> + return duty_cycle + lth;
>> }
>
> I don't think your commit message accurately describes the change here.
> The overflow that you're preventing might happen with a large value of
> pb->period (or rather, in combination with a large value of duty_cycle)
> but it's unrelated to pb->scale.
I'm referring to the of property brightness-levels-scale. If there
aren't levels defined in a DTS, duty_cycle can be up to this value.
I'll change the CM to describe what's happening based on the variable
names from the function instead.
>
> Also, the semantics of do_div() are that it takes an unsigned dividend,
> so your duty_cycle should be a u64.
I'll change it.
>
> Thierry
next prev parent reply other threads:[~2017-08-29 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 20:00 [PATCH] pwm_bl: Fix overflow condition Derek Basehore
2017-08-29 14:05 ` Thierry Reding
2017-08-29 18:45 ` dbasehore . [this message]
2017-08-30 14:13 ` Thierry Reding
2017-08-29 20:27 Derek Basehore
2017-08-29 20:34 ` dbasehore .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGAzgsqp+ycY0Oj4OrfT=jq2OG82Efj2oQTuZhnzsZd-ApH8RQ@mail.gmail.com' \
--to=dbasehore@chromium.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).