From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5733C4742C for ; Thu, 5 Nov 2020 23:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4933D20704 for ; Thu, 5 Nov 2020 23:20:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VQr5C/I+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbgKEXUy (ORCPT ); Thu, 5 Nov 2020 18:20:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731060AbgKEXUx (ORCPT ); Thu, 5 Nov 2020 18:20:53 -0500 Received: from mail-yb1-xb43.google.com (mail-yb1-xb43.google.com [IPv6:2607:f8b0:4864:20::b43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57812C0613D2 for ; Thu, 5 Nov 2020 15:20:53 -0800 (PST) Received: by mail-yb1-xb43.google.com with SMTP id c129so2842295yba.8 for ; Thu, 05 Nov 2020 15:20:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8wFZyYqtSK1R4m/q7QRLFzt9lunj5huoU2docdk+JL4=; b=VQr5C/I+TFiFZ5SGKU1BeWphObfdjJTDj5xi0jFRSsliyimc1RaZmy7UsImMxmeFwx /h64JqNojRtsW8BCZc5+H+0Lkvcfr+JQiygd+PXcKPeHs07sxkiiMwMJ6ofbAHcgLlui eQO9PSZ4XzjFSiEPmAHbJ6IP8032bP54RzqZQzoyw4KK+2fBBP6/qiemKmzS9lXEe48G 98wXlcIhrJ2gawyLq7TEOaqZxP4IwKgwzodTpxxlY3vQbdEJsZ3ZhemZ1Cwq8J1cxUPI fvBIp8I6iZo5winR1KYZJN/o0I79n+h1fVGga1PX3HmfvT8Xj6x9RquXOd1wwzSazJ1I 32NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8wFZyYqtSK1R4m/q7QRLFzt9lunj5huoU2docdk+JL4=; b=QvSuEPGUIscQZZEpIli3Hi1fKyHmo7rFprSBe6V1vASpuSR7cnISFcjJFi1p/GoxI6 1zK9+o52CS8hU2IW7ckh7O/3tW8Eku/VS9G+sUn+XX9G7x9c/y1m9xP7jAaLCm79in4b HFm6/CvHoK6VyJ2fRV5tOQISURVySnAVjH7VfcjPxICkH371N/EL+IhaWEhm7yjbQB3U /5BMme9vkK8p9nSOGWafUv02Yo3ZfiuGaD9nucv8P9pGN9M2XzTeB0SyvG8crkct7Ycv m7strExgN89PJIM3d49ty3jQpi1TyxYQOE5lUAGXzsNxiJtfyishxfzgisWjaMXH4tz3 nPCg== X-Gm-Message-State: AOAM5325ZMGH5LEFMdsimymmFDZO1rEdQM1Li1JmkoaeJT3/iFpNT+ZY w4L0ubQ6+o1NAXI5NvulfkJ9kM1uSg8Bs6bITHXuFA== X-Google-Smtp-Source: ABdhPJwI8PTuLr/THqyxcoxyPhiBcXvDcwi5nHO4ERWE9lM50eQ300SCgVr+U1Wi7ljrzOM7oFCREm+TDa0BnbK69Y4= X-Received: by 2002:a25:268e:: with SMTP id m136mr6904500ybm.346.1604618452430; Thu, 05 Nov 2020 15:20:52 -0800 (PST) MIME-Version: 1.0 References: <20201104232356.4038506-1-saravanak@google.com> <20201104232356.4038506-8-saravanak@google.com> <20201105093604.GD3439341@kroah.com> In-Reply-To: <20201105093604.GD3439341@kroah.com> From: Saravana Kannan Date: Thu, 5 Nov 2020 15:20:16 -0800 Message-ID: Subject: Re: [PATCH v1 07/18] driver core: Add fwnode_init() To: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , Ard Biesheuvel , Rob Herring , Frank Rowand , Marc Zyngier , Thomas Gleixner , Tomi Valkeinen , Laurent Pinchart , Grygorii Strashko , Android Kernel Team , ACPI Devel Maling List , LKML , linux-efi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 5, 2020 at 1:35 AM Greg Kroah-Hartman wrote: > > On Wed, Nov 04, 2020 at 03:23:44PM -0800, Saravana Kannan wrote: > > There are multiple locations in the kernel where a struct fwnode_handle > > is initialized. Add fwnode_init() so that we have one way of > > initializing a fwnode_handle. > > > > Signed-off-by: Saravana Kannan > > --- > > drivers/acpi/property.c | 2 +- > > drivers/acpi/scan.c | 2 +- > > drivers/base/swnode.c | 2 +- > > drivers/firmware/efi/efi-init.c | 8 ++++---- > > include/linux/fwnode.h | 5 +++++ > > include/linux/of.h | 2 +- > > kernel/irq/irqdomain.c | 2 +- > > 7 files changed, 14 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c > > index d04de10a63e4..24e87b630573 100644 > > --- a/drivers/acpi/property.c > > +++ b/drivers/acpi/property.c > > @@ -76,7 +76,7 @@ static bool acpi_nondev_subnode_extract(const union acpi_object *desc, > > return false; > > > > dn->name = link->package.elements[0].string.pointer; > > - dn->fwnode.ops = &acpi_data_fwnode_ops; > > + fwnode_init(&dn->fwnode, &acpi_data_fwnode_ops); > > dn->parent = parent; > > INIT_LIST_HEAD(&dn->data.properties); > > INIT_LIST_HEAD(&dn->data.subnodes); > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > index a896e5e87c93..0ac19f9274b8 100644 > > --- a/drivers/acpi/scan.c > > +++ b/drivers/acpi/scan.c > > @@ -1589,7 +1589,7 @@ void acpi_init_device_object(struct acpi_device *device, acpi_handle handle, > > device->device_type = type; > > device->handle = handle; > > device->parent = acpi_bus_get_parent(handle); > > - device->fwnode.ops = &acpi_device_fwnode_ops; > > + fwnode_init(&device->fwnode, &acpi_device_fwnode_ops); > > acpi_set_device_status(device, sta); > > acpi_device_get_busid(device); > > acpi_set_pnp_ids(handle, &device->pnp, type); > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > > index 010828fc785b..4a4b2008fbc2 100644 > > --- a/drivers/base/swnode.c > > +++ b/drivers/base/swnode.c > > @@ -653,7 +653,7 @@ swnode_register(const struct software_node *node, struct swnode *parent, > > swnode->parent = parent; > > swnode->allocated = allocated; > > swnode->kobj.kset = swnode_kset; > > - swnode->fwnode.ops = &software_node_ops; > > + fwnode_init(&swnode->fwnode, &software_node_ops); > > > > ida_init(&swnode->child_ids); > > INIT_LIST_HEAD(&swnode->entry); > > diff --git a/drivers/firmware/efi/efi-init.c b/drivers/firmware/efi/efi-init.c > > index f55a92ff12c0..b148f1459fb3 100644 > > --- a/drivers/firmware/efi/efi-init.c > > +++ b/drivers/firmware/efi/efi-init.c > > @@ -359,9 +359,7 @@ static const struct fwnode_operations efifb_fwnode_ops = { > > .add_links = efifb_add_links, > > }; > > > > -static struct fwnode_handle efifb_fwnode = { > > - .ops = &efifb_fwnode_ops, > > -}; > > +static struct fwnode_handle efifb_fwnode; > > > > static int __init register_gop_device(void) > > { > > @@ -375,8 +373,10 @@ static int __init register_gop_device(void) > > if (!pd) > > return -ENOMEM; > > > > - if (IS_ENABLED(CONFIG_PCI)) > > + if (IS_ENABLED(CONFIG_PCI)) { > > + fwnode_init(&efifb_fwnode, &efifb_fwnode_ops); > > pd->dev.fwnode = &efifb_fwnode; > > + } > > > > err = platform_device_add_data(pd, &screen_info, sizeof(screen_info)); > > if (err) > > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h > > index e0abafbb17f8..593fb8e58f21 100644 > > --- a/include/linux/fwnode.h > > +++ b/include/linux/fwnode.h > > @@ -169,6 +169,11 @@ struct fwnode_operations { > > (fwnode)->ops->op(fwnode, ## __VA_ARGS__); \ > > } while (false) > > #define get_dev_from_fwnode(fwnode) get_device((fwnode)->dev) > > +static inline void fwnode_init(struct fwnode_handle *fwnode, > > + const struct fwnode_operations *ops) > > +{ > > + fwnode->ops = ops; > > +} > > > > A blank line before a new inline function is always nice to have :) > Ack -Saravana