From: Saravana Kannan <saravanak@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: Android Kernel Team <kernel-team@android.com>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v1 0/3] of_devlink: Minor fixes and new properties
Date: Wed, 6 Nov 2019 21:53:40 -0800 [thread overview]
Message-ID: <CAGETcx-X4OTrGfBkP6CtC6=GV=KA147VO6jJL+o6hkC1iCkeeA@mail.gmail.com> (raw)
In-Reply-To: <20191105065000.50407-1-saravanak@google.com>
On Mon, Nov 4, 2019 at 10:50 PM Saravana Kannan <saravanak@google.com> wrote:
>
> Sending again since the cover letter missed everyone/mailing lists.
>
> First two patches are just code clean up and logging with no functional
> difference. The 3rd patch adds support for the following DT properties:
> iommus, mboxes and io-channels.
>
> These patches are on top of driver-core-next since that's where the rest
> of the of_devlink patches are.
>
> Greg and Rob,
> On a side note, I was wondering if I should rename the of_devlink kernel
> command line to fw_devlink and move it out of drivers/of/property.c and
> into drivers/base/core.c. This feature isn't really limited to
> devicetree, so I don't see a need to have devicetree specific kernel
> command line option. Please let me know if that sounds okay to you.
Hi Rob,
Thanks for the reviews. Can you let me know what you think of this too?
Rob/Greg,
If I rename of_devlink to fw_devlink, I might also make it a setting
like fw_devlink=none/permissive/enforce
- none would be same as disabled completely.
- permissive would use SYNC_STATE_ONLY for all device links created by
firmware. So it won't block any probes even with cycles but
sync_state() will still work correctly.
- enforce would be the current "of_devlinkg=1" behavior where direct
dependencies would block probing and the child dependencies would use
SYNC_STATE_ONLY.
-Saravana
next prev parent reply other threads:[~2019-11-07 5:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 6:49 [PATCH v1 0/3] of_devlink: Minor fixes and new properties Saravana Kannan
2019-11-05 6:49 ` [PATCH v1 1/3] of: property: Minor style clean up of of_link_to_phandle() Saravana Kannan
2019-11-07 0:42 ` Rob Herring
2019-11-05 6:49 ` [PATCH v1 2/3] of: property: Make it easy to add device links from DT properties Saravana Kannan
2019-11-07 0:42 ` Rob Herring
2019-11-05 6:50 ` [PATCH v1 3/3] of: property: Add device link support for iommus, mboxes and io-channels Saravana Kannan
2019-11-07 0:42 ` Rob Herring
2019-11-07 5:53 ` Saravana Kannan [this message]
2019-11-07 8:40 ` [PATCH v1 0/3] of_devlink: Minor fixes and new properties Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGETcx-X4OTrGfBkP6CtC6=GV=KA147VO6jJL+o6hkC1iCkeeA@mail.gmail.com' \
--to=saravanak@google.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).