From: Saravana Kannan <saravanak@google.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
John Stultz <john.stultz@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH v3 4/4] regulator: core: Add voltage support for sync_state() callbacks
Date: Mon, 20 Jul 2020 20:24:59 -0700 [thread overview]
Message-ID: <CAGETcx89xBoLiqe2392_vFuoMytKMxbeM5n0vdL9dJvAF25+Qg@mail.gmail.com> (raw)
In-Reply-To: <20200720143533.GG4601@sirena.org.uk>
On Mon, Jul 20, 2020 at 7:35 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Jul 15, 2020 at 09:20:53PM -0700, Saravana Kannan wrote:
>
> > - if (!handoff)
> > + if (!handoff) {
> > regulator_disable(rdev->boot_limits);
> > - else
> > + regulator_set_voltage(rdev->boot_limits, 0, INT_MAX);
> > + } else {
> > rdev->use_count--;
> > + }
> > destroy_regulator(rdev->boot_limits);
>
> These sets should be completely redundant since they will go away when
> the regulator is destroyed, if there's an issue with that we should fix
> it rather than bodging around it.
Yeah, I was aware of this, but I thought it was clearer to have an
explicit unwinding. Since you prefer the other way around, I can drop
the set voltage.
Btw, going a tangent, why is regulator_set_voltage() not dependent on
a consumer's regulator enable request? If they don't care if the
regulator goes off, do they really care if the voltage goes lower?
What's the reason behind not tying voltage request with the enable
request?
-Saravana
next prev parent reply other threads:[~2020-07-21 3:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 4:20 [PATCH v3 0/4] regulator_sync_state() support Saravana Kannan
2020-07-16 4:20 ` [PATCH v3 1/4] driver core: Add dev_set_drv_sync_state() Saravana Kannan
2020-07-16 4:20 ` [PATCH v3 2/4] regulator: core: Add destroy_regulator() Saravana Kannan
2020-07-16 4:20 ` [PATCH v3 3/4] regulator: core: Add basic enable/disable support for sync_state() callbacks Saravana Kannan
2020-07-20 14:27 ` Mark Brown
2020-07-21 3:22 ` Saravana Kannan
2020-07-21 20:18 ` Mark Brown
2020-07-28 21:14 ` Saravana Kannan
2020-08-04 21:10 ` Mark Brown
2020-08-25 19:58 ` Mark Brown
2020-07-16 4:20 ` [PATCH v3 4/4] regulator: core: Add voltage " Saravana Kannan
2020-07-20 14:35 ` Mark Brown
2020-07-21 3:24 ` Saravana Kannan [this message]
2020-07-21 12:19 ` Mark Brown
2020-07-21 3:29 ` [PATCH v3 0/4] regulator_sync_state() support Saravana Kannan
2020-07-22 0:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGETcx89xBoLiqe2392_vFuoMytKMxbeM5n0vdL9dJvAF25+Qg@mail.gmail.com \
--to=saravanak@google.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).