From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D574C4320A for ; Thu, 2 Sep 2021 00:26:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2BDE6101B for ; Thu, 2 Sep 2021 00:26:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243674AbhIBA1N (ORCPT ); Wed, 1 Sep 2021 20:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239492AbhIBA1K (ORCPT ); Wed, 1 Sep 2021 20:27:10 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2835EC061757 for ; Wed, 1 Sep 2021 17:26:13 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id f4so403876ybr.5 for ; Wed, 01 Sep 2021 17:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CptstpGZORRU3IsYIloJqbWhHikn1ckNwph+iIdtJfc=; b=KJjMgyWgDPZNVmsiSfXPstCqx7Cv6leimA38DXhaRdLHgyAnsFQrjHt5ji8iOVTbaA K/+uGl//sF7mIvLXtsuE92k6eG5U+dy3GZ+oVW5XzrjScobDwvvsiSrtBO9GXNkewxjN Wb4kAJ1sQkkdxizNHuKxTPyi0oh7Ccc+XWqK44z7O7FrhKmQrhHa6y/+XZxEWgi71gLK LFPjnoZfSqrcj5rPjIszQqV6/+V975nET3m3NtDKJeGpVm2ZfhjlPazmkz5SxlSwwBBy pLV1HyflZQcD1QY6xA9bQAplBzgYykH1koRMFXZHxiYlYOREMG2We6WDhMRhloCJDn4Y 6EzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CptstpGZORRU3IsYIloJqbWhHikn1ckNwph+iIdtJfc=; b=rk/8psieJ5m6Gk1LpvWn0zzxa2oJ/J5XE8g4P5bkiuMzJejEGTZhr4UeEyJ2F7PZq0 3gqQtrAbSD/qwSLmN10QYwMCQakYuhSnytn6iuMa2+Q6kjWp8VH14UJY+EiCUdiPqLs8 Y50XAIvf3iaxlZPRpsPEcF6LIbkCpxTpHc7tZNc3XJSYtza38Sq5L2YoB/ir2U3MaWtz iTZgzsQCdNasdCYaI7bBX3Yn+ihTcYBN4OtlqKT3aNNkZD6eOXq+PKqyJSxuXyCmhiSC a9UWdbrt5C9uNSozQcQUEmhyZRi5koiNli486Fpu4vco204f73U18MCZ8hXBwiwxeifx roDA== X-Gm-Message-State: AOAM533uEle50V8xJU0ps57H9e6Qz9JnHeffoGrjBpy5h9qh5PeJEwil +ru8kQ47NV/t+tms/NkwCZKibuPjgbLS4ihWW6bqag== X-Google-Smtp-Source: ABdhPJw0MkZntzwLYBweF0Y7lXR0WTz8ODY0CF4jq3sidmXEVfKh7AZHfVBv/CowSJpHE/7wcb+BsIsyLaB/P+vFGA8= X-Received: by 2002:a25:804:: with SMTP id 4mr733936ybi.346.1630542372170; Wed, 01 Sep 2021 17:26:12 -0700 (PDT) MIME-Version: 1.0 References: <20210831102125.624661-1-ulf.hansson@linaro.org> In-Reply-To: From: Saravana Kannan Date: Wed, 1 Sep 2021 17:25:36 -0700 Message-ID: Subject: Re: [PATCH 1/2] of: property: fw_devlink: Rename 'node_not_dev' to 'optional_con_dev' To: Ulf Hansson Cc: Rob Herring , DTML , "Rafael J . Wysocki" , Stephen Boyd , Dmitry Osipenko , Linux PM , Linux Kernel Mailing List , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 1, 2021 at 3:24 PM Ulf Hansson wrote: > > On Thu, 2 Sept 2021 at 00:06, Saravana Kannan wrote: > > > > On Wed, Sep 1, 2021 at 2:27 PM Ulf Hansson wrote: > > > > > > On Wed, 1 Sept 2021 at 22:56, Saravana Kannan wrote: > > > > > > > > On Wed, Sep 1, 2021 at 12:45 AM Ulf Hansson wrote: > > > > > > > > > > On Tue, 31 Aug 2021 at 19:31, Saravana Kannan wrote: > > > > > > > > > > > > On Tue, Aug 31, 2021 at 3:21 AM Ulf Hansson wrote: > > > > > > > > > > > > > > In the struct supplier_bindings the member 'node_not_dev' is described as > > > > > > > "The consumer node containing the property is never a device.", but that > > > > > > > doesn't match the behaviour of the code in of_link_property(). > > > > > > > > > > > > > > To make the behaviour consistent with the description, let's rename the > > > > > > > member to "optional_con_dev" and clarify the corresponding comment. > > > > > > > > > > > > > > Signed-off-by: Ulf Hansson > > > > > > > --- > > > > > > > drivers/of/property.c | 9 +++++---- > > > > > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > > > > > > index 6c028632f425..2babb1807228 100644 > > > > > > > --- a/drivers/of/property.c > > > > > > > +++ b/drivers/of/property.c > > > > > > > @@ -1249,7 +1249,8 @@ static struct device_node *parse_##fname(struct device_node *np, \ > > > > > > > * @parse_prop.index: For properties holding a list of phandles, this is the > > > > > > > * index into the list > > > > > > > * @optional: Describes whether a supplier is mandatory or not > > > > > > > - * @node_not_dev: The consumer node containing the property is never a device. > > > > > > > + * @optional_con_dev: The consumer node containing the property may not be a > > > > > > > + * device, then try finding one from an ancestor node. > > > > > > > > > > > > Nak. This flag is not about "may not be". This is explicitly for > > > > > > "never a device". It has to do with stuff like remote-endpoint which > > > > > > is never listed under the root node of the device node. Your > > > > > > documentation change is changing the meaning of the flag. > > > > > > > > > > Okay, fair enough. > > > > > > > > > > Although, as stated in the commit message this isn't the way code > > > > > behaves. Shouldn't we at least make the behaviour consistent with the > > > > > description of the 'node_not_dev' flag? > > > > > > > > I know what you mean, but if you use the flag correctly (where the > > > > phandle pointed to will never be a device with compatible property), > > > > the existing code would work correctly. And since the flag is relevant > > > > only in this file, it's easy to keep it correct. I'd just leave it as > > > > is. > > > > > > Sorry, but that just sounds lazy to me, I am sure we can do better. > > > The current code and the name of the flag is confusing, at least to me > > > (and I bet to others as well). > > > > > > Moreover, I don't quite understand your objections to changing this. > > > Why leave this to be inconsistent when it can be easily fixed? > > > > If you feel so strong about it, go for it. No strong objections. Just > > double check the refcounts are done correctly. > > The refcounts should be okay, I think. > > I am fine with either of the two suggestions I have made. The one I Nak-ed earlier is not okay. So I think we have only one other option. > But another > option could be to come up with an alternative name (and a > description) for the flag, instead of "optional_con_dev", if you > perhaps have a better suggestion? It's not fully clear to me what part of node_not_dev is confusing, but I'll take a stab at it. How about: - * @node_not_dev: The consumer node containing the property is never a device. + * @con_node_never_dev: The consumer node containing the property is never + * converted to a struct device. The struct device will be + * created for one of the ancestor nodes, which fw_devlink + * assumes would an ancestor with the compatible property. If you are happy with this, then go ahead and use this name/comment with the last code suggestion you made and send out a patch? Thanks, Saravana