linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saravana Kannan <saravanak@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH 0/6] device.h: split up into smaller pieces
Date: Mon, 9 Dec 2019 11:52:50 -0800	[thread overview]
Message-ID: <CAGETcx8s4KCP=ZiYuU6oEpSrzgUyV4JeXpVKxXcWeiNiKgYKKA@mail.gmail.com> (raw)
In-Reply-To: <20191209193303.1694546-1-gregkh@linuxfoundation.org>

On Mon, Dec 9, 2019 at 11:33 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> During the 5.4-rc merge Linus complained about the size of device.h and
> how it can be a pain to merge things into at times.  It's also become
> kind of a "kitchen sink" for anything related to drivers / devices /
> busses / classes and is the 10th largest include/linux/*.h file by size.
>
> So let's split it up into smaller pieces, moving things out by logical
> parts where it can be.

Yes please! Took a cursory look at the series (except 1/6) and it
looks okay to me. However, didn't check for copy-pastas or anything
that was left in device.h that could have been moved out. I'll try to
do the latter, later.

-Saravana

> Greg Kroah-Hartman (6):
>   drivers/base: base.h: add proper copyright and header info
>   device.h: move devtmpfs prototypes out of the file
>   device.h: move dev_printk()-like functions to dev_printk.h
>   device.h: move 'struct bus' stuff out to device/bus.h
>   device.h: move 'struct class' stuff out to device/class.h
>   device.h: move 'struct driver' stuff out to device/driver.h
>
>  drivers/base/base.h           |  19 +
>  drivers/base/bus.c            |   1 +
>  drivers/base/class.c          |   1 +
>  drivers/base/driver.c         |   1 +
>  include/linux/dev_printk.h    | 235 ++++++++
>  include/linux/device.h        | 999 +---------------------------------
>  include/linux/device/bus.h    | 288 ++++++++++
>  include/linux/device/class.h  | 266 +++++++++
>  include/linux/device/driver.h | 292 ++++++++++
>  init/main.c                   |   2 +-
>  10 files changed, 1108 insertions(+), 996 deletions(-)
>  create mode 100644 include/linux/dev_printk.h
>  create mode 100644 include/linux/device/bus.h
>  create mode 100644 include/linux/device/class.h
>  create mode 100644 include/linux/device/driver.h
>
> --
> 2.24.0
>

      parent reply	other threads:[~2019-12-09 19:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 19:32 [PATCH 0/6] device.h: split up into smaller pieces Greg Kroah-Hartman
2019-12-09 19:32 ` [PATCH 1/6] drivers/base: base.h: add proper copyright and header info Greg Kroah-Hartman
2019-12-09 19:32 ` [PATCH 2/6] device.h: move devtmpfs prototypes out of the file Greg Kroah-Hartman
2019-12-09 19:33 ` [PATCH 3/6] device.h: move dev_printk()-like functions to dev_printk.h Greg Kroah-Hartman
2019-12-09 19:33 ` [PATCH 4/6] device.h: move 'struct bus' stuff out to device/bus.h Greg Kroah-Hartman
2019-12-09 19:33 ` [PATCH 5/6] device.h: move 'struct class' stuff out to device/class.h Greg Kroah-Hartman
2019-12-09 19:33 ` [PATCH 6/6] device.h: move 'struct driver' stuff out to device/driver.h Greg Kroah-Hartman
2019-12-09 19:52 ` Saravana Kannan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGETcx8s4KCP=ZiYuU6oEpSrzgUyV4JeXpVKxXcWeiNiKgYKKA@mail.gmail.com' \
    --to=saravanak@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).