From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74D6C4320E for ; Tue, 31 Aug 2021 22:19:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C065C60F56 for ; Tue, 31 Aug 2021 22:19:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240361AbhHaWUM (ORCPT ); Tue, 31 Aug 2021 18:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230286AbhHaWUK (ORCPT ); Tue, 31 Aug 2021 18:20:10 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA1ABC061760 for ; Tue, 31 Aug 2021 15:19:12 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id c206so1260722ybb.12 for ; Tue, 31 Aug 2021 15:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ifV99n/y4cMpRleJnGxlR5krF8hXhCt0QnPJskXH/G0=; b=mXJaohfgLRAZziAeXw3DoxsqQIdvxruf11ejCdzwmE0bs3LkUlvm2Sna4RscCQnUR4 AqbiUWI7waAxZ1hgjaqjxPYnn5+b4sFqkIae4BITOse4wTvFXrYi8i20hjCA+fO6qXvq Zuro6Lpn8jaAWVY+QDqfrfE9j+ewxqZ/DnQBgu7sXBmzy+5Qg93mtmXhS9lFoa55bGjO OZ3q+D7NvlTUP5Qr4uYIgAP1BFmClydC5ArXAQsF/XrcIGReU1f1etpuOT8pRsNmV5Fp U3x1q1IzX070pGvOHBz1IH6oA/pV5JcCIX557TQ732/KpzmGalXoOS0jCfOX/FjnCylV r2pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ifV99n/y4cMpRleJnGxlR5krF8hXhCt0QnPJskXH/G0=; b=rIeYSNsfPPuF8km4RyFLpgSto5DM7/c2T59n8QDlacfKc0Vq5e2imJ54fDVEEfaWJn yVy6tUt+mGTCYAxYou38Q11/d42kH1bEXQajf/3x/bMpCWyrkSOT1C3p5yZ6dbCm90lL GEvi1kprgaiU6+bUrWDoFIomJpP+MmTiaLssV/7MSW/+7KbLIDUDqe0XPETxAhsszwZ9 /RIUUAlHRSqgHgTzZkbrw+Lwt/EQf0PmgEVw2Zli6dYSMxBCup2+MpiwG6SjheqjVzMd +h0FD1yMgfL6j1sFG4jSnEnNj4Mso4w8VzUiFTFEdn1OKBU6qc2pkWQ8bDYMAuvFYHbh o5DA== X-Gm-Message-State: AOAM532opT7+Cps+vg6G7z/d3nBdX6YbdZil4cQpvYP+Mxr+x7kXh4JY SiScqeU9k4h9No+RGP13jCaPBGN1j3kgBN7zx4hU9g== X-Google-Smtp-Source: ABdhPJwW9LbiOWC7XzKXLV28krpS8gQQ6Glcr3p9SZV4SwiLgXqANwTnPYLfnyyap+XYJ5EC1woQrg3C6IAb9PbINrk= X-Received: by 2002:a25:6746:: with SMTP id b67mr35157317ybc.96.1630448351690; Tue, 31 Aug 2021 15:19:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Saravana Kannan Date: Tue, 31 Aug 2021 15:18:35 -0700 Message-ID: Subject: Re: [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT To: Andrew Lunn Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Linus Walleij , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Len Brown , Alvin Sipraga , kernel-team@android.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 31, 2021 at 3:06 PM Andrew Lunn wrote: > > On Tue, Aug 31, 2021 at 12:26:30PM -0700, Saravana Kannan wrote: > > On Tue, Aug 31, 2021 at 6:16 AM Andrew Lunn wrote: > > > > > > > > I must admit, my main problem at the moment is -rc1 in two weeks > > > > > time. It seems like a number of board with Ethernet switches will be > > > > > broken, that worked before. phy-handle is not limited to switch > > > > > drivers, it is also used for Ethernet drivers. So it could be, a > > > > > number of Ethernet drivers are also going to be broken in -rc1? > > > > > > > > Again, in those cases, based on your FEC example, fw_devlink=on > > > > actually improves things. > > > > > > Debatable. I did some testing. As expected some boards with Ethernet > > > switches are now broken. > > > > To clarify myself, I'm saying the patch to parse "ethernet" [8] will > > make things better with fw_devlink=on for FEC. Not sure if you tested > > that patch or not. > > Yes and no. I was tested with the FEC, but because of fw_devlink=on, > the switches don't probe correctly. So it is not possible to see if it > helped or not, since its plain broken. > > > Not sure what was the tip of the tree with which you bisected. > > I manually tested linux-next, v5.14, v5.13 and v5.12 and then > bisected: > > $ git bisect log > git bisect start > # good: [9f4ad9e425a1d3b6a34617b8ea226d56a119a717] Linux 5.12 > git bisect good 9f4ad9e425a1d3b6a34617b8ea226d56a119a717 > # bad: [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13 > > So well away from linux-next which contains the phy-handle parser. > > I will try to give the two patches a try today or tomorrow. If the switches are broken without the phy-handle or ethernet change, I'm not sure if the "BROKEN_PARENT" patch would help. > > > Thanks for testing it out. And worst case, we'll revert phy-handle > > support. > > Which is not enough to fix these Ethernet switches. Ok, if you can give more specifics on this, I'll look into it. I'd need: 1) The DTS file that you see the issue on. 2) The devices that don't probe when you have the issue (you can find these in /sys/kernel/debug/devices_deferred) 3) And if possible boot logs with dev_dbg changed to dev_info in device_link_add() and device_links_check_suppliers() Thanks, Saravana