From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 244DCC1B0D8 for ; Mon, 7 Dec 2020 19:27:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE5C5238A0 for ; Mon, 7 Dec 2020 19:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbgLGT1C (ORCPT ); Mon, 7 Dec 2020 14:27:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbgLGT1B (ORCPT ); Mon, 7 Dec 2020 14:27:01 -0500 Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC68AC061257 for ; Mon, 7 Dec 2020 11:25:52 -0800 (PST) Received: by mail-yb1-xb41.google.com with SMTP id j17so5912709ybt.9 for ; Mon, 07 Dec 2020 11:25:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8+tZQPXNlLpNRwKXrGfU0wAdVOOOImfIsinmDNKvGmE=; b=iu6kvgbq9TtuxPwNho0xw8fX1TKCuQz9gfrzrRgd+PsL1XOXTPo5mUC/cMlKU2VfdH x/FL5NxtSdnKNZrLOnsFmCiBYrNUiF9WvMOZUy/qX0ns3pqWKDxVqr4IBiyIotqUJw+r nA8JmUpC+H3vRtBZQSIpWYwGtx9Mv29ZtXVIIGsCAjgQCL8NRRZRQhho00b2w9yG7elN Sv6UB2LtyZsRF8bsvy7lGjTmNVkxJeS32HJogTbtZBtlKO3pkhHD59i041ecAHyLHt80 ZqHgPS52tWFFjvpicGK4A3msh3uPdMWvt/QfgZ65tqRzW4VGR5vY/H9D9j2H3LH92LTS bSeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8+tZQPXNlLpNRwKXrGfU0wAdVOOOImfIsinmDNKvGmE=; b=NsKEv/3/JJVldwq5q9hASO6Q5DgabXc/OYcP4KRcAib4XszZUmWT/Qun809dOrqCB2 D1E+oYmvNkaCGhUH0cOtc0iyHhTApWmuozNZmnmCBiSfbuayd9ONjPJaruKvM+MCTeZ5 CtCsPxG9AYLHTO8jL0O0v0qIH5NiZh9TG5216a5Uv9E6nbfbta7mglcmrflxLtV7Ejjz zvdgR3FhG+tE5YFfTGmYNTFF8HgXqsB/aOZxZy1deGpOIdo6LdrvGr1j153qZbsxGzMr Eb9mgdvtYiWuWfDWugn3tWf3T943tjz60dTwZl5g1PEDY2AK5XxEGfMOcoDT8GYclPUY 60bA== X-Gm-Message-State: AOAM532kvSbYJBaIMyuQwyJ9OQzpvzVoFttv59pzhG0VvVlozG3tXwQ5 PWcyBJufhBdXBQgwZ0TkEltxpwzEx+uEoBYMU3R05A== X-Google-Smtp-Source: ABdhPJzT6cEkqAvkPYLZ7+/FjCSHl+b/WvFb3DgdXgVmc9Zg+YwA95J3KT2qIX7KYt319m5Xqp/eqxxrhX05Qw/wqqY= X-Received: by 2002:a5b:bc8:: with SMTP id c8mr24563420ybr.228.1607369151841; Mon, 07 Dec 2020 11:25:51 -0800 (PST) MIME-Version: 1.0 References: <20201121020232.908850-1-saravanak@google.com> <20201121020232.908850-8-saravanak@google.com> <20201206072621.GA687065@unreal> In-Reply-To: <20201206072621.GA687065@unreal> From: Saravana Kannan Date: Mon, 7 Dec 2020 11:25:15 -0800 Message-ID: Subject: Re: [PATCH v2 07/17] driver core: Add fwnode_init() To: Leon Romanovsky Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Ard Biesheuvel , Rob Herring , Frank Rowand , Marc Zyngier , Thomas Gleixner , Tomi Valkeinen , Laurent Pinchart , Grygorii Strashko , Android Kernel Team , ACPI Devel Maling List , LKML , linux-efi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 5, 2020 at 11:26 PM Leon Romanovsky wrote: > > On Fri, Nov 20, 2020 at 06:02:22PM -0800, Saravana Kannan wrote: > > There are multiple locations in the kernel where a struct fwnode_handle > > is initialized. Add fwnode_init() so that we have one way of > > initializing a fwnode_handle. > > > > Signed-off-by: Saravana Kannan > > --- > > drivers/acpi/property.c | 2 +- > > drivers/acpi/scan.c | 2 +- > > drivers/base/swnode.c | 2 +- > > drivers/firmware/efi/efi-init.c | 8 ++++---- > > include/linux/fwnode.h | 6 ++++++ > > include/linux/of.h | 2 +- > > kernel/irq/irqdomain.c | 2 +- > > 7 files changed, 15 insertions(+), 9 deletions(-) > > In this series, I didn't find any extension of fwnode_init() to be it more > than simple assignment. This change looks to me like unnecessary churn and > obfuscation rather than improvement. > > "...ops = &...;" is pretty standard in the kernel to initialize ops > structures. Subsequent patches make fwnode_init() do more stuff. -Saravana