From: Saravana Kannan <saravanak@google.com>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Georgi Djakov <georgi.djakov@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
"Sweeney, Sean" <seansw@qti.qualcomm.com>,
David Dai <daidavid1@codeaurora.org>,
adharmap@codeaurora.org, Rajendra Nayak <rnayak@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Evan Green <evgreen@chromium.org>,
Android Kernel Team <kernel-team@android.com>,
Linux PM <linux-pm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/3] OPP: Add support for bandwidth OPP tables
Date: Tue, 7 Jan 2020 22:16:24 -0800 [thread overview]
Message-ID: <CAGETcx9Or==EEL6jRMEh4bG4cmFmLqk_n1ReKT=cg-MEsL9w0w@mail.gmail.com> (raw)
In-Reply-To: <c701fe1d94631e3aba92a8c80070c6a4@codeaurora.org>
On Tue, Jan 7, 2020 at 11:28 AM Sibi Sankar <sibis@codeaurora.org> wrote:
>
> Hey Saravana,
>
> Spent some time testing this series while
> trying out dcvs on SDM845/SC7180. Apart from
> the few minor issues it works quite well!
Thanks a lot for testing Sibi. Can you give a tested-by? Glad to hear
it works well.
> On 2019-12-07 05:54, Saravana Kannan wrote:
> > Not all devices quantify their performance points in terms of
> > frequency.
> > Devices like interconnects quantify their performance points in terms
> > of
> > bandwidth. We need a way to represent these bandwidth levels in OPP.
> > So,
> > add support for parsing bandwidth OPPs from DT.
> >
> > Signed-off-by: Saravana Kannan <saravanak@google.com>
> > ---
> > drivers/opp/core.c | 15 +++++++++--
> > drivers/opp/of.c | 63 ++++++++++++++++++++++++++++++++--------------
> > drivers/opp/opp.h | 5 ++++
> > 3 files changed, 62 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> > index be7a7d332332..c79bbfac7289 100644
> > --- a/drivers/opp/core.c
> > +++ b/drivers/opp/core.c
> > @@ -1282,11 +1282,21 @@ static bool
> > _opp_supported_by_regulators(struct dev_pm_opp *opp,
> > return true;
> > }
> >
> > +int opp_compare_key(struct dev_pm_opp *opp1, struct dev_pm_opp *opp2)
> > +{
> > + if (opp1->rate != opp2->rate)
> > + return opp1->rate < opp2->rate ? -1 : 1;
> > + if (opp1->peak_bw != opp2->peak_bw)
> > + return opp1->peak_bw < opp2->peak_bw ? -1 : 1;
> > + return 0;
> > +}
> > +
> > static int _opp_is_duplicate(struct device *dev, struct dev_pm_opp
> > *new_opp,
> > struct opp_table *opp_table,
> > struct list_head **head)
> > {
> > struct dev_pm_opp *opp;
> > + int opp_cmp;
> >
> > /*
> > * Insert new OPP in order of increasing frequency and discard if
> > @@ -1297,12 +1307,13 @@ static int _opp_is_duplicate(struct device
> > *dev, struct dev_pm_opp *new_opp,
> > * loop.
> > */
> > list_for_each_entry(opp, &opp_table->opp_list, node) {
> > - if (new_opp->rate > opp->rate) {
> > + opp_cmp = opp_compare_key(new_opp, opp);
> > + if (opp_cmp > 0) {
> > *head = &opp->node;
> > continue;
> > }
> >
> > - if (new_opp->rate < opp->rate)
> > + if (opp_cmp < 0)
> > return 0;
> >
> > /* Duplicate OPPs */
> > diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> > index 1cbb58240b80..b565da5a2b1f 100644
> > --- a/drivers/opp/of.c
> > +++ b/drivers/opp/of.c
> > @@ -521,6 +521,44 @@ void dev_pm_opp_of_remove_table(struct device
> > *dev)
> > }
> > EXPORT_SYMBOL_GPL(dev_pm_opp_of_remove_table);
> >
> > +static int _read_opp_key(struct dev_pm_opp *new_opp, struct
> > device_node *np,
> > + bool *rate_not_available)
> > +{
> > + int ret;
> > + u64 rate;
> > + u32 bw;
> > +
> > + ret = of_property_read_u64(np, "opp-hz", &rate);
> > + if (!ret) {
> > + /*
> > + * Rate is defined as an unsigned long in clk API, and so
> > + * casting explicitly to its type. Must be fixed once rate is 64
> > + * bit guaranteed in clk API.
> > + */
> > + new_opp->rate = (unsigned long)rate;
> > + goto out;
> > + }
> > +
> > + ret = of_property_read_u32(np, "opp-peak-kBps", &bw);
> > + if (!ret) {
> > + new_opp->peak_bw = bw;
> > +
> > + if (!of_property_read_u32(np, "opp-avg-kBps", &bw))
> > + new_opp->avg_bw = bw;
> > + }
> > +
> > +out:
> > + *rate_not_available = !!ret;
> > + /*
> > + * If ret is 0 at this point, we have already found a key. If we
> > + * haven't found a key yet, then ret already has an error value. In
> > + * either case, we don't need to update ret.
> > + */
> > + of_property_read_u32(np, "opp-level", &new_opp->level);
> > +
> > + return ret;
> > +}
> > +
> > /**
> > * _opp_add_static_v2() - Allocate static OPPs (As per 'v2' DT
> > bindings)
> > * @opp_table: OPP table
> > @@ -558,26 +596,12 @@ static struct dev_pm_opp
> > *_opp_add_static_v2(struct opp_table *opp_table,
> > if (!new_opp)
> > return ERR_PTR(-ENOMEM);
> >
> > - ret = of_property_read_u64(np, "opp-hz", &rate);
> > - if (ret < 0) {
> > - /* "opp-hz" is optional for devices like power domains. */
> > - if (!opp_table->is_genpd) {
> > - dev_err(dev, "%s: opp-hz not found\n", __func__);
> > - goto free_opp;
> > - }
> > -
> > - rate_not_available = true;
> > - } else {
> > - /*
> > - * Rate is defined as an unsigned long in clk API, and so
> > - * casting explicitly to its type. Must be fixed once rate is 64
> > - * bit guaranteed in clk API.
> > - */
> > - new_opp->rate = (unsigned long)rate;
> > + ret = _read_opp_key(new_opp, np, &rate_not_available);
> > + if (ret) {
>
> if (!opp_table->is_genpd) {
>
> _read_opp_key returns an error for genpd
> opps so please check if it is a genpd
> opp_table before erroring out here.
Thanks. I'll fix it in the next version.
> > + dev_err(dev, "%s: opp key field not found\n", __func__);
> > + goto free_opp;
> > }
> >
> > - of_property_read_u32(np, "opp-level", &new_opp->level);
> > -
> > /* Check if the OPP supports hardware's hierarchy of versions or not
> > */
> > if (!_opp_is_supported(dev, opp_table, np)) {
> > dev_dbg(dev, "OPP not supported by hardware: %llu\n", rate);
> > @@ -616,7 +640,8 @@ static struct dev_pm_opp
> > *_opp_add_static_v2(struct opp_table *opp_table,
> > if (of_property_read_bool(np, "opp-suspend")) {
> > if (opp_table->suspend_opp) {
> > /* Pick the OPP with higher rate as suspend OPP */
> > - if (new_opp->rate > opp_table->suspend_opp->rate) {
> > + if (opp_compare_key(new_opp,
> > + opp_table->suspend_opp) > 1) {
>
> shouldn't the condition be > 0?
Duh. Thanks. I'll fix it in the next version.
I'm guessing you tested with the fixes you pointed out?
-Saravana
next prev parent reply other threads:[~2020-01-08 6:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 0:24 [PATCH v6 0/3] Introduce Bandwidth OPPs for interconnects Saravana Kannan
2019-12-07 0:24 ` [PATCH v6 1/3] dt-bindings: opp: Introduce opp-peak-kBps and opp-avg-kBps bindings Saravana Kannan
2020-01-08 10:32 ` Viresh Kumar
2020-01-09 0:32 ` Saravana Kannan
2019-12-07 0:24 ` [PATCH v6 2/3] OPP: Add support for bandwidth OPP tables Saravana Kannan
2020-01-07 19:28 ` Sibi Sankar
2020-01-08 6:16 ` Saravana Kannan [this message]
2020-01-29 13:40 ` Sibi Sankar
2020-01-08 10:53 ` Viresh Kumar
2020-01-09 0:58 ` Saravana Kannan
2020-01-09 4:31 ` Viresh Kumar
2020-01-09 18:35 ` Saravana Kannan
2020-01-10 6:54 ` Viresh Kumar
2019-12-07 0:24 ` [PATCH v6 3/3] OPP: Add helper function " Saravana Kannan
2020-01-08 11:19 ` Viresh Kumar
2020-01-09 0:58 ` Saravana Kannan
2020-01-09 3:36 ` Saravana Kannan
2020-01-09 4:41 ` Viresh Kumar
2020-01-09 4:40 ` Viresh Kumar
2020-01-09 18:44 ` Saravana Kannan
2020-01-10 7:01 ` Viresh Kumar
2020-01-14 10:34 ` [PATCH v6 0/3] Introduce Bandwidth OPPs for interconnects Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGETcx9Or==EEL6jRMEh4bG4cmFmLqk_n1ReKT=cg-MEsL9w0w@mail.gmail.com' \
--to=saravanak@google.com \
--cc=adharmap@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=seansw@qti.qualcomm.com \
--cc=sibis@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).