From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58739C4BA06 for ; Wed, 26 Feb 2020 02:11:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 303B522464 for ; Wed, 26 Feb 2020 02:11:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lmu0ChZ/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730071AbgBZCLq (ORCPT ); Tue, 25 Feb 2020 21:11:46 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:34253 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730008AbgBZCLq (ORCPT ); Tue, 25 Feb 2020 21:11:46 -0500 Received: by mail-oi1-f193.google.com with SMTP id l136so1489178oig.1 for ; Tue, 25 Feb 2020 18:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4u/uS1fMpbXSukMymnz41XCHPdcIu8TO2CU/VdEdie8=; b=lmu0ChZ/FgDPtQGlWK6Rbqd83+DdMZgjE5nbcUq4IGpNTsD1zkXL2dTUlxIJN5wILC 06IuFW1ag+mdNilLpWx4948QwaoOg+eafZlc4nYzd97PXBHBe2ccQGB9u9v9sRPg/WsS JSQxqVPzW61PyEO6v9vaWT5OAzh8uOwzYvZ9u1aXXQKwq+mOW5yHe+luKixTmR3CIyHz LAvVan4VZ03VO6CVX1DbeqA8Corv8uE5bncIuqrIVp4wvUEGUPZvb8/42RPdm1IWAGWL d5cEok/AA0bnc9KzhZK86HIdWB7c49mruzHN1N+O6wNtDhrqrEFI9AeQzIB6SadDtIxz //oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4u/uS1fMpbXSukMymnz41XCHPdcIu8TO2CU/VdEdie8=; b=adp3DWzxX89fq1b4Rf5rINTsy1V5VG/upQI6gJb3aDtLzgL/fyKbg0Iia47lZAO2gw yVLUaXKIvmyzaQwI2wcXmDsR2B5lr7KxvZYe/NJMZCJv8hYExEPHo71uGlIx1jM7lNIE aD+O4cLACNN/KDOGnQMnkxK6jzY6ttLSzaPOjJqGQFo6xb0fi8L5zbPDCdj/nS7jLAU7 WktACGrXPnRtXhgqKRmxPbazhhtLTSLxCj033Hkvm6IugnQ6n+c9zqlGNTXbDrklz+Gp 1eCbnIRWH3xX4xjZWcD3nwJrEu27ulXKn6j0g0OI+l1zwWzuAy5mgewHEYvyyldivv0H AH9w== X-Gm-Message-State: APjAAAVzNGJaYdTq9WDXDDxDDFhoOMghADwhnjd9V9H+iJrscUby7XRR S3hV6Jhm1x4JMqMqRu1PvU7/uFQu+fSn8pQdUYp93A== X-Google-Smtp-Source: APXvYqzZdInnLy1DDni0f4aafChdUAgr22n+6IwChbEzWLmta8PK1dpLF7BWtYyYmXpKRVxz5b8I4y474iMM/AQarqA= X-Received: by 2002:aca:ea43:: with SMTP id i64mr1441788oih.30.1582683105454; Tue, 25 Feb 2020 18:11:45 -0800 (PST) MIME-Version: 1.0 References: <20200225050828.56458-1-john.stultz@linaro.org> <20200225050828.56458-4-john.stultz@linaro.org> In-Reply-To: <20200225050828.56458-4-john.stultz@linaro.org> From: Saravana Kannan Date: Tue, 25 Feb 2020 18:11:09 -0800 Message-ID: Subject: Re: [PATCH v5 3/6] pinctrl: Remove use of driver_deferred_probe_check_state_continue() To: John Stultz Cc: lkml , Rob Herring , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Todd Kjos , Bjorn Andersson , Liam Girdwood , Mark Brown , Thierry Reding , Linus Walleij , Greg Kroah-Hartman , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sending again because of accidental HTML email. On Mon, Feb 24, 2020 at 9:08 PM John Stultz wrote: > > With the earlier sanity fixes to > driver_deferred_probe_check_state() it should be usable for the > pinctrl logic here. > > So tweak the logic to use driver_deferred_probe_check_state() > instead of driver_deferred_probe_check_state_continue() > > Cc: Rob Herring > Cc: "Rafael J. Wysocki" > Cc: Kevin Hilman > Cc: Ulf Hansson > Cc: Pavel Machek > Cc: Len Brown > Cc: Todd Kjos > Cc: Saravana Kannan > Cc: Bjorn Andersson > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Thierry Reding > Cc: Linus Walleij > Cc: Greg Kroah-Hartman > Cc: linux-pm@vger.kernel.org > Acked-by: Linus Walleij > Signed-off-by: John Stultz > --- > drivers/pinctrl/devicetree.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c > index 9357f7c46cf3..1ed20ac2243f 100644 > --- a/drivers/pinctrl/devicetree.c > +++ b/drivers/pinctrl/devicetree.c > @@ -127,11 +127,12 @@ static int dt_to_map_one_config(struct pinctrl *p, > np_pctldev = of_get_next_parent(np_pctldev); > if (!np_pctldev || of_node_is_root(np_pctldev)) { > of_node_put(np_pctldev); > + ret = driver_deferred_probe_check_state(p->dev); > /* keep deferring if modules are enabled unless we've timed out */ > - if (IS_ENABLED(CONFIG_MODULES) && !allow_default) > - return driver_deferred_probe_check_state_continue(p->dev); > - > - return driver_deferred_probe_check_state(p->dev); > + if (IS_ENABLED(CONFIG_MODULES) && !allow_default && Is this IS_ENABLED(CONFIG_MODULES) still necessary? At the end of this series, doesn't driver_deferred_probe_check_state() already return -EPROBE_DEFER if modules are enabled and timeout hasn't happened? -Saravana > + (ret == -ENODEV)) > + ret = -EPROBE_DEFER; > + return ret; > } > /* If we're creating a hog we can use the passed pctldev */ > if (hog_pctldev && (np_pctldev == p->dev->of_node)) { > -- > 2.17.1 >