From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751322AbdAMIIT (ORCPT ); Fri, 13 Jan 2017 03:08:19 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:35188 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbdAMIIR (ORCPT ); Fri, 13 Jan 2017 03:08:17 -0500 MIME-Version: 1.0 In-Reply-To: <1484091325-9199-31-git-send-email-linux@roeck-us.net> References: <1484091325-9199-1-git-send-email-linux@roeck-us.net> <1484091325-9199-31-git-send-email-linux@roeck-us.net> From: Johannes Thumshirn Date: Fri, 13 Jan 2017 09:08:16 +0100 Message-ID: Subject: Re: [PATCH 30/62] watchdog: mena21_wdt: Convert to use device managed functions and other improvements To: Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-kernel , Wim Van Sebroeck Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 11.01.2017 12:38 vorm. schrieb "Guenter Roeck" : > > Use device managed functions to simplify error handling, reduce > source code size, improve readability, and reduce the likelyhood of bugs. > Other improvements as listed below. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts used > to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > - Replace 'goto l; ... l: return e;' with 'return e;' > - Drop assignments to otherwise unused variables > - Drop remove function > - Drop unnecessary mutex_destroy() on allocated data > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Johannes Thumshirn > Signed-off-by: Guenter Roeck > --- Looks good, Acked-by: Johannes Thumshirn