From: Hanjun Guo <hanjun.guo@linaro.org>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH] irqchip/gic-v3-its: Allow GIC ITS number more than MAX_NUMNODES
Date: Fri, 21 Jul 2017 18:50:36 +0800 [thread overview]
Message-ID: <CAGHbJ3AfXMHy5+ZNQnPBiNEOvxTNgELMWvvgRZmYM5dHdzN4-w@mail.gmail.com> (raw)
In-Reply-To: <5971D208.3040005@huawei.com>
On 21 July 2017 at 18:06, Hanjun Guo <guohanjun@huawei.com> wrote:
>
> On 2017/7/21 17:51, Hanjun Guo wrote:
> > From: Hanjun Guo <hanjun.guo@linaro.org>
> >
> > When running 4.13-rc1 on top of D05, I got the boot log:
> >
> > [ 0.000000] SRAT: PXM 0 -> ITS 0 -> Node 0
> > [ 0.000000] SRAT: PXM 0 -> ITS 1 -> Node 0
> > [ 0.000000] SRAT: PXM 0 -> ITS 2 -> Node 0
> > [ 0.000000] SRAT: PXM 1 -> ITS 3 -> Node 1
> > [ 0.000000] SRAT: ITS affinity exceeding max count[4]
> >
> > This is wrong on D05 as we have 8 ITSes with 4 NUMA nodes.
> >
> > So dynamically alloc the memory needed instead of using
> > its_srat_maps[MAX_NUMNODES], which count the number of
> > ITS entry(ies) in SRAT and alloc its_srat_maps as needed,
> > then build the mapping of numa node to ITS ID.
> >
> > After doing this, I got what I wanted:
> >
> > [ 0.000000] SRAT: PXM 0 -> ITS 0 -> Node 0
> > [ 0.000000] SRAT: PXM 0 -> ITS 1 -> Node 0
> > [ 0.000000] SRAT: PXM 0 -> ITS 2 -> Node 0
> > [ 0.000000] SRAT: PXM 1 -> ITS 3 -> Node 1
> > [ 0.000000] SRAT: PXM 2 -> ITS 4 -> Node 2
> > [ 0.000000] SRAT: PXM 2 -> ITS 5 -> Node 2
> > [ 0.000000] SRAT: PXM 2 -> ITS 6 -> Node 2
> > [ 0.000000] SRAT: PXM 3 -> ITS 7 -> Node 3
> >
> > Fixes: dbd2b8267233 ("irqchip/gic-v3-its: Add ACPI NUMA node mapping")
> > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> > Cc: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > ---
> > drivers/irqchip/irq-gic-v3-its.c | 28 +++++++++++++++++++++-------
> > 1 file changed, 21 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> > index 3ccdf76..fb1c090 100644
> > --- a/drivers/irqchip/irq-gic-v3-its.c
> > +++ b/drivers/irqchip/irq-gic-v3-its.c
> > @@ -1847,7 +1847,7 @@ struct its_srat_map {
> > u32 its_id;
> > };
> >
> > -static struct its_srat_map its_srat_maps[MAX_NUMNODES] __initdata;
> > +static struct its_srat_map *its_srat_maps __initdata;
> > static int its_in_srat __initdata;
> >
> > static int __init acpi_get_its_numa_node(u32 its_id)
> > @@ -1861,6 +1861,12 @@ static int __init acpi_get_its_numa_node(u32 its_id)
> > return NUMA_NO_NODE;
> > }
>
> Oops, need to check if the its_srat_maps valid or not here, please
> comment on what else I'm missing or wrong, then I will prepare another
^^^
And need to free the memory.
Thanks
Hanjun
next prev parent reply other threads:[~2017-07-21 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 9:51 [PATCH] irqchip/gic-v3-its: Allow GIC ITS number more than MAX_NUMNODES Hanjun Guo
2017-07-21 10:06 ` Hanjun Guo
2017-07-21 10:50 ` Hanjun Guo [this message]
2017-07-21 11:20 ` Marc Zyngier
2017-07-21 11:42 ` Ganapatrao Kulkarni
2017-07-22 3:52 ` Hanjun Guo
2017-07-22 3:44 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGHbJ3AfXMHy5+ZNQnPBiNEOvxTNgELMWvvgRZmYM5dHdzN4-w@mail.gmail.com \
--to=hanjun.guo@linaro.org \
--cc=ganapatrao.kulkarni@cavium.com \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).