From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: bhe@redhat.com
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
dave.hansen@intel.com, pagupta@redhat.com,
Linux Memory Management List <linux-mm@kvack.org>,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v5 3/4] mm/sparse: Add a new parameter 'data_unit_size' for alloc_usemap_and_memmap
Date: Wed, 27 Jun 2018 23:14:44 -0400 [thread overview]
Message-ID: <CAGM2reb=2fmgJQzfPGJ_bCG-317-dsFfoG8vSr9LuYit4AVsyQ@mail.gmail.com> (raw)
In-Reply-To: <20180627013116.12411-4-bhe@redhat.com>
Honestly, I do not like this new agrument, but it will do for now. I
could not think of a better way without rewriting everything.
Reviewed-by: Pavel Tatashin <pasha.tatashin@oracle.com>
However, I will submit a series of patches to cleanup sparse.c and
completely remove large and confusing temporary buffers: map_map, and
usemap_map. In those patches, I will remove alloc_usemap_and_memmap().
On Tue, Jun 26, 2018 at 9:31 PM Baoquan He <bhe@redhat.com> wrote:
>
> alloc_usemap_and_memmap() is passing in a "void *" that points to
> usemap_map or memmap_map. In next patch we will change both of the
> map allocation from taking 'NR_MEM_SECTIONS' as the length to taking
> 'nr_present_sections' as the length. After that, the passed in 'void*'
> needs to update as things get consumed. But, it knows only the
> quantity of objects consumed and not the type. This effectively
> tells it enough about the type to let it update the pointer as
> objects are consumed.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> mm/sparse.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/mm/sparse.c b/mm/sparse.c
> index 71ad53da2cd1..b2848cc6e32a 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -489,10 +489,12 @@ void __weak __meminit vmemmap_populate_print_last(void)
> /**
> * alloc_usemap_and_memmap - memory alloction for pageblock flags and vmemmap
> * @map: usemap_map for pageblock flags or mmap_map for vmemmap
> + * @unit_size: size of map unit
> */
> static void __init alloc_usemap_and_memmap(void (*alloc_func)
> (void *, unsigned long, unsigned long,
> - unsigned long, int), void *data)
> + unsigned long, int), void *data,
> + int data_unit_size)
> {
> unsigned long pnum;
> unsigned long map_count;
> @@ -569,7 +571,8 @@ void __init sparse_init(void)
> if (!usemap_map)
> panic("can not allocate usemap_map\n");
> alloc_usemap_and_memmap(sparse_early_usemaps_alloc_node,
> - (void *)usemap_map);
> + (void *)usemap_map,
> + sizeof(usemap_map[0]));
>
> #ifdef CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER
> size2 = sizeof(struct page *) * NR_MEM_SECTIONS;
> @@ -577,7 +580,8 @@ void __init sparse_init(void)
> if (!map_map)
> panic("can not allocate map_map\n");
> alloc_usemap_and_memmap(sparse_early_mem_maps_alloc_node,
> - (void *)map_map);
> + (void *)map_map,
> + sizeof(map_map[0]));
> #endif
>
> for_each_present_section_nr(0, pnum) {
> --
> 2.13.6
>
next prev parent reply other threads:[~2018-06-28 3:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 1:31 [PATCH v5 0/4] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-06-27 1:31 ` [PATCH v5 1/4] mm/sparse: Add a static variable nr_present_sections Baoquan He
2018-06-28 3:10 ` Pavel Tatashin
2018-06-27 1:31 ` [PATCH v5 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing Baoquan He
2018-06-27 9:54 ` Oscar Salvador
2018-06-27 22:59 ` Baoquan He
2018-06-28 3:11 ` Pavel Tatashin
2018-06-27 1:31 ` [PATCH v5 3/4] mm/sparse: Add a new parameter 'data_unit_size' for alloc_usemap_and_memmap Baoquan He
2018-06-28 3:14 ` Pavel Tatashin [this message]
2018-06-28 6:57 ` Baoquan He
2018-06-27 1:31 ` [PATCH v5 4/4] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-06-28 3:19 ` Pavel Tatashin
2018-06-28 6:39 ` Baoquan He
2018-06-29 17:16 ` Dave Hansen
2018-06-29 17:48 ` Pavel Tatashin
2018-06-29 17:52 ` Dave Hansen
2018-06-29 18:01 ` Pavel Tatashin
2018-06-29 18:56 ` Dave Hansen
2018-06-29 18:59 ` Pavel Tatashin
2018-06-27 1:47 ` [PATCH v5 0/4] " Baoquan He
2018-06-27 17:47 ` Pavel Tatashin
2018-06-27 23:39 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGM2reb=2fmgJQzfPGJ_bCG-317-dsFfoG8vSr9LuYit4AVsyQ@mail.gmail.com' \
--to=pasha.tatashin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pagupta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).