From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968534AbdDSRbp (ORCPT ); Wed, 19 Apr 2017 13:31:45 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:33255 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968518AbdDSRbn (ORCPT ); Wed, 19 Apr 2017 13:31:43 -0400 MIME-Version: 1.0 In-Reply-To: <20170322180458.15567-1-fathi.boudra@linaro.org> References: <20170322180458.15567-1-fathi.boudra@linaro.org> From: Fathi Boudra Date: Wed, 19 Apr 2017 20:31:35 +0300 Message-ID: Subject: Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64 To: Shuah Khan Cc: "linux-kernel@vger.kernel.org" , Pratyush Anand , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gentle ping On 22 March 2017 at 20:04, Fathi Boudra wrote: > To build breakpoint_test_arm64, ARCH value is only tested for "aarch64". > It covers only the native build because it's computed from uname -m output. > For cross-compilation, ARCH is set to arm64 and prevent to cross-compile > the test. > Fix the test to allow both native and cross-compilation of the test. > > Note: glibc is missing several of the TRAP_* constants in the userspace > definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT. > See https://sourceware.org/bugzilla/show_bug.cgi?id=21286 > > Signed-off-by: Fathi Boudra > --- > tools/testing/selftests/breakpoints/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile > index 72aa103e4141..6b214b7b10fb 100644 > --- a/tools/testing/selftests/breakpoints/Makefile > +++ b/tools/testing/selftests/breakpoints/Makefile > @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) > ifeq ($(ARCH),x86) > TEST_GEN_PROGS := breakpoint_test > endif > -ifeq ($(ARCH),aarch64) > +ifneq (,$(filter $(ARCH),aarch64 arm64)) > TEST_GEN_PROGS := breakpoint_test_arm64 > endif > > -- > 2.11.0 >