From: Alim Akhtar <alim.akhtar@gmail.com>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "daejun7.park@samsung.com" <daejun7.park@samsung.com>,
Bean Huo <huobean@gmail.com>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sang-yoon Oh <sangyoon.oh@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
yongmyung lee <ymhungry.lee@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
Adel Choi <adel.choi@samsung.com>,
BoRam Shin <boram.shin@samsung.com>
Subject: Re: [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer
Date: Wed, 17 Jun 2020 14:27:19 +0530 [thread overview]
Message-ID: <CAGOxZ50TUnvmmdspxr6dHWrpoxZqHtvR-1Wg6jAVH6k-w5LT2w@mail.gmail.com> (raw)
In-Reply-To: <SN6PR04MB4640EE125CF504AF9362B23FFC9A0@SN6PR04MB4640.namprd04.prod.outlook.com>
On Wed, Jun 17, 2020 at 12:27 PM Avri Altman <Avri.Altman@wdc.com> wrote:
>
> >
> > Hi, Bean
> > >
> > > On Mon, 2020-06-15 at 16:23 +0900, Daejun Park wrote:
> > > > +void ufsf_scan_features(struct ufs_hba *hba)
> > > > +{
> > > > + int ret;
> > > > +
> > > > + init_waitqueue_head(&hba->ufsf.sdev_wait);
> > > > + atomic_set(&hba->ufsf.slave_conf_cnt, 0);
> > > > +
> > > > + if (hba->dev_info.wspecversion >= HPB_SUPPORTED_VERSION &&
> > > > + (hba->dev_info.b_ufs_feature_sup & UFS_DEV_HPB_SUPPORT))
> > >
> > > How about removing this check "(hba->dev_info.wspecversion >=
> > > HPB_SUPPORTED_VERSION" since ufs with lower version than v3.1 can add
> > > HPB feature by FFU,
> > > if (hba->dev_info.b_ufs_feature_sup &UFS_FEATURE_SUPPORT_HPB_BIT) is
> > > enough.
> > OK, changing it seems no problem. But I want to know what other people
> > think
> > about this version checking code.
> HPB1.0 isn't part of ufs3.1, but published only later.
> Allowing earlier versions will required to quirk the descriptor sizes.
> I see Bean's point here, but I vote for adding it in a single quirk, when the time comes.
>
I second Avri here, older devices need a quirk to handle, let do that
as a separate patch.
> Thanks,
> Avri
--
Regards,
Alim
next prev parent reply other threads:[~2020-06-17 8:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p1>
2020-06-15 6:27 ` [RFC PATCH v2 0/5] scsi: ufs: Add Host Performance Booster Support Daejun Park
[not found] ` <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p4>
2020-06-15 9:08 ` [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module Daejun Park
2020-06-17 8:07 ` Avri Altman
2020-06-17 11:31 ` Avri Altman
2020-06-15 9:41 ` [RFC PATCH v2 5/5] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
[not found] ` <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p7>
2020-06-15 9:30 ` [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read Daejun Park
2020-06-15 13:35 ` Bean Huo
2020-06-17 11:44 ` Avri Altman
2020-06-18 10:22 ` Avri Altman
2020-06-16 1:17 ` Daejun Park
[not found] ` <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p5>
2020-06-15 7:21 ` [RFC PATCH v2 1/5] scsi: ufs: Add UFS feature related parameter Daejun Park
2020-06-17 10:30 ` [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module Daejun Park
2020-06-17 18:24 ` Bean Huo
[not found] ` <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p3>
2020-06-18 1:06 ` Daejun Park
2020-06-18 6:19 ` Avri Altman
2020-06-18 0:53 ` Daejun Park
[not found] ` <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p8>
2020-06-15 7:23 ` [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer Daejun Park
2020-06-15 13:09 ` Bean Huo
2020-06-17 7:08 ` Avri Altman
[not found] ` <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p6>
2020-06-16 1:18 ` Daejun Park
2020-06-17 6:55 ` Avri Altman
2020-06-17 8:57 ` Alim Akhtar [this message]
2020-06-17 9:41 ` Bean Huo
2020-06-17 9:53 ` Alim Akhtar
2020-06-18 1:03 ` [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read Daejun Park
2020-06-18 6:12 ` Avri Altman
2020-06-17 10:09 ` [RFC PATCH v2 2/5] scsi: ufs: Add UFS-feature layer Daejun Park
2020-06-19 0:12 ` [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read Daejun Park
2020-06-22 4:10 ` [RFC PATCH v2 0/5] scsi: ufs: Add Host Performance Booster Support Bart Van Assche
2020-06-19 0:16 ` [RFC PATCH v2 4/5] scsi: ufs: L2P map management for HPB read Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGOxZ50TUnvmmdspxr6dHWrpoxZqHtvR-1Wg6jAVH6k-w5LT2w@mail.gmail.com \
--to=alim.akhtar@gmail.com \
--cc=Avri.Altman@wdc.com \
--cc=adel.choi@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=boram.shin@samsung.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=huobean@gmail.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sangyoon.oh@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
--cc=tomas.winkler@intel.com \
--cc=ymhungry.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).