From: Alim Akhtar <alim.akhtar@gmail.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: robh <robh@kernel.org>,
devicetree@vger.kernel.org, linux-scsi@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Avri Altman <avri.altman@wdc.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kiwoong Kim <kwmad.kim@samsung.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Can Guo <cang@codeaurora.org>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings
Date: Tue, 21 Apr 2020 22:25:43 +0530 [thread overview]
Message-ID: <CAGOxZ51jnbnHjVDQitbvSkrPH2=OdBKQHPnnT8yr+nKARud-WQ@mail.gmail.com> (raw)
In-Reply-To: <20200417175944.47189-7-alim.akhtar@samsung.com>
Hi Rob
Request you to comment on this dt-bindings documentation.
Thanks
On Fri, Apr 17, 2020 at 11:43 PM Alim Akhtar <alim.akhtar@samsung.com> wrote:
>
> This patch documents Samsung UFS PHY device tree bindings
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Tested-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
> .../bindings/phy/samsung,ufs-phy.yaml | 74 +++++++++++++++++++
> 1 file changed, 74 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> new file mode 100644
> index 000000000000..352d5dda320d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/samsung,ufs-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung SoC series UFS PHY Device Tree Bindings
> +
> +maintainers:
> + - Alim Akhtar <alim.akhtar@samsung.com>
> +
> +properties:
> + "#phy-cells":
> + const: 0
> +
> + compatible:
> + enum:
> + - samsung,exynos7-ufs-phy
> +
> + reg:
> + maxItems: 1
> + description: PHY base register address
> +
> + reg-names:
> + items:
> + - const: phy-pma
> +
> + clocks:
> + items:
> + - description: PLL reference clock
> + - description: symbol clock for input symbol ( rx0-ch0 symbol clock)
> + - description: symbol clock for input symbol ( rx1-ch1 symbol clock)
> + - description: symbol clock for output symbol ( tx0 symbol clock)
> +
> + clock-names:
> + items:
> + - const: ref_clk
> + - const: rx1_symbol_clk
> + - const: rx0_symbol_clk
> + - const: tx0_symbol_clk
> +
> + samsung,pmu-syscon:
> + $ref: '/schemas/types.yaml#/definitions/phandle'
> + description: phandle for PMU system controller interface, used to
> + control pmu registers bits for ufs m-phy
> +
> +required:
> + - "#phy-cells"
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> + - clock-names
> + - samsung,pmu-syscon
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/exynos7-clk.h>
> +
> + ufs_phy: ufs-phy@15571800 {
> + compatible = "samsung,exynos7-ufs-phy";
> + reg = <0x15571800 0x240>;
> + reg-names = "phy-pma";
> + samsung,pmu-syscon = <&pmu_system_controller>;
> + #phy-cells = <0>;
> + clocks = <&clock_fsys1 SCLK_COMBO_PHY_EMBEDDED_26M>,
> + <&clock_fsys1 PHYCLK_UFS20_RX1_SYMBOL_USER>,
> + <&clock_fsys1 PHYCLK_UFS20_RX0_SYMBOL_USER>,
> + <&clock_fsys1 PHYCLK_UFS20_TX0_SYMBOL_USER>;
> + clock-names = "ref_clk", "rx1_symbol_clk",
> + "rx0_symbol_clk", "tx0_symbol_clk";
> +
> + };
> +...
> --
> 2.17.1
>
--
Regards,
Alim
next prev parent reply other threads:[~2020-04-21 16:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200417181006epcas5p269f8c4b94e60962a0b0318ef64a65364@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI Alim Akhtar
[not found] ` <CGME20200417181008epcas5p460840c01c2c09ce1a69e83005b4bddbe@epcas5p4.samsung.com>
2020-04-17 17:59 ` [PATCH v6 01/10] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
2020-04-20 6:55 ` Avri Altman
2020-04-21 5:52 ` Can Guo
[not found] ` <CGME20200417181010epcas5p23cb018eee5b7ae0eba87d81dbaaec3ce@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 02/10] scsi: ufs: add quirk to disallow reset of interrupt aggregation Alim Akhtar
2020-04-20 7:05 ` Avri Altman
[not found] ` <CGME20200417181012epcas5p2004ac8f0d793abd4d58c096ff490da68@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 03/10] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
2020-04-20 7:14 ` Avri Altman
2020-04-21 5:59 ` Can Guo
2020-04-21 6:00 ` Can Guo
[not found] ` <CGME20200417181014epcas5p1343bc81fb246133cc332d3fc7a394c15@epcas5p1.samsung.com>
2020-04-17 17:59 ` [PATCH v6 04/10] scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk Alim Akhtar
2020-04-20 8:13 ` Avri Altman
2020-04-22 6:54 ` Christoph Hellwig
2020-04-26 15:56 ` Alim Akhtar
[not found] ` <CGME20200417181016epcas5p2ee7ac86d743ceee9076690dc5b1e2f08@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error Alim Akhtar
2020-04-20 8:55 ` Avri Altman
2020-04-21 7:46 ` Kiwoong Kim
2020-04-21 7:51 ` Kiwoong Kim
2020-04-21 12:07 ` Avri Altman
2020-04-26 15:54 ` Alim Akhtar
2020-04-22 6:55 ` Christoph Hellwig
2020-04-26 15:57 ` Alim Akhtar
[not found] ` <CGME20200417181018epcas5p1e51c7ca0fe81df16554548df5b82e3e4@epcas5p1.samsung.com>
2020-04-17 17:59 ` [PATCH v6 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar
2020-04-21 16:55 ` Alim Akhtar [this message]
[not found] ` <CGME20200417181020epcas5p2121f17c89634d6ad8f30258339a6b249@epcas5p2.samsung.com>
2020-04-17 17:59 ` [PATCH v6 07/10] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar
[not found] ` <CGME20200417181022epcas5p1f83138da6e76ff0917de88e913ef8e32@epcas5p1.samsung.com>
2020-04-17 17:59 ` [PATCH v6 08/10] dt-bindings: ufs: Add DT binding documentation for ufs Alim Akhtar
2020-04-21 16:56 ` Alim Akhtar
[not found] ` <CGME20200417181024epcas5p4231ae3dd2598155854e9b7ee52438bcb@epcas5p4.samsung.com>
2020-04-17 17:59 ` [PATCH v6 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
2020-04-17 18:20 ` Randy Dunlap
2020-04-20 10:26 ` Avri Altman
2020-04-21 0:59 ` Alim Akhtar
[not found] ` <CGME20200417181026epcas5p434bcc980e1fe334969ef6f1641525ee0@epcas5p4.samsung.com>
2020-04-17 17:59 ` [PATCH v6 10/10] arm64: dts: Add node for ufs exynos7 Alim Akhtar
2020-04-18 12:38 ` [PATCH v6 0/10] exynos-ufs: Add support for UFS HCI Avri Altman
2020-04-18 13:08 ` Alim Akhtar
2020-04-18 16:00 ` Avri Altman
2020-04-18 16:04 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGOxZ51jnbnHjVDQitbvSkrPH2=OdBKQHPnnT8yr+nKARud-WQ@mail.gmail.com' \
--to=alim.akhtar@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh@kernel.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).