From: Alim Akhtar <alim.akhtar@gmail.com>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Avri Altman <avri.altman@wdc.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Bean Huo (beanhuo)" <beanhuo@micron.com>,
asutoshd@codeaurora.org, Can Guo <cang@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>,
Kuohong Wang <kuohong.wang@mediatek.com>,
peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
andy.teng@mediatek.com
Subject: Re: [PATCH v1 1/3] scsi: ufs-mediatek: add dbg_register_dump implementation
Date: Sun, 19 Jan 2020 19:35:12 +0530 [thread overview]
Message-ID: <CAGOxZ51ju5sKxtVzXQAFBKz_4Pc9YEZ0i4o4iHkutGx2d+H2QQ@mail.gmail.com> (raw)
In-Reply-To: <20200117035108.19699-2-stanley.chu@mediatek.com>
Hi Stanley
On Fri, Jan 17, 2020 at 9:44 AM Stanley Chu <stanley.chu@mediatek.com> wrote:
>
> Add dbg_register_dump variant vendor implementation in MediaTek
> UFS driver.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/scsi/ufs/ufs-mediatek.c | 16 ++++++++++++++++
> drivers/scsi/ufs/ufs-mediatek.h | 5 +++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index 8d999c0e60fe..d5194d0c4ef5 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -406,6 +406,21 @@ static int ufs_mtk_resume(struct ufs_hba *hba, enum ufs_pm_op pm_op)
> return 0;
> }
>
> +static void ufs_mtk_dbg_register_dump(struct ufs_hba *hba)
> +{
> + ufshcd_dump_regs(hba, REG_UFS_REFCLK_CTRL, 0x4, "Ref-Clk Ctrl ");
> +
> + ufshcd_dump_regs(hba, REG_UFS_EXTREG, 0x4, "Ext Reg ");
> +
> + ufshcd_dump_regs(hba, REG_UFS_MPHYCTRL,
> + REG_UFS_REJECT_MON - REG_UFS_MPHYCTRL + 4,
> + "MPHY Ctrl ");
> +
> + /* Direct debugging information to REG_MTK_PROBE */
> + ufshcd_writel(hba, 0x20, REG_UFS_DEBUG_SEL);
> + ufshcd_dump_regs(hba, REG_UFS_PROBE, 0x4, "Debug Probe ");
> +}
> +
> static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba,
> struct ufs_dev_desc *card)
> {
> @@ -430,6 +445,7 @@ static struct ufs_hba_variant_ops ufs_hba_mtk_vops = {
> .apply_dev_quirks = ufs_mtk_apply_dev_quirks,
> .suspend = ufs_mtk_suspend,
> .resume = ufs_mtk_resume,
> + .dbg_register_dump = ufs_mtk_dbg_register_dump,
> .device_reset = ufs_mtk_device_reset,
> };
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.h b/drivers/scsi/ufs/ufs-mediatek.h
> index 31b7fead19eb..fccdd979d6fb 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.h
> +++ b/drivers/scsi/ufs/ufs-mediatek.h
> @@ -13,6 +13,11 @@
> * Vendor specific UFSHCI Registers
> */
> #define REG_UFS_REFCLK_CTRL 0x144
> +#define REG_UFS_EXTREG 0x2100
> +#define REG_UFS_MPHYCTRL 0x2200
> +#define REG_UFS_REJECT_MON 0x22AC
> +#define REG_UFS_DEBUG_SEL 0x22C0
> +#define REG_UFS_PROBE 0x22C8
>
> /*
> * Ref-clk control
> --
> 2.18.0
--
Regards,
Alim
next prev parent reply other threads:[~2020-01-19 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 3:51 [PATCH v1 0/3] scsi: ufs-mediatek: add MediaTek vendor implementation part II Stanley Chu
2020-01-17 3:51 ` [PATCH v1 1/3] scsi: ufs-mediatek: add dbg_register_dump implementation Stanley Chu
2020-01-19 14:05 ` Alim Akhtar [this message]
2020-01-17 3:51 ` [PATCH v1 2/3] scsi: ufs: export some functions for vendor usage Stanley Chu
2020-01-19 14:12 ` Alim Akhtar
2020-01-20 20:49 ` Asutosh Das (asd)
2020-01-17 3:51 ` [PATCH v1 3/3] scsi: ufs-mediatek: enable low-power mode for hibern8 state Stanley Chu
2020-01-19 14:27 ` Alim Akhtar
2020-01-20 20:52 ` Asutosh Das (asd)
2020-01-21 0:10 ` [PATCH v1 0/3] scsi: ufs-mediatek: add MediaTek vendor implementation part II Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGOxZ51ju5sKxtVzXQAFBKz_4Pc9YEZ0i4o4iHkutGx2d+H2QQ@mail.gmail.com \
--to=alim.akhtar@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).