From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752326AbbDTXmr (ORCPT ); Mon, 20 Apr 2015 19:42:47 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:33515 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbbDTXmn (ORCPT ); Mon, 20 Apr 2015 19:42:43 -0400 MIME-Version: 1.0 In-Reply-To: <1429572637-30234-5-git-send-email-mcgrof@do-not-panic.com> References: <1429572637-30234-1-git-send-email-mcgrof@do-not-panic.com> <1429572637-30234-5-git-send-email-mcgrof@do-not-panic.com> From: Julian Calaby Date: Tue, 21 Apr 2015 09:42:21 +1000 Message-ID: Subject: Re: [PATCH v1 4/6] moduleparam.h: add module_param_config_*() helpers To: "Luis R. Rodriguez" Cc: Rusty Russell , "linux-kernel@vger.kernel.org" , linux-wireless , keescook@chromium.org, casey@schaufler-ca.com, cocci@systeme.lip6.fr, "Luis R. Rodriguez" , Jani Nikula , Christoph Hellwig , Andrew Morton , Geert Uytterhoeven , Hannes Reinecke , Tejun Heo , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luis, You made a spelling mistake: On Tue, Apr 21, 2015 at 9:30 AM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This adds a couple of bool module_param_config_*() helpers > which are designed to let us easily associate a booloean > module parameter with an associated kernel configuration > option, and to help us remove #ifdef'ery eyesores. > > Cc: Rusty Russell > Cc: Jani Nikula > Cc: Christoph Hellwig > Cc: Andrew Morton > Cc: Geert Uytterhoeven > Cc: Hannes Reinecke > Cc: Kees Cook > Cc: Tejun Heo > Cc: Ingo Molnar > Cc: linux-kernel@vger.kernel.org > Cc: cocci@systeme.lip6.fr > Signed-off-by: Luis R. Rodriguez > --- > include/linux/moduleparam.h | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h > index 7e00799..fdf7b87 100644 > --- a/include/linux/moduleparam.h > +++ b/include/linux/moduleparam.h > @@ -155,6 +155,43 @@ struct kparam_array > __MODULE_PARM_TYPE(name, #type) > > /** > + * module_param_config_on_off - bool parameter with run time override > + * @name: a valid C identifier which is the parameter name. > + * @value: the actual lvalue to alter. > + * @perm: visibility in sysfs. > + * @config: kernel parameter which will enable this option if this > + * kernel configuration option has been enabled. > + * > + * This lets you define a bool module paramter which by default will be s/paramter/parameter/ > + * set to true if the config option has been set on your kernel's > + * configuration, otherwise it is set to false. > + */ > +#define module_param_config_on_off(name, var, perm, config) \ > + static bool var = IS_ENABLED(config); \ > + module_param_named(name, var, bool, perm); > + > +/** > + * module_param_config_on - bool parameter with run time enablement override > + * @name: a valid C identifier which is the parameter name. > + * @value: the actual lvalue to alter. > + * @perm: visibility in sysfs. > + * @config: kernel parameter which will enable this option if this > + * kernel configuration option has been enabled. > + * > + * This lets you define a bool module paramter which by default will be Here too. Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/