From: Ross Zwisler <zwisler@google.com>
To: keescook@chromium.org
Cc: dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
anton@enomsg.org, ccross@android.com, tony.luck@intel.com,
joel@joelfernandes.org
Subject: Re: [PATCH] pstore/ram: Clarify resource reservation labels
Date: Thu, 18 Oct 2018 14:58:25 -0600 [thread overview]
Message-ID: <CAGRrVHzd86TYe8sE0S88HObDOXKNAfsX9T=GCo0gkTr2n1wDQw@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jKUc0+EnV0m1ii_aRVa2XJSDtKY4Xq77Q+an1Z1VUqV7w@mail.gmail.com>
On Thu, Oct 18, 2018 at 2:31 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Thu, Oct 18, 2018 at 8:33 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> > [ add Ross ]
>
> Hi Ross! :)
>
> > On Thu, Oct 18, 2018 at 12:15 AM Kees Cook <keescook@chromium.org> wrote:
> >> As for nvdimm specifically, yes, I'd love to get pstore hooked up
> >> correctly to nvdimm. How do the namespaces work? Right now pstore
> >> depends one of platform driver data, device tree specification, or
> >> manual module parameters.
> >
> > From the userspace side we have the ndctl utility to wrap
> > personalities on top of namespaces. So for example, I envision we
> > would be able to do:
> >
> > ndctl create-namespace --mode=pstore --size=128M
> >
> > ...and create a small namespace that will register with the pstore sub-system.
> >
> > On the kernel side this would involve registering a 'pstore_dev' child
> > / seed device under each region device. The 'seed-device' sysfs scheme
> > is described in our documentation [1]. The short summary is ndctl
> > finds a seed device assigns a namespace to it and then binding that
> > device to a driver causes it to be initialized by the kernel.
> >
> > [1]: https://www.kernel.org/doc/Documentation/nvdimm/nvdimm.txt
>
> Interesting!
>
> Really, this would be a way to configure "ramoops" (the persistent RAM
> backend to pstore), rather than pstore itself (pstore is just the
> framework). From reading the ndctl man page it sounds like there isn't
> a way to store configuration information beyond just size?
Ramoops needs a start (mem_address), size (mem_size) and mapping type
(mem_type), right? I think we get the first two for free based on the
size of the namespace, so really we'd just be looking for a way to
switch between cacheable/noncached memory?
> ramoops will auto-configure itself and fill available space using its
> default parameters, but it might be nice to have a way to store that
> somewhere (traditionally it's part of device tree or platform data).
> ramoops could grow a "header", but normally the regions are very small
> so I've avoided that.
Several of the other modes (BTT and DAX) have space for additional
metadata in their namespaces. If we just need a single bit, though,
maybe we can grab that out of the "flags" field of the namespace
label.
http://pmem.io/documents/NVDIMM_Namespace_Spec.pdf section 2.2.3.
Dan, is this workable or is there a better option? Is it a useful
feature to have other types of namespaces be able to control their
caching attributes in this way?
> I'm not sure I understand the right way to glue ramoops_probe() to the
> "seed-device" stuff. (It needs to be probed VERY early to catch early
> crashes -- ramoops uses postcore_initcall() normally.)
next prev parent reply other threads:[~2018-10-18 20:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 0:29 [PATCH] pstore/ram: Clarify resource reservation labels Kees Cook
2018-10-18 0:49 ` Dan Williams
2018-10-18 7:14 ` Kees Cook
2018-10-18 15:33 ` Dan Williams
2018-10-18 20:31 ` Kees Cook
2018-10-18 20:58 ` Ross Zwisler [this message]
2018-10-18 21:20 ` Kees Cook
2018-10-18 21:35 ` Dan Williams
2018-10-18 22:18 ` Kees Cook
2018-10-18 22:23 ` Dan Williams
2018-10-18 22:26 ` Kees Cook
2018-10-18 22:33 ` Dan Williams
2018-10-18 22:58 ` Kees Cook
2018-10-18 22:43 ` Luck, Tony
2018-10-18 22:49 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGRrVHzd86TYe8sE0S88HObDOXKNAfsX9T=GCo0gkTr2n1wDQw@mail.gmail.com' \
--to=zwisler@google.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=dan.j.williams@intel.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).