From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891Ab2EFCn0 (ORCPT ); Sat, 5 May 2012 22:43:26 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:58416 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742Ab2EFCnY convert rfc822-to-8bit (ORCPT ); Sat, 5 May 2012 22:43:24 -0400 MIME-Version: 1.0 In-Reply-To: <4FA5665D.80304@itdev.co.uk> References: <1334755319-21365-1-git-send-email-djkurtz@chromium.org> <1334755319-21365-10-git-send-email-djkurtz@chromium.org> <4FA5665D.80304@itdev.co.uk> From: Daniel Kurtz Date: Sun, 6 May 2012 10:43:03 +0800 X-Google-Sender-Auth: PiyZGErGeIEmKTu-voZ-LQslRo8 Message-ID: Subject: Re: [PATCH 09/14 v3] Input: atmel_mxt_ts - refactor get info To: Nick Dyer Cc: Dmitry Torokhov , Henrik Rydberg , Joonyoung Shim , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Yufeng Shen Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 6, 2012 at 1:41 AM, Nick Dyer wrote: > Hi Daniel- > > Daniel Kurtz wrote: >> -     dev_info(&client->dev, >> -                     "Family ID: %d Variant ID: %d Version: %d Build: %d\n", >> -                     info->family_id, info->variant_id, info->version, >> -                     info->build); >> +     dev_info(dev, "Family ID: %d Variant ID: %d Major.Minor.Build: %d.%d.%d\n", >> +              info->family_id, info->variant_id, info->version >> 4, >> +              info->version & 0xf, info->build); > > The canonical format for the Atmel firmware versions has the build number > in hex, eg. 2.0.AA > > So it should be %d.%d.%02X Nick, Thanks! Will update. Or perhaps %u.%u.%02X ? -Daniel > > cheers > > Nick