From: Daniel Kurtz <djkurtz@chromium.org>
To: ricardo.ribalda@gmail.com
Cc: adurbin@chromium.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
jslaby@suse.com, marc_gonzalez@sigmadesigns.com,
Doug Anderson <dianders@chromium.org>,
matt.redfearn@mips.com, Jeffy <jeffy.chen@rock-chips.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] serial: 8250_early: Add earlycon support for AMD Carrizo / Stoneyridge
Date: Wed, 14 Mar 2018 16:29:56 +0000 [thread overview]
Message-ID: <CAGS+omCuEYSHFPmknvvvjUpCWFP_rCmwa9utQiO=aEmdm-anwg@mail.gmail.com> (raw)
In-Reply-To: <CAPybu_0uLNz=tRvwqnMfoogJ=A4b5SgMecE9ZihrZdFrbRvcEw@mail.gmail.com>
Hi Ricardo,
On Wed, Mar 14, 2018 at 4:54 AM Ricardo Ribalda Delgado <
ricardo.ribalda@gmail.com> wrote:
> Hi Daniel
> On Wed, Mar 14, 2018 at 1:36 AM, Daniel Kurtz <djkurtz@chromium.org>
wrote:
> >
> > AMD Carrizo / Stoneyridge use a DesignWare 8250 UART that uses a 48 MHz
> > input clock.
> >
> > Allow these platforms to set up this clock by specifying a kernel
command
> > line like:
> > earlycon=amdcz,mmio32,0xfedc6000,115200
> If the port and the mode (mmio32) is always fixed, couldn't we just
> add those two into
> early_amdcz_setup?
There are multiple memory mapped UARTs on at least the one chip I am aware
of, specifying the address here chooses which port to use as the early
console.
In fact, the recommended way is to have firmware specify an ACPI SPCR table
with OEMID="AMDCZ " (see https://patchwork.kernel.org/patch/10281307/) to
configure proper access and address. With an SPCR table in place, the
kernel command line just becomes "earlycon", with no parameters.
-Dan
next prev parent reply other threads:[~2018-03-14 16:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180314003655.12141-1-djkurtz@chromium.org>
2018-03-14 0:36 ` [PATCH 1/3] serial: 8250_early: Add earlycon support for AMD Carrizo / Stoneyridge Daniel Kurtz
2018-03-14 10:35 ` Andy Shevchenko
2018-03-14 10:53 ` Ricardo Ribalda Delgado
2018-03-14 16:29 ` Daniel Kurtz [this message]
2018-03-14 16:38 ` Andy Shevchenko
2018-03-14 17:09 ` Aaron Durbin
2018-03-14 17:12 ` Aaron Durbin
2018-03-14 17:31 ` Andy Shevchenko
2018-03-26 18:24 ` Alan Cox
2018-03-27 2:56 ` Aaron Durbin
2018-03-29 13:34 ` Alan Cox
2018-04-01 18:54 ` Aaron Durbin
2018-04-06 13:47 ` Alan Cox
2018-04-09 16:00 ` Aaron Durbin
2018-03-14 0:36 ` [PATCH 2/3] ACPI: SPCR: Add support for AMD CT/SZ Daniel Kurtz
2018-03-14 10:36 ` Andy Shevchenko
2018-04-17 0:43 ` Jon Masters
2018-03-14 0:36 ` [PATCH 3/3] serial: core: Allow skipping old serial port initialization Daniel Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGS+omCuEYSHFPmknvvvjUpCWFP_rCmwa9utQiO=aEmdm-anwg@mail.gmail.com' \
--to=djkurtz@chromium.org \
--cc=adurbin@chromium.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeffy.chen@rock-chips.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marc_gonzalez@sigmadesigns.com \
--cc=matt.redfearn@mips.com \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).