From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbbGORlZ (ORCPT ); Wed, 15 Jul 2015 13:41:25 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:35281 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbbGORlX (ORCPT ); Wed, 15 Jul 2015 13:41:23 -0400 MIME-Version: 1.0 In-Reply-To: <1436783694-30717-2-git-send-email-s.hauer@pengutronix.de> References: <1436783694-30717-1-git-send-email-s.hauer@pengutronix.de> <1436783694-30717-2-git-send-email-s.hauer@pengutronix.de> From: Daniel Kurtz Date: Thu, 16 Jul 2015 01:41:02 +0800 X-Google-Sender-Auth: GJAKYWWYVfj4uhUExPBzWn63qSU Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller To: Sascha Hauer Cc: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , "linux-kernel@vger.kernel.org" , Sasha Hauer , linux-mediatek@lists.infradead.org, "linux-arm-kernel@lists.infradead.org" , Matthias Brugger Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2015 at 6:34 PM, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer > --- > .../bindings/thermal/mediatek-thermal.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > new file mode 100644 > index 0000000..d90e4dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > @@ -0,0 +1,38 @@ > +* Mediatek Thermal > + > +This describes the device tree binding for the Mediatek thermal controller > +which measures the on-SoC temperatures. This device does not have its own ADC, > +instead it directly controls the AUXADC via AHB bus accesses. For this reason > +this device needs phandles to the AUXADC. Also it controls a mux in the > +apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS > +is also needed. > + > +Required properties: > +- compatible: "mediatek,mt8173-thermal" > +- reg: Address range of the thermal controller > +- interrupts: IRQ for the thermal controller > +- clocks, clock-names: Clocks needed for the thermal controller. required > + clocks are: > + "therm": Main clock needed for register access > + "auxadc": The AUXADC clock > +- resets, reset-names: Reference to the reset controller controlling the thermal > + controller. Required reset-names: > + "therm": The main reset line > +- auxadc: A phandle to the AUXADC which the thermal controller uses > +- apmixedsys: A phandle to the APMIXEDSYS controller. Hmm, shouldn't these custom properties be prefixed with: "mediatek,..." -Dan > +- #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description > + > +Example: > + > + thermal: thermal@1100b000 { > + #thermal-sensor-cells = <1>; > + compatible = "mediatek,mt8173-thermal"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = <0 70 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; > + clock-names = "therm", "auxadc"; > + resets = <&pericfg MT8173_PERI_THERM_SW_RST>; > + reset-names = "therm"; > + auxadc = <&auxadc>; > + apmixedsys = <&apmixedsys>; > + }; > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/