From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4C3C43334 for ; Thu, 2 Jun 2022 17:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237655AbiFBRpi (ORCPT ); Thu, 2 Jun 2022 13:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbiFBRph (ORCPT ); Thu, 2 Jun 2022 13:45:37 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81CC22AE9FC for ; Thu, 2 Jun 2022 10:45:36 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id c2so7199358edf.5 for ; Thu, 02 Jun 2022 10:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O/j8ff/empoIVzIPqKgRJrZ1yf+Uabh8CB6phARQHw8=; b=pjj97zVwrM2CrMZNQ3YkjATsb+hGhtkoV0IpDJjgCaefeTLDdnSoin2KLI9/QKKmxO oA3TdT7FkZz2tbI4HStW8JyPCbfhVf0FHFBe6OppQ77QKTNmsKLy/hQckjF20VRrgdna WwLC6aH/+MnQQ7yWyEgjSOj1N779suPF85G7D73rEpHEoJwWe38490e8Ul2h9EviJOzQ dZsuwxUIzJbucpc5J+ygfZ8y4wx580vg1bv3nY1mJ+Ger3GGq95WzFb6ykyto88yD8av OchcgEkqmZiP0Sys7Ju/I+lMSWVVA4zu+08fZAJUvuParWjBk3U901h2VCPqXupCrG07 4+Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O/j8ff/empoIVzIPqKgRJrZ1yf+Uabh8CB6phARQHw8=; b=2MFOZHVX0pNAaojAbKlvYccL2EbCUcs7LXt3nAwNCRK+GKyEjzEcg0La8F5d16myNI YpPl1/3J0hLUOLYjJ6n1N6K2pd8Iv4SfbkQ+dlWH7mYJMVkBze/1/m+Cwg7GFLd393Nf 8akD7Xvl3opt1RhvR91nss+fQ/RcG6qRUlfFOEYZksSU3DwluDtGzbAuQ/2txTTeFGPf 5e+KKnFED4r5iyylo+2PvQZFSoR1qjAKTfSuQfL1TEHFabX6GcnPGOi6dlyzJq5pi9fe yoIgU4WwnHcHtc5jJIPaz2RaCrobnJ4Vwmalo9snvp6d7B0QNT5OCoEyeKO4kv283/xb Gujg== X-Gm-Message-State: AOAM530urSnN7ZDL0olcGYCOkcXUmdNjsfJ2QHEg5S+DuMXGANt9Eqe0 Y/ItbtHmeBI7ihmzdGLane0lwnIIgwm35FpbIcQZ2Q== X-Google-Smtp-Source: ABdhPJzvUvlqNLSSWFHR1VOLU0xd2hgNWjjf5TY1pOrfxuPXl16DBLKRH8bOnbtdyu7oiCDTr/0gmfUg7LVZaOjTtN0= X-Received: by 2002:a05:6402:2806:b0:42b:67fc:8565 with SMTP id h6-20020a056402280600b0042b67fc8565mr6689418ede.230.1654191934879; Thu, 02 Jun 2022 10:45:34 -0700 (PDT) MIME-Version: 1.0 References: <20220530102017.471865-1-jose.exposito89@gmail.com> <20220530102017.471865-2-jose.exposito89@gmail.com> <20220530131158.kqq2mohxoh52xpeg@penduick> <20220530162903.GA6546@elementary> In-Reply-To: From: Daniel Latypov Date: Thu, 2 Jun 2022 10:45:23 -0700 Message-ID: Subject: Re: [RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332() To: Javier Martinez Canillas Cc: David Gow , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Maxime Ripard , KUnit Development , tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 2, 2022 at 10:29 AM Javier Martinez Canillas wrote: > > Or, without the .kunitconfig: > > ./tools/testing/kunit/kunit.py run --kconfig_add CONFIG_DRM=y > > --kconfig_add CONFIG_DRM_FORMAR_HELPER_TEST=y --kconfig_add > > CONFIG_VIRTIO_UML=y --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y > > 'drm-*' > > > > I wonder if would make sense to have for example an arch/um/.kunitconfig > with those symbols and maybe others and then the tests could also be run > with something like: > > ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/.kunitconfig \ > --kunitconfig=arch/um/.kunitconfig Yeah, this came up before. It'd be nice to have * --kunitconfig be repeatable (it isn't right now) * a "uml_pci.config" with the magic needed to set CONFIG_PCI=y on UML Another example where this would be useful, coverage on UML CONFIG_DEBUG_KERNEL=y CONFIG_DEBUG_INFO=y CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y CONFIG_GCOV=y I did prototype the changes to support this but never sent anything out since I had some concerns, namely: 1. we'd be blindly appending them, but that won't always work. Would users be ok with that? 2. people are already confused about .kunitconfig. It seems like the most confusing part to new people, especially those new to kernel development. Would adding this make them even more lost? Perhaps making the docs clearer on this would a good pre-req. 3. What conventions should there be around these partial configs? I think the idea should be more generic than just kunit. 4. --kconfig_add now makes this possible, even if in a noisier way than another --kunitconfig 5. we didn't have a good way of reporting options set to different values. https://lore.kernel.org/linux-kselftest/20220520224200.3764027-1-dlatypov@google.com/ would help by giving us an easier way to give clearer error messages. That said, I'm willing to whip up another version based on the patch in #5. I think we need a docs rewrite for #2, which I can take a stab at. But I think we'll need some bikeshedding about naming (#3). Daniel